René's URL Explorer Experiment


Title: `in` keyword should narrow Union[TypedDict, ...] · Issue #9953 · python/mypy · GitHub

Open Graph Title: `in` keyword should narrow Union[TypedDict, ...] · Issue #9953 · python/mypy

X Title: `in` keyword should narrow Union[TypedDict, ...] · Issue #9953 · python/mypy

Description: Feature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that your types from a Union as well. This wo...

Open Graph Description: Feature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that ...

X Description: Feature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that ...

Opengraph URL: https://github.com/python/mypy/issues/9953

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`in` keyword should narrow Union[TypedDict, ...]","articleBody":"**Feature**\r\n\r\nUsing `in` on a `Union[TypedDict]` should narrow the `Union`.  There is already something similar for `isinstance` that can narrow based on types. If a certain key exists you could narrow down that your types from a Union as well. This would prevent an error saying a certain key is missing because you checked already, they code can safely access the key. Currently the only workaround for this would be to use `cast()` but really shouldn't be necessary.\r\n\r\n**Pitch**\r\n\r\nAfter the change the following code should pass validation.\r\n\r\n```python\r\nfrom typing import castm Union\r\nfrom typing_extensions import TypedDict\r\n\r\nclass Movie(TypedDict):\r\n    name: str\r\n    year: int\r\n\r\nclass MovieResponse(TypedDict):\r\n    movie: Movie\r\n\r\nclass Book(TypedDict):\r\n    name: str\r\n    year: int\r\n\r\nclass BookResponse(TypedDict):\r\n    book: Book\r\n\r\nMediaResponse = Union[MovieResponse, BookResponse]\r\n\r\nresponse : MediaResponse = MovieResponse(movie=Movie(name=\"Blade Runner\", year=1982))\r\n\r\nif 'movie' in response:\r\n    reveal_type(response)  # Current: Union[MovieResponse, BookResponse]\r\n                           # Desired: Union[MovieResponse]\r\n    print(response[\"movie\"])  # This fails due to `BookResponse` not having a key \"movie\"\r\n                              # but we already validated existance of the 'movie' key and that type\r\n                              # should no longer be considered here\r\n    print(cast(MovieResponse, response)[\"movie\"])  # current workaround\r\n```","author":{"url":"https://github.com/mashumafi","@type":"Person","name":"mashumafi"},"datePublished":"2021-01-24T04:50:56Z","url":"https://github.com/python/mypy/issues/9953"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:03f79e40-5320-ab72-ddff-2bcf7625cc36
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8D64:C5FC2:18A6C12:2089830:6B002700
html-safe-noncee23b2d22ed84468040aff984dc5c4bd5263471bf6de91b7509ad7db69f6788e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDY0OkM1RkMyOjE4QTZDMTI6MjA4OTgzMDo2QjAwMjcwMCIsInZpc2l0b3JfaWQiOiI0NzUwMTgwNjc1NjMyNTk2NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacabb0c4f2faf4ddf5ebf8e96277a3dc711c3c613654928fae5d0cd64661e9936f
hovercard-subject-tagissue:792720567
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9953/issue_layout
twitter:imagehttps://opengraph.githubassets.com/206f98feecf4e4c01c9e28b00c52577723538209dc6e4463ec48636016a51e13/python/mypy/issues/9953
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/206f98feecf4e4c01c9e28b00c52577723538209dc6e4463ec48636016a51e13/python/mypy/issues/9953
og:image:altFeature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemashumafi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9953#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9953
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9953
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9953
Reloadhttps://github.com/python/mypy/issues/9953
Reloadhttps://github.com/python/mypy/issues/9953
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9953
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9953
in keyword should narrow Union[TypedDict, ...]https://github.com/python/mypy/issues/9953#top
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com/mashumafi
mashumafihttps://github.com/mashumafi
on Jan 24, 2021https://github.com/python/mypy/issues/9953#issue-792720567
mashumafihttps://github.com/mashumafi
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on Jan 24, 2021https://github.com/python/mypy/issues/9953#event-4242164422
JelleZijlstrahttps://github.com/JelleZijlstra
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on Mar 19, 2022https://github.com/python/mypy/issues/9953#event-6270086054
https://github.com/michaeloliverx
michaeloliverxhttps://github.com/michaeloliverx
on May 23, 2023https://github.com/python/mypy/issues/9953#issuecomment-1559400679
"The in operator narrowing"https://www.typescriptlang.org/docs/handbook/2/narrowing.html#the-in-operator-narrowing
https://github.com/choucavalier
choucavalierhttps://github.com/choucavalier
on Jul 17, 2023https://github.com/python/mypy/issues/9953#issuecomment-1638129520
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Jul 17, 2023https://github.com/python/mypy/issues/9953#issuecomment-1638930945
#13838https://github.com/python/mypy/pull/13838
@AlexWaygoodhttps://github.com/AlexWaygood
#15695https://github.com/python/mypy/issues/15695
https://github.com/choucavalier
choucavalierhttps://github.com/choucavalier
on Jul 20, 2023https://github.com/python/mypy/issues/9953#issuecomment-1644163606
@ikonsthttps://github.com/ikonst
https://github.com/ikonst
ikonsthttps://github.com/ikonst
on Jul 20, 2023https://github.com/python/mypy/issues/9953#issuecomment-1644166162
#15697https://github.com/python/mypy/issues/15697
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9953
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9953
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.