Title: `in` keyword should narrow Union[TypedDict, ...] · Issue #9953 · python/mypy · GitHub
Open Graph Title: `in` keyword should narrow Union[TypedDict, ...] · Issue #9953 · python/mypy
X Title: `in` keyword should narrow Union[TypedDict, ...] · Issue #9953 · python/mypy
Description: Feature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that your types from a Union as well. This wo...
Open Graph Description: Feature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that ...
X Description: Feature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that ...
Opengraph URL: https://github.com/python/mypy/issues/9953
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`in` keyword should narrow Union[TypedDict, ...]","articleBody":"**Feature**\r\n\r\nUsing `in` on a `Union[TypedDict]` should narrow the `Union`. There is already something similar for `isinstance` that can narrow based on types. If a certain key exists you could narrow down that your types from a Union as well. This would prevent an error saying a certain key is missing because you checked already, they code can safely access the key. Currently the only workaround for this would be to use `cast()` but really shouldn't be necessary.\r\n\r\n**Pitch**\r\n\r\nAfter the change the following code should pass validation.\r\n\r\n```python\r\nfrom typing import castm Union\r\nfrom typing_extensions import TypedDict\r\n\r\nclass Movie(TypedDict):\r\n name: str\r\n year: int\r\n\r\nclass MovieResponse(TypedDict):\r\n movie: Movie\r\n\r\nclass Book(TypedDict):\r\n name: str\r\n year: int\r\n\r\nclass BookResponse(TypedDict):\r\n book: Book\r\n\r\nMediaResponse = Union[MovieResponse, BookResponse]\r\n\r\nresponse : MediaResponse = MovieResponse(movie=Movie(name=\"Blade Runner\", year=1982))\r\n\r\nif 'movie' in response:\r\n reveal_type(response) # Current: Union[MovieResponse, BookResponse]\r\n # Desired: Union[MovieResponse]\r\n print(response[\"movie\"]) # This fails due to `BookResponse` not having a key \"movie\"\r\n # but we already validated existance of the 'movie' key and that type\r\n # should no longer be considered here\r\n print(cast(MovieResponse, response)[\"movie\"]) # current workaround\r\n```","author":{"url":"https://github.com/mashumafi","@type":"Person","name":"mashumafi"},"datePublished":"2021-01-24T04:50:56Z","url":"https://github.com/python/mypy/issues/9953"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:03f79e40-5320-ab72-ddff-2bcf7625cc36 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8D64:C5FC2:18A6C12:2089830:6B002700 |
| html-safe-nonce | e23b2d22ed84468040aff984dc5c4bd5263471bf6de91b7509ad7db69f6788e3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDY0OkM1RkMyOjE4QTZDMTI6MjA4OTgzMDo2QjAwMjcwMCIsInZpc2l0b3JfaWQiOiI0NzUwMTgwNjc1NjMyNTk2NDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | abb0c4f2faf4ddf5ebf8e96277a3dc711c3c613654928fae5d0cd64661e9936f |
| hovercard-subject-tag | issue:792720567 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9953/issue_layout |
| twitter:image | https://opengraph.githubassets.com/206f98feecf4e4c01c9e28b00c52577723538209dc6e4463ec48636016a51e13/python/mypy/issues/9953 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/206f98feecf4e4c01c9e28b00c52577723538209dc6e4463ec48636016a51e13/python/mypy/issues/9953 |
| og:image:alt | Feature Using in on a Union[TypedDict] should narrow the Union. There is already something similar for isinstance that can narrow based on types. If a certain key exists you could narrow down that ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mashumafi |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width