René's URL Explorer Experiment


Title: `==` Narrows the type of an Enum in an if-elif block when following an `is` · Issue #9786 · python/mypy · GitHub

Open Graph Title: `==` Narrows the type of an Enum in an if-elif block when following an `is` · Issue #9786 · python/mypy

X Title: `==` Narrows the type of an Enum in an if-elif block when following an `is` · Issue #9786 · python/mypy

Description: is and == work strangely together when narrowing the type of an Enum in an if-elif block. It is known that you need to use is rather than == to narrow the type of an Enum, but it seems if the if statement uses is then the elif can have =...

Open Graph Description: is and == work strangely together when narrowing the type of an Enum in an if-elif block. It is known that you need to use is rather than == to narrow the type of an Enum, but it seems if the if st...

X Description: is and == work strangely together when narrowing the type of an Enum in an if-elif block. It is known that you need to use is rather than == to narrow the type of an Enum, but it seems if the if st...

Opengraph URL: https://github.com/python/mypy/issues/9786

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`==` Narrows the type of an Enum in an if-elif block when following an `is`","articleBody":"\u003c!--\r\n  If you're new to mypy and you're not sure whether what you're experiencing is a mypy bug, please see the \"Question and Help\" form\r\n  instead.\r\n-->\r\n\r\n`is` and `==` work strangely together when narrowing the type of an `Enum` in an if-elif block.  [It is known](https://github.com/python/mypy/issues/6366#issuecomment-673876383) that you need to use `is` rather than `==` to narrow the type of an `Enum`, but it seems if the `if` statement uses `is` then the `elif` can have `==` and still narrow the type of the variable.\r\n\r\n**To Reproduce**\r\n```\r\nfrom enum import Enum\r\n\r\nclass Foo(Enum):\r\n    A = 1\r\n    B = 2\r\n    C = 3\r\n\r\ndef f0(x: Foo) -> str:\r\n    if x is Foo.A:\r\n        return 'one'\r\n    elif x == Foo.B:\r\n        return 'two'\r\n    elif x == Foo.C:\r\n        return 'three'\r\n    reveal_type(x)  # Not revealed by mypy as it apparently considers this line unreachable\r\n```\r\nThis is compared to how have come to expect `==` to work with an enum where it will not narrow the type.\r\n\r\n```\r\ndef f1(x: Foo) -> str:\r\n    if x == Foo.A:\r\n        return 'one'\r\n    elif x == Foo.B:\r\n        return 'two'\r\n    elif x == Foo.C:\r\n        return 'three'\r\n    reveal_type(x)  # Revealed type is Foo\r\n```\r\nInterestingly this doesn't just occur when an `is` is used in the `if`.  It can occur in an `elif` and still \"propogate\" its narrowing ability to the following `==`'s.\r\n```\r\ndef f2(x: Foo) -> str:\r\n    if x == Foo.A:\r\n        return 'one'\r\n    elif x is Foo.B:\r\n        return 'two'\r\n    elif x == Foo.C:\r\n        return 'three'\r\n    reveal_type(x)  # Revealed type is Literal[Foo.A]\r\n```\r\n\r\n**Expected Behavior**\r\n\r\n\r\n`==` would either narrow the type of an enum or not and it would not depend on whether or not it was preceded by an `is`.\r\n\r\n**Actual Behavior**\r\n\r\n`==` narrows the type of an enum only when it is preceded by an `is`.\r\n\r\n**Your Environment**\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: 0.790\r\n- Mypy command-line flags: none or `--strict` will both demonstrate this behavior\r\n- Mypy configuration options from `mypy.ini` (and other config files):\r\n```\r\n[mypy]\r\ndisallow_any_decorated = True\r\ndisallow_any_explicit = True\r\ndisallow_any_generics = True\r\ndisallow_subclassing_any = True\r\ndisallow_untyped_defs = True\r\ndisallow_untyped_calls = True\r\ndisallow_incomplete_defs = True\r\ndisallow_untyped_decorators = True\r\n```\r\n- Python version used: 3.9.0\r\n- Operating system and version: Ubuntu 20.04.1 LTS under WSL\r\n\r\n","author":{"url":"https://github.com/parsons-kyle-89","@type":"Person","name":"parsons-kyle-89"},"datePublished":"2020-12-09T00:19:13Z","url":"https://github.com/python/mypy/issues/9786"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9aebfaf4-8cb9-879b-b0e1-2d0b3566cf51
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB786:3CBF1A:25EB0A6:340ACDD:6B0047ED
html-safe-nonceb258a873875d2cfa5e03baa458987c86002e839e52ce2e8165e05c0fb1bbb2ed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzg2OjNDQkYxQToyNUVCMEE2OjM0MEFDREQ6NkIwMDQ3RUQiLCJ2aXNpdG9yX2lkIjoiNTE2Nzk5Njg0NzU1NzQ2MTk5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace1662032b90a47e0094fdc3b4180020e87855b61020f73431621a206cdb5935b
hovercard-subject-tagissue:759885218
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9786/issue_layout
twitter:imagehttps://opengraph.githubassets.com/747e033e044a6aef83c7c7b8c43e937e4805bc9fc66111d903961bf8bc800e07/python/mypy/issues/9786
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/747e033e044a6aef83c7c7b8c43e937e4805bc9fc66111d903961bf8bc800e07/python/mypy/issues/9786
og:image:altis and == work strangely together when narrowing the type of an Enum in an if-elif block. It is known that you need to use is rather than == to narrow the type of an Enum, but it seems if the if st...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameparsons-kyle-89
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9786#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9786
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9786
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9786
Reloadhttps://github.com/python/mypy/issues/9786
Reloadhttps://github.com/python/mypy/issues/9786
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9786
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9786
#11521https://github.com/python/mypy/pull/11521
== Narrows the type of an Enum in an if-elif block when following an ishttps://github.com/python/mypy/issues/9786#top
#11521https://github.com/python/mypy/pull/11521
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-enumhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-enum%22
https://github.com/parsons-kyle-89
parsons-kyle-89https://github.com/parsons-kyle-89
on Dec 9, 2020https://github.com/python/mypy/issues/9786#issue-759885218
It is knownhttps://github.com/python/mypy/issues/6366#issuecomment-673876383
parsons-kyle-89https://github.com/parsons-kyle-89
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Dec 9, 2020https://github.com/python/mypy/issues/9786#event-4087343823
hauntsaninjahttps://github.com/hauntsaninja
on Nov 11, 2021https://github.com/python/mypy/issues/9786#event-5602621194
Allow narrowing enum values using ==https://github.com/hauntsaninja/mypy/commit/db11aa5c13884bf3a9005767d5a00c428eabae29
https://docs.github.com/articles/closing-issues-via-commit-messages
db11aa5https://github.com/hauntsaninja/mypy/commit/db11aa5c13884bf3a9005767d5a00c428eabae29
97littleleaf11https://github.com/97littleleaf11
topic-enumhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-enum%22
on Nov 17, 2021https://github.com/python/mypy/issues/9786#event-5629045377
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Apr 1, 2022https://github.com/python/mypy/issues/9786#issuecomment-1085986978
#10915https://github.com/python/mypy/issues/10915
AlexWaygoodhttps://github.com/AlexWaygood
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 1, 2022https://github.com/python/mypy/issues/9786#event-6353011679
hauntsaninjahttps://github.com/hauntsaninja
on Apr 24, 2023https://github.com/python/mypy/issues/9786#event-9077467940
Allow narrowing enum values using == (#11521)https://github.com/python/mypy/commit/0061d6edea433a76d6ea2e34551ca89bfa5291ba
#11521https://github.com/python/mypy/pull/11521
https://docs.github.com/articles/closing-issues-via-commit-messages
0061d6ehttps://github.com/python/mypy/commit/0061d6edea433a76d6ea2e34551ca89bfa5291ba
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9786
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9786
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-enumhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-enum%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.