René's URL Explorer Experiment


Title: `@final` decorator is not honored on override with --check-untyped-defs · Issue #9618 · python/mypy · GitHub

Open Graph Title: `@final` decorator is not honored on override with --check-untyped-defs · Issue #9618 · python/mypy

X Title: `@final` decorator is not honored on override with --check-untyped-defs · Issue #9618 · python/mypy

Description: Bug Report Overriding class methods marked with @final (pep-0591) are not reported as errors. The example script will not produce an error with mypy even though it probably should. #9612 is potentially related, but they have a final prob...

Open Graph Description: Bug Report Overriding class methods marked with @final (pep-0591) are not reported as errors. The example script will not produce an error with mypy even though it probably should. #9612 is potenti...

X Description: Bug Report Overriding class methods marked with @final (pep-0591) are not reported as errors. The example script will not produce an error with mypy even though it probably should. #9612 is potenti...

Opengraph URL: https://github.com/python/mypy/issues/9618

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`@final` decorator is not honored on override with --check-untyped-defs","articleBody":"**Bug Report**\r\n\r\nOverriding class methods marked with `@final` [(pep-0591)](https://www.python.org/dev/peps/pep-0591/) are not reported as errors. The example script will not produce an error with `mypy` even though it probably should. \r\n\r\n#9612 is potentially related, but they have a `final` problem in the other direction.\r\n\r\n**To Reproduce**\r\n\r\n```python\r\nfrom typing import final\r\n\r\nclass Base:\r\n    @final\r\n    def foo(self):\r\n        pass\r\n\r\n    def bar(self):\r\n        pass\r\n\r\nclass Derived(Base):\r\n    def foo(self):\r\n        pass\r\n```\r\n\r\n**Your Environment**\r\n\r\n```\r\n✗ python --version && mypy --version && mypy foo.py \r\nPython 3.8.5\r\nmypy 0.790\r\nSuccess: no issues found in 1 source file\r\n```\r\n","author":{"url":"https://github.com/tfranzel","@type":"Person","name":"tfranzel"},"datePublished":"2020-10-20T15:29:56Z","url":"https://github.com/python/mypy/issues/9618"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:250987aa-80d8-b226-9ad2-116023f06162
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA8FC:3430F7:4EF28B:6A86EF:6B002F13
html-safe-nonceaf7675c921497e5d48f4d7a22fdc0b64637b6904916c03d258316f0bb324cda2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEZDOjM0MzBGNzo0RUYyOEI6NkE4NkVGOjZCMDAyRjEzIiwidmlzaXRvcl9pZCI6IjI5MjQxMjQ2ODAyMTIxOTcxNDAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd33dc6ec709d0b0e542ff4860ca4882d0ef48686ade16285ce33ca753d67550c
hovercard-subject-tagissue:725711266
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9618/issue_layout
twitter:imagehttps://opengraph.githubassets.com/71e3dde70f36940df6029bb4818311dc343521d45ab767513efe36c6aa133e0e/python/mypy/issues/9618
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/71e3dde70f36940df6029bb4818311dc343521d45ab767513efe36c6aa133e0e/python/mypy/issues/9618
og:image:altBug Report Overriding class methods marked with @final (pep-0591) are not reported as errors. The example script will not produce an error with mypy even though it probably should. #9612 is potenti...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametfranzel
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9618#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9618
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9618
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9618
Reloadhttps://github.com/python/mypy/issues/9618
Reloadhttps://github.com/python/mypy/issues/9618
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9618
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9618
#17276https://github.com/python/mypy/pull/17276
@final decorator is not honored on override with --check-untyped-defshttps://github.com/python/mypy/issues/9618#top
#17276https://github.com/python/mypy/pull/17276
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
good-second-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-second-issue%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
https://github.com/tfranzel
tfranzelhttps://github.com/tfranzel
on Oct 20, 2020https://github.com/python/mypy/issues/9618#issue-725711266
(pep-0591)https://www.python.org/dev/peps/pep-0591/
#9612https://github.com/python/mypy/issues/9612
tfranzelhttps://github.com/tfranzel
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Oct 20, 2020https://github.com/python/mypy/issues/9618#event-3899397423
https://github.com/a-reich
a-reichhttps://github.com/a-reich
on Oct 27, 2020https://github.com/python/mypy/issues/9618#issuecomment-716918978
addedhttps://mypy-play.net/?mypy=0.790&python=3.8&gist=7750b13ddcf5af035beac318d3528c51
https://github.com/tfranzel
tfranzelhttps://github.com/tfranzel
on Nov 1, 2020https://github.com/python/mypy/issues/9618#issuecomment-720086445
@a-reichhttps://github.com/a-reich
https://github.com/a-reich
a-reichhttps://github.com/a-reich
on Nov 1, 2020https://github.com/python/mypy/issues/9618#issuecomment-720144855
@tfranzelhttps://github.com/tfranzel
https://github.com/tfranzel
tfranzelhttps://github.com/tfranzel
on Nov 1, 2020https://github.com/python/mypy/issues/9618#issuecomment-720146193
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Nov 1, 2020https://github.com/python/mypy/issues/9618#issuecomment-720149335
AlexWaygoodhttps://github.com/AlexWaygood
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
on Apr 1, 2022https://github.com/python/mypy/issues/9618#event-6354548017
hauntsaninjahttps://github.com/hauntsaninja
on Aug 13, 2023https://github.com/python/mypy/issues/9618#event-10080585185
hauntsaninjahttps://github.com/hauntsaninja
good-second-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-second-issue%22
on Aug 13, 2023https://github.com/python/mypy/issues/9618#event-10080585456
stroxlerhttps://github.com/stroxler
on May 21, 2024https://github.com/python/mypy/issues/9618#event-12883426521
Check override compatibility for dynamically typed methodshttps://github.com/stroxler/mypy/commit/41c00cafe00f778232e73e11f614d7b57f462d97
https://docs.github.com/articles/closing-issues-via-commit-messages
41c00cahttps://github.com/stroxler/mypy/commit/41c00cafe00f778232e73e11f614d7b57f462d97
Check override compatibility for dynamically typed methodshttps://github.com/stroxler/mypy/commit/a463090c398e0f8fc4772df743a5ba266fd90522
https://docs.github.com/articles/closing-issues-via-commit-messages
a463090https://github.com/stroxler/mypy/commit/a463090c398e0f8fc4772df743a5ba266fd90522
Validate more about overrides on untyped methodshttps://github.com/stroxler/mypy/commit/3b5105ecfed77e30538d3733bea149ae76851721
https://docs.github.com/articles/closing-issues-via-commit-messages
3b5105ehttps://github.com/stroxler/mypy/commit/3b5105ecfed77e30538d3733bea149ae76851721
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#17276https://github.com/python/mypy/pull/17276
on May 23, 2024https://github.com/python/mypy/issues/9618#event-12903844931
hauntsaninjahttps://github.com/hauntsaninja
on May 23, 2024https://github.com/python/mypy/issues/9618#event-12903844949
Validate more about overrides on untyped methods (#17276)https://github.com/python/mypy/commit/25087fdbb72d1495e6903d171dee999c47ba09fd
#17276https://github.com/python/mypy/pull/17276
https://docs.github.com/articles/closing-issues-via-commit-messages
25087fdhttps://github.com/python/mypy/commit/25087fdbb72d1495e6903d171dee999c47ba09fd
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9618
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9618
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
good-second-issuehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22good-second-issue%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.