René's URL Explorer Experiment


Title: Chained calls with medium/large dict/list literals are slow to typecheck · Issue #9427 · python/mypy · GitHub

Open Graph Title: Chained calls with medium/large dict/list literals are slow to typecheck · Issue #9427 · python/mypy

X Title: Chained calls with medium/large dict/list literals are slow to typecheck · Issue #9427 · python/mypy

Description: 🐛 Bug Report Variable assignments with chained calls converting dict/list literals are surprisingly slow to typecheck. Interestingly, breaking down the assignment into multiple steps often yields noticeable performance improvement. To Re...

Open Graph Description: 🐛 Bug Report Variable assignments with chained calls converting dict/list literals are surprisingly slow to typecheck. Interestingly, breaking down the assignment into multiple steps often yields n...

X Description: 🐛 Bug Report Variable assignments with chained calls converting dict/list literals are surprisingly slow to typecheck. Interestingly, breaking down the assignment into multiple steps often yields n...

Opengraph URL: https://github.com/python/mypy/issues/9427

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Chained calls with medium/large dict/list literals are slow to typecheck","articleBody":"\r\n## 🐛 Bug Report\r\n\r\nVariable assignments with chained calls converting dict/list literals are surprisingly slow to typecheck. Interestingly, breaking down the assignment into multiple steps often yields noticeable performance improvement.\r\n\r\n## To Reproduce\r\n\r\nFor instance, consider:\r\n\r\n```\r\nfrom decimal import Decimal\r\nfrom collections import OrderedDict\r\n\r\nGRID = OrderedDict(sorted({\r\n    (93, 659): Decimal('0.3000'), (93, 714): Decimal('0.2950'), (93, 749): Decimal('0.2820'), (93, 799): Decimal('0.2690'), (93, 850): Decimal('0.1990'),  # noqa: E501\r\n    (94, 659): Decimal('0.3000'), (94, 714): Decimal('0.2900'), (94, 749): Decimal('0.2745'), (94, 799): Decimal('0.2590'), (94, 850): Decimal('0.1820'),  # noqa: E501\r\n    (95, 659): Decimal('0.3000'), (95, 714): Decimal('0.2850'), (95, 749): Decimal('0.2620'), (95, 799): Decimal('0.2390'), (95, 850): Decimal('0.1620'),  # noqa: E501\r\n    (96, 659): Decimal('0.3000'), (96, 714): Decimal('0.2800'), (96, 749): Decimal('0.2495'), (96, 799): Decimal('0.2190'), (96, 850): Decimal('0.1570'),  # noqa: E501\r\n    (97, 659): Decimal('0.2800'), (97, 714): Decimal('0.2750'), (97, 749): Decimal('0.2370'), (97, 799): Decimal('0.1990'), (97, 850): Decimal('0.1520'),  # noqa: E501\r\n    (98, 659): Decimal('0.2710'), (98, 714): Decimal('0.2650'), (98, 749): Decimal('0.2220'), (98, 799): Decimal('0.1790'), (98, 850): Decimal('0.1470'),  # noqa: E501\r\n    (99, 659): Decimal('0.2500'), (99, 714): Decimal('0.1990'), (99, 749): Decimal('0.1975'), (99, 799): Decimal('0.1670'), (99, 850): Decimal('0.1170'),  # noqa: E501\r\n    (100, 659): Decimal('0.2500'), (100, 714): Decimal('0.1890'), (100, 749): Decimal('0.1500'), (100, 799): Decimal('0.1084'), (100, 850): Decimal('0.1000'),  # noqa: E501\r\n}.items()))\r\n\r\n```\r\n\r\nand the same broken down into two steps:\r\n\r\n```\r\nfrom decimal import Decimal\r\nfrom collections import OrderedDict\r\n\r\nGRID = {\r\n    (93, 659): Decimal('0.3000'), (93, 714): Decimal('0.2950'), (93, 749): Decimal('0.2820'), (93, 799): Decimal('0.2690'), (93, 850): Decimal('0.1990'),  # noqa: E501\r\n    (94, 659): Decimal('0.3000'), (94, 714): Decimal('0.2900'), (94, 749): Decimal('0.2745'), (94, 799): Decimal('0.2590'), (94, 850): Decimal('0.1820'),  # noqa: E501\r\n    (95, 659): Decimal('0.3000'), (95, 714): Decimal('0.2850'), (95, 749): Decimal('0.2620'), (95, 799): Decimal('0.2390'), (95, 850): Decimal('0.1620'),  # noqa: E501\r\n    (96, 659): Decimal('0.3000'), (96, 714): Decimal('0.2800'), (96, 749): Decimal('0.2495'), (96, 799): Decimal('0.2190'), (96, 850): Decimal('0.1570'),  # noqa: E501\r\n    (97, 659): Decimal('0.2800'), (97, 714): Decimal('0.2750'), (97, 749): Decimal('0.2370'), (97, 799): Decimal('0.1990'), (97, 850): Decimal('0.1520'),  # noqa: E501\r\n    (98, 659): Decimal('0.2710'), (98, 714): Decimal('0.2650'), (98, 749): Decimal('0.2220'), (98, 799): Decimal('0.1790'), (98, 850): Decimal('0.1470'),  # noqa: E501\r\n    (99, 659): Decimal('0.2500'), (99, 714): Decimal('0.1990'), (99, 749): Decimal('0.1975'), (99, 799): Decimal('0.1670'), (99, 850): Decimal('0.1170'),  # noqa: E501\r\n    (100, 659): Decimal('0.2500'), (100, 714): Decimal('0.1890'), (100, 749): Decimal('0.1500'), (100, 799): Decimal('0.1084'), (100, 850): Decimal('0.1000'),  # noqa: E501\r\n}\r\n\r\nGG = OrderedDict(sorted(GRID.items()))\r\n```\r\n## Expected Behavior\r\n\r\nI would expect the two samples above to typecheck in roughly equivalent amounts of time.\r\n## Actual Behavior\r\n\r\nVariant 1 is much slower to typecheck than variant 2: roughly 700ms vs 70ms (not using mypyc-compiled version)\r\n\r\nThis seems to arise from a combination of repeated computations when typechecking overloaded methods such as `sorted`, typechecking from root to leaf instead of leaf to root, and not caching resolved types for dict/list exprs.\r\n\r\n## Your Environment\r\n\r\n- Mypy version used: 0.790-dev 5906a5d\r\n- Mypy command-line flags: --ignore-missing-imports --show-traceback\r\n- Python version used: 3.7\r\n- Operating system and version: macOS 10.14.6\r\n","author":{"url":"https://github.com/huguesb","@type":"Person","name":"huguesb"},"datePublished":"2020-09-08T03:24:25Z","url":"https://github.com/python/mypy/issues/9427"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8b4fc524-f31f-d9ee-fad8-d938116a4ad1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE328:1A77D:275168:34CE39:6B00241D
html-safe-nonce43eadb218d324bd5075db9a2eec1bbf3ab736845968c7d079afbd2f8bdd845df
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMzI4OjFBNzdEOjI3NTE2ODozNENFMzk6NkIwMDI0MUQiLCJ2aXNpdG9yX2lkIjoiMzYwMTA1MTE5MDA4NDc3Mjg5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc31be3be157358935c59fca56c022945a9532d55cd7aefe62ab0611448c36416
hovercard-subject-tagissue:695514733
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9427/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4fe218926a700e0be61797ad842b6c721189460e616e2ec1211dc21ae9e3d1ff/python/mypy/issues/9427
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4fe218926a700e0be61797ad842b6c721189460e616e2ec1211dc21ae9e3d1ff/python/mypy/issues/9427
og:image:alt🐛 Bug Report Variable assignments with chained calls converting dict/list literals are surprisingly slow to typecheck. Interestingly, breaking down the assignment into multiple steps often yields n...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehuguesb
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9427#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9427
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9427
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9427
Reloadhttps://github.com/python/mypy/issues/9427
Reloadhttps://github.com/python/mypy/issues/9427
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9427
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9427
Chained calls with medium/large dict/list literals are slow to typecheckhttps://github.com/python/mypy/issues/9427#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
https://github.com/huguesb
huguesbhttps://github.com/huguesb
on Sep 8, 2020https://github.com/python/mypy/issues/9427#issue-695514733
5906a5dhttps://github.com/python/mypy/commit/5906a5d8f0fb99e1d9ab0b48b5f85b158416c371
huguesbhttps://github.com/huguesb
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Sep 8, 2020https://github.com/python/mypy/issues/9427#event-3738910370
AlexWaygoodhttps://github.com/AlexWaygood
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
on Mar 27, 2022https://github.com/python/mypy/issues/9427#event-6313583472
huguesbhttps://github.com/huguesb
on May 1, 2022https://github.com/python/mypy/issues/9427#event-6529054486
checkexpr: speedup typechecking of container literals with tuple entrieshttps://github.com/huguesb/mypy/commit/a832e88e45acf9c1c1b24d7aebd0a0e03a80bad3
a832e88https://github.com/huguesb/mypy/commit/a832e88e45acf9c1c1b24d7aebd0a0e03a80bad3
checkexpr: speedup typechecking of container literals with tuple entrieshttps://github.com/huguesb/mypy/commit/3adb6e3446db1329faa424361fca75d250ee1327
3adb6e3https://github.com/huguesb/mypy/commit/3adb6e3446db1329faa424361fca75d250ee1327
checkexpr: cache type of container literals when possiblehttps://github.com/huguesb/mypy/commit/8b2bf54a284da2688c6027873483f3001048acd8
8b2bf54https://github.com/huguesb/mypy/commit/8b2bf54a284da2688c6027873483f3001048acd8
checkexpr: cache type of container literals when possiblehttps://github.com/huguesb/mypy/commit/3acbc1f85b442912ccc4a6875845f5025ebbcde5
3acbc1fhttps://github.com/huguesb/mypy/commit/3acbc1f85b442912ccc4a6875845f5025ebbcde5
https://github.com/huguesb
huguesbhttps://github.com/huguesb
on May 1, 2022https://github.com/python/mypy/issues/9427#issuecomment-1114158229
#12706https://github.com/python/mypy/pull/12706
#12707https://github.com/python/mypy/pull/12707
#12707https://github.com/python/mypy/pull/12707
hauntsaninjahttps://github.com/hauntsaninja
on May 1, 2022https://github.com/python/mypy/issues/9427#event-6530081722
checkexpr: speedup typechecking of container literals with tuple entr…https://github.com/python/mypy/commit/7a2ad43431c182cf01a4b9bf73a3bea8e3fac9aa
7a2ad43https://github.com/python/mypy/commit/7a2ad43431c182cf01a4b9bf73a3bea8e3fac9aa
huguesbhttps://github.com/huguesb
on May 3, 2022https://github.com/python/mypy/issues/9427#event-6543874896
checkexpr: cache type of container literals when possiblehttps://github.com/huguesb/mypy/commit/ac1137462a02eb27ffa20a484ee3cab234dbb392
ac11374https://github.com/huguesb/mypy/commit/ac1137462a02eb27ffa20a484ee3cab234dbb392
huguesbhttps://github.com/huguesb
on May 16, 2022https://github.com/python/mypy/issues/9427#event-6613781141
checkexpr: cache type of container literals when possiblehttps://github.com/huguesb/mypy/commit/af675feafaf01d9e628855010ac55e5ad7c8fa01
af675fehttps://github.com/huguesb/mypy/commit/af675feafaf01d9e628855010ac55e5ad7c8fa01
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
1b7e33fhttps://github.com/python/mypy/commit/1b7e33f7ef4105c7ae495085ec52e15f1fc52c5d
on May 20, 2022https://github.com/python/mypy/issues/9427#event-6651794256
JukkaLhttps://github.com/JukkaL
on May 20, 2022https://github.com/python/mypy/issues/9427#event-6651807019
checkexpr: cache type of container literals when possible (#12707)https://github.com/python/mypy/commit/644d5f6f2f503f115e6656336ad266a7e03fd79d
#12707https://github.com/python/mypy/pull/12707
644d5f6https://github.com/python/mypy/commit/644d5f6f2f503f115e6656336ad266a7e03fd79d
hauntsaninjahttps://github.com/hauntsaninja
on Oct 17, 2024https://github.com/python/mypy/issues/9427#event-14693634971
checkexpr: cache type of container literals when possible (python#12707)https://github.com/icgood/mypy/commit/1b7e33f7ef4105c7ae495085ec52e15f1fc52c5d
python#12707https://github.com/python/mypy/pull/12707
1b7e33fhttps://github.com/icgood/mypy/commit/1b7e33f7ef4105c7ae495085ec52e15f1fc52c5d
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9427
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9427
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
performancehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22performance%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.