René's URL Explorer Experiment


Title: Variable loses type inference after passing through dictionary of known type · Issue #9369 · python/mypy · GitHub

Open Graph Title: Variable loses type inference after passing through dictionary of known type · Issue #9369 · python/mypy

X Title: Variable loses type inference after passing through dictionary of known type · Issue #9369 · python/mypy

Description: 🐛 Bug Report (Possibly related to #6755?) When a variable is declared to be of a type including Optional, mypy correctly infers that it is not None when passing through an assert indicating as such. However, if mapped through a dictionar...

Open Graph Description: 🐛 Bug Report (Possibly related to #6755?) When a variable is declared to be of a type including Optional, mypy correctly infers that it is not None when passing through an assert indicating as such...

X Description: 🐛 Bug Report (Possibly related to #6755?) When a variable is declared to be of a type including Optional, mypy correctly infers that it is not None when passing through an assert indicating as such...

Opengraph URL: https://github.com/python/mypy/issues/9369

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Variable loses type inference after passing through dictionary of known type","articleBody":"\u003c!--\r\nNote: If the problem you are reporting is about a specific library function, then the typeshed tracker is better suited\r\nfor this report: https://github.com/python/typeshed/issues\r\n-->\r\n\r\n## 🐛 Bug Report\r\n\r\n(Possibly related to #6755?)\r\n\r\nWhen a variable is declared to be of a type including `Optional`, mypy correctly infers that it is _not_ `None` when passing through an assert indicating as such. However, if mapped through a dictionary with a known type (either by inference or declaration), mypy loses that inference and reverts to the original type definition.\r\n\r\n## To Reproduce\r\n\r\n```python\r\n\r\nfrom typing import (\r\n\tDict,\r\n\tOptional,\r\n)\r\n\r\ndef check1(x: Optional[str]) -> str:\r\n\tassert x  # x: str\r\n\r\n\treturn x  # x: str\r\n\r\ndef check2(x: Optional[str]) -> str:\r\n\tassert x  # x: str\r\n\r\n\tx_map: Dict[str, str] = {\r\n\t\t\"x\": \"y\"\r\n\t}\r\n\tx = x_map.get(x, x)  # x: Optional[str] ??\r\n\r\n\treturn x  # x: Optional[str] ??\r\n\r\ndef check3(x: Optional[str]) -> str:\r\n\tassert x  # x: str\r\n\r\n\tx_map: Dict[str, str] = {\r\n\t\t\"x\": \"y\"\r\n\t}\r\n\tx = x_map.get(x, x)  # x: Optional[str] ??\r\n\r\n\tassert x  # x: str\r\n\r\n\treturn x  # x: str\r\n```\r\n\r\n## Expected Behavior\r\n\r\n\u003c!--\r\n  How did you expect your project to behave?\r\n  It’s fine if you’re not sure your understanding is correct.\r\n  Write down what you thought would happen. If you just expected no errors, you can delete this section.\r\n-->\r\n\r\nThe type of `x` should remain inferred as `str` in `check2`, because both possible return values from `x_map.get(x, x)` are known to be `str`.\r\n\r\n## Actual Behavior\r\n\r\n\u003c!--\r\n  Did something go wrong?\r\n  Is something broken, or not behaving as you expected?\r\n-->\r\n\r\n> 20: error: Incompatible return value type (got \"Optional[str]\", expected \"str\")\r\n\r\n## Your Environment\r\n\r\n\u003c!-- Include as many relevant details about the environment you experienced the bug in -->\r\n\r\n- Mypy version used: mypy 0.782\r\n- Mypy command-line flags: `mypy --strict`\r\n- Python version used: Python 3.6.11\r\n\r\n\u003c!--\r\nYou can freely edit this text, please remove all the lines\r\nyou believe are unnecessary.\r\n-->\r\n","author":{"url":"https://github.com/GPHemsley","@type":"Person","name":"GPHemsley"},"datePublished":"2020-08-28T06:55:29Z","url":"https://github.com/python/mypy/issues/9369"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a8cbff22-dd70-03d6-44c6-b2775148929e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id93C2:18B602:7C1DD:AE79F:6B005171
html-safe-noncef19620d63fd028ac0fb683e2b6715a60bc6d9ebb535efa334cd3101e7f7e7459
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0MyOjE4QjYwMjo3QzFERDpBRTc5Rjo2QjAwNTE3MSIsInZpc2l0b3JfaWQiOiI3MjcxMjA5MTQwOTAxNDAwOTQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf445cbb1fad6bf65af4bceaccbb45f73c770d83687c7c24171c8a71f36bc269b
hovercard-subject-tagissue:687838617
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9369/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8717875f88c6725b59747066556c0fc562819225ebe79b1874fa0b73a96048af/python/mypy/issues/9369
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8717875f88c6725b59747066556c0fc562819225ebe79b1874fa0b73a96048af/python/mypy/issues/9369
og:image:alt🐛 Bug Report (Possibly related to #6755?) When a variable is declared to be of a type including Optional, mypy correctly infers that it is not None when passing through an assert indicating as such...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameGPHemsley
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9369#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9369
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9369
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9369
Reloadhttps://github.com/python/mypy/issues/9369
Reloadhttps://github.com/python/mypy/issues/9369
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9369
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9369
Variable loses type inference after passing through dictionary of known typehttps://github.com/python/mypy/issues/9369#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
https://github.com/GPHemsley
GPHemsleyhttps://github.com/GPHemsley
on Aug 28, 2020https://github.com/python/mypy/issues/9369#issue-687838617
#6755https://github.com/python/mypy/issues/6755
GPHemsleyhttps://github.com/GPHemsley
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Aug 28, 2020https://github.com/python/mypy/issues/9369#event-3702628301
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 28, 2020https://github.com/python/mypy/issues/9369#issuecomment-682693385
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Aug 28, 2020https://github.com/python/mypy/issues/9369#issuecomment-682770422
https://github.com/python/typeshed/blob/master/stdlib/3/typing.pyi#L428https://github.com/python/typeshed/blob/master/stdlib/3/typing.pyi#L428
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 28, 2020https://github.com/python/mypy/issues/9369#issuecomment-682896083
gvanrossumhttps://github.com/gvanrossum
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Aug 28, 2020https://github.com/python/mypy/issues/9369#event-3704844435
https://github.com/adigitoleo
adigitoleohttps://github.com/adigitoleo
on Nov 22, 2020https://github.com/python/mypy/issues/9369#issuecomment-731737426
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Nov 23, 2020https://github.com/python/mypy/issues/9369#issuecomment-731911423
@adigitoleohttps://github.com/adigitoleo
https://github.com/adigitoleo
adigitoleohttps://github.com/adigitoleo
on Nov 24, 2020https://github.com/python/mypy/issues/9369#issuecomment-732504222
@JelleZijlstrahttps://github.com/JelleZijlstra
https://github.com/GPHemsley
GPHemsleyhttps://github.com/GPHemsley
on Apr 2, 2022https://github.com/python/mypy/issues/9369#issuecomment-1086669711
#6755https://github.com/python/mypy/issues/6755
https://github.com/python/typeshed/blob/5f9fd3d1272728a07ba7cd6cfe298151fd10d8b9/stdlib/3/typing.pyi#L428-L431https://github.com/python/typeshed/blob/5f9fd3d1272728a07ba7cd6cfe298151fd10d8b9/stdlib/3/typing.pyi#L428-L431
https://github.com/python/typeshed/blob/d45c9084a4886bc477ee171e4ef8ed3117291f32/stdlib/typing.pyi#L929-L932https://github.com/python/typeshed/blob/d45c9084a4886bc477ee171e4ef8ed3117291f32/stdlib/typing.pyi#L929-L932
https://mypy-play.net/?mypy=master&python=3.10&flags=strict&gist=13ad6d8c4dded8cfd66298b862bbd8b8https://mypy-play.net/?mypy=master&python=3.10&flags=strict&gist=13ad6d8c4dded8cfd66298b862bbd8b8
https://mypy-play.net/?mypy=master&python=3.10&flags=strict&gist=61283a9b235cacda43ba7dcae44ea63ahttps://mypy-play.net/?mypy=master&python=3.10&flags=strict&gist=61283a9b235cacda43ba7dcae44ea63a
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 24, 2023https://github.com/python/mypy/issues/9369#issuecomment-1691284919
#14151https://github.com/python/mypy/pull/14151
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 24, 2023https://github.com/python/mypy/issues/9369#event-10178734027
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9369
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9369
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.