René's URL Explorer Experiment


Title: Possible false positive calling dict.update() method with TypedDict hierarchy · Issue #9335 · python/mypy · GitHub

Open Graph Title: Possible false positive calling dict.update() method with TypedDict hierarchy · Issue #9335 · python/mypy

X Title: Possible false positive calling dict.update() method with TypedDict hierarchy · Issue #9335 · python/mypy

Description: Python version: 3.8.2 mypy version: 0.782 mypy flags: --strict (same result without this flag) I've encountered what looks like a false positive when calling .update() on TypedDicts that have some required and some optional fields. I hav...

Open Graph Description: Python version: 3.8.2 mypy version: 0.782 mypy flags: --strict (same result without this flag) I've encountered what looks like a false positive when calling .update() on TypedDicts that have some ...

X Description: Python version: 3.8.2 mypy version: 0.782 mypy flags: --strict (same result without this flag) I've encountered what looks like a false positive when calling .update() on TypedDicts that have s...

Opengraph URL: https://github.com/python/mypy/issues/9335

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Possible false positive calling dict.update() method with TypedDict hierarchy","articleBody":"Python version: 3.8.2\r\nmypy version: 0.782\r\nmypy flags: --strict (same result without this flag)\r\n\r\nI've encountered what looks like a false positive when calling `.update()` on TypedDicts that have some required and some optional fields. I have a hierarchy of TypedDicts with some required fields in the base class and some optional fields in the derived class. Here is a minimal snippet that reproduces the error:\r\n```python3\r\nfrom typing import TypedDict\r\n\r\n\r\nclass Base(TypedDict):\r\n    id: int\r\n\r\n\r\nclass Derived(Base, total=False):\r\n    description: str\r\n\r\n\r\nupdate_me: Derived = {\r\n    'id': 1,\r\n    'description': 'norsetanrst'\r\n}\r\n\r\nnew_data: Derived = {\r\n    'id': 2\r\n}\r\n# \"incompatible type\" error from mypy\r\nupdate_me.update(new_data)\r\n```\r\n\r\nI expected this to type check with no errors. However, mypy emits the following about the last line:\r\n```\r\n$ mypy --strict\r\ndemo.py:21: error: Argument 1 to \"update\" of \"TypedDict\" has incompatible type \"Derived\"; expected \"TypedDict({'content'?: Dict[str, int], 'description'?: str})\"\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\nIt seems like mypy is expecting a TypedDict with the same fields (but all optional) as Derived. If I change the last line to `update_me.update(update_me)`, the same error occurs. If I add `total=False` to `Base`'s signature, the error goes away, but then I no longer have any required fields.\r\n\r\nAlso interesting to note: `reveal_type(update_me.update)` prints the signature I would expect:\r\n```\r\nnote: Revealed type is 'def (TypedDict('wee.Derived', {'id': builtins.int, 'description'?: builtins.str}))'\r\n```\r\nAnd if I inline the argument, i.e. `update_me.update({'id': 2})`, the error goes away. However, my use case is\r\nsuch that doing so is not a viable solution.\r\n\r\nThank you! Please let me know if there's anything I've missed.","author":{"url":"https://github.com/james-perretta","@type":"Person","name":"james-perretta"},"datePublished":"2020-08-21T20:44:15Z","url":"https://github.com/python/mypy/issues/9335"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:073d33fc-3152-0f9f-b115-66596c46c9c4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD4F6:3CF916:36ED87:4CE6E4:6B005E37
html-safe-nonce8ff530574b2feaf4dcaf9825e1816e40cdf4dd3a8b0981fb5eff870b937d3935
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEY2OjNDRjkxNjozNkVEODc6NENFNkU0OjZCMDA1RTM3IiwidmlzaXRvcl9pZCI6IjY1NDUwMTc1MjY0ODc2Mzc1NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac778c276f979ea102d65f1f39f7caed04ba7dd36fd9506a382b922ae1dc152010
hovercard-subject-tagissue:683818403
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9335/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b5492423768ec3df96e4ab835d47ff03db058b3fcb0daf3a89daf0e9b258a837/python/mypy/issues/9335
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b5492423768ec3df96e4ab835d47ff03db058b3fcb0daf3a89daf0e9b258a837/python/mypy/issues/9335
og:image:altPython version: 3.8.2 mypy version: 0.782 mypy flags: --strict (same result without this flag) I've encountered what looks like a false positive when calling .update() on TypedDicts that have some ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejames-perretta
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9335#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9335
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9335
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9335
Reloadhttps://github.com/python/mypy/issues/9335
Reloadhttps://github.com/python/mypy/issues/9335
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9335
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9335
Possible false positive calling dict.update() method with TypedDict hierarchyhttps://github.com/python/mypy/issues/9335#top
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com/james-perretta
james-perrettahttps://github.com/james-perretta
on Aug 21, 2020https://github.com/python/mypy/issues/9335#issue-683818403
gvanrossumhttps://github.com/gvanrossum
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
on Aug 21, 2020https://github.com/python/mypy/issues/9335#event-3681266988
https://github.com/13k
13khttps://github.com/13k
on Nov 24, 2020https://github.com/python/mypy/issues/9335#issuecomment-732533248
says this on inheritancehttps://www.python.org/dev/peps/pep-0589/#inheritance
https://github.com/yiyoascen
yiyoascenhttps://github.com/yiyoascen
on May 20, 2021https://github.com/python/mypy/issues/9335#issuecomment-845512805
AlexWaygoodhttps://github.com/AlexWaygood
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 3, 2022https://github.com/python/mypy/issues/9335#event-6542705441
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on May 3, 2022https://github.com/python/mypy/issues/9335#issuecomment-1116384066
#6462https://github.com/python/mypy/issues/6462
AlexWaygoodhttps://github.com/AlexWaygood
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 3, 2022https://github.com/python/mypy/issues/9335#event-6542715408
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9335
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9335
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.