René's URL Explorer Experiment


Title: Decorated function makes type-check fail if done inside of method from the class · Issue #9266 · python/mypy · GitHub

Open Graph Title: Decorated function makes type-check fail if done inside of method from the class · Issue #9266 · python/mypy

X Title: Decorated function makes type-check fail if done inside of method from the class · Issue #9266 · python/mypy

Description: I believe this is a bug (explanation below). I expected to be able to statically check a case by checking whether self matches a given protocol (with the check_implements below). This seems to work, but if the method is decorated (with t...

Open Graph Description: I believe this is a bug (explanation below). I expected to be able to statically check a case by checking whether self matches a given protocol (with the check_implements below). This seems to work...

X Description: I believe this is a bug (explanation below). I expected to be able to statically check a case by checking whether self matches a given protocol (with the check_implements below). This seems to work...

Opengraph URL: https://github.com/python/mypy/issues/9266

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Decorated function makes type-check fail if done inside of method from the class","articleBody":"I believe this is a bug (explanation below).\r\n\r\nI expected to be able to statically check a case by checking whether `self` matches a given protocol (with the `check_implements` below).\r\n\r\nThis seems to work, but if the method is decorated (with the `implements` as shown in the code below) it doesn't validate properly that a method return type is wrong.\r\n\r\ni.e.: in the code below I expected that the `_: IFoo = check_implements(self)` line gives an error because the protocol declaration expects a `bool` return, whereas the method implementation says it returns a `str`.\r\n\r\nI think this is a bug because the same type-check later on says that the implementation doesn't conform to the protocol if done outside of the class -- as `_: IFoo = check_implements(Foo())`, so, it does something on `__init__` and a different thing if out of the `__init__`. Besides, it works if the function is not decorated.\r\n\r\nNote: even if I do `_: IFoo = check_implements(Foo())` in the `__init__` it doesn't validate properly (so, it doesn't seem related to `self` -- and it works as expected if the function is not decorated).\r\n\r\n```\r\nfrom typing import TypeVar, Protocol, Any, Callable\r\nimport functools\r\n\r\nF = TypeVar('F', bound=Callable[..., Any])\r\n\r\ndef implements(method: Any) -> Callable[[F], F]:\r\n    \"\"\"\r\n    Meant to be used as\r\n\r\n    class B:\r\n        @implements(IExpectedProtocol.method)\r\n        def method(self):\r\n            pass\r\n\r\n    Useful for knowing whether a name still exists in the interface and document\r\n    what's being implemented.\r\n\r\n    In runtime validates that the name passed is the same name implemented.\r\n    \"\"\"\r\n    @functools.wraps(method)\r\n    def wrapper(func):\r\n        if func.__name__ != method.__name__:\r\n            msg = \"Wrong @implements: %r expected, but implementing %r.\"\r\n            msg = msg % (func.__name__, method.__name__)\r\n            raise AssertionError(msg)\r\n\r\n        return func\r\n\r\n    return wrapper\r\n\r\nT = TypeVar(\"T\")\r\n\r\ndef check_implements(x: T) -> T:\r\n    \"\"\"\r\n    This is to be used in the constructor of a class which is expected to\r\n    implement some protocol. It can be used as:\r\n\r\n    def __init__(self):\r\n        _: IExpectedProtocol = check_implements(self)\r\n\r\n    Mypy should complain if `self` is not implementing the IExpectedProtocol.\r\n    \"\"\"\r\n    return x\r\n\r\nclass IFoo(Protocol):\r\n\r\n    def some_method(self) -> bool:\r\n        pass\r\n\r\nclass Foo(object):\r\n\r\n    def __init__(self) -> None:  # give type\r\n        _: IFoo = check_implements(self)  # Issue: Mypy does not report error here\r\n\r\n    @implements(IFoo.some_method)  # Note: if this implements is removed it reports the error at the __init__!\r\n    def some_method(self) -> str:  # Note: return value does not match protocol!\r\n        pass\r\n\r\n_: IFoo = check_implements(Foo())  # Mypy properly reports error here (with or without the implements decorator).\r\n```","author":{"url":"https://github.com/fabioz","@type":"Person","name":"fabioz"},"datePublished":"2020-08-05T01:19:44Z","url":"https://github.com/python/mypy/issues/9266"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a76cd6b8-827d-b2a3-ff01-14c721eaae6c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDEAC:5314B:24F6ABB:30336B2:6AFFF858
html-safe-nonce0772d45ad73a717ab9f5b48736cc41cfdcafbb6d04be084dcff9d77780bd0e5f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUFDOjUzMTRCOjI0RjZBQkI6MzAzMzZCMjo2QUZGRjg1OCIsInZpc2l0b3JfaWQiOiIzNDE0ODc2NTI1NDQ1NTExMjU2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfadc36d80da06f0f5b72558654fa7d45ddf54cc8b1240e5978c2a99bb7b07112
hovercard-subject-tagissue:673181920
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9266/issue_layout
twitter:imagehttps://opengraph.githubassets.com/044d90fcc3cc820127e99bdc03b30b2c300d8446aed3fcc931e2adc7cc77ec12/python/mypy/issues/9266
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/044d90fcc3cc820127e99bdc03b30b2c300d8446aed3fcc931e2adc7cc77ec12/python/mypy/issues/9266
og:image:altI believe this is a bug (explanation below). I expected to be able to statically check a case by checking whether self matches a given protocol (with the check_implements below). This seems to work...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefabioz
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9266#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9266
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9266
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9266
Reloadhttps://github.com/python/mypy/issues/9266
Reloadhttps://github.com/python/mypy/issues/9266
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9266
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9266
#18943https://github.com/python/mypy/pull/18943
Decorated function makes type-check fail if done inside of method from the classhttps://github.com/python/mypy/issues/9266#top
#18943https://github.com/python/mypy/pull/18943
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issue-673181920
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-668924292
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669068259
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669252453
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669258603
@Akulihttps://github.com/Akuli
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669295108
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669311058
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669313715
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669318978
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669324783
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669327194
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669331947
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669344754
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669355291
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669356487
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669438151
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669459865
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669465389
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669469902
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669500208
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669501667
https://github.com/fabioz
fabiozhttps://github.com/fabioz
on Aug 5, 2020https://github.com/python/mypy/issues/9266#issuecomment-669505122
https://github.com/fabioz/pyvmmonitor-core/blob/master/pyvmmonitor_core/interface.py#L220https://github.com/fabioz/pyvmmonitor-core/blob/master/pyvmmonitor_core/interface.py#L220
AlexWaygoodhttps://github.com/AlexWaygood
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on Mar 28, 2022https://github.com/python/mypy/issues/9266#event-6316511936
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#18943https://github.com/python/mypy/pull/18943
on May 30, 2025https://github.com/python/mypy/issues/9266#event-17892000123
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
3957025https://github.com/python/mypy/commit/39570250e35151e387e6e1daf08b4f4e4262726e
on May 30, 2025https://github.com/python/mypy/issues/9266#event-17892000172
pullhttps://github.com/apps/pull
on May 30, 2025https://github.com/python/mypy/issues/9266#event-17892394487
Use checkmember.py to check protocol subtyping (python#18943)https://github.com/Dareh123/mypy/commit/39570250e35151e387e6e1daf08b4f4e4262726e
python#18943https://github.com/python/mypy/pull/18943
3957025https://github.com/Dareh123/mypy/commit/39570250e35151e387e6e1daf08b4f4e4262726e
cdce8phttps://github.com/cdce8p
on May 31, 2025https://github.com/python/mypy/issues/9266#event-17902197747
Use checkmember.py to check protocol subtyping (python#18943)https://github.com/cdce8p/mypy/commit/2b175b2cd6fa183fbd0c8320fbb4f96866857ebe
python#18943https://github.com/python/mypy/pull/18943
2b175b2https://github.com/cdce8p/mypy/commit/2b175b2cd6fa183fbd0c8320fbb4f96866857ebe
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9266
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9266
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.