René's URL Explorer Experiment


Title: Type fails to get "refined" on branch when `is None`-check happens in variable assignment · Issue #9229 · python/mypy · GitHub

Open Graph Title: Type fails to get "refined" on branch when `is None`-check happens in variable assignment · Issue #9229 · python/mypy

X Title: Type fails to get "refined" on branch when `is None`-check happens in variable assignment · Issue #9229 · python/mypy

Description: Are you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy: from typing import Optional def bar(var: str): pass def foo(var: Optional[str]=None): var_not_None = not (var is None) if...

Open Graph Description: Are you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy: from typing import Optional def bar(var: str): pass def foo(var: Optional[str]=No...

X Description: Are you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy: from typing import Optional def bar(var: str): pass def foo(var: Optional[str]=No...

Opengraph URL: https://github.com/python/mypy/issues/9229

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type fails to get \"refined\" on branch when `is None`-check happens in variable assignment","articleBody":"* Are you reporting a bug, or opening a feature request? **Bug**\r\n* Please insert below the code you are checking with mypy:\r\n\r\n```python\r\nfrom typing import Optional\r\n\r\ndef bar(var: str):\r\n    pass\r\n\r\ndef foo(var: Optional[str]=None):\r\n    var_not_None = not (var is None)\r\n    if var_not_None:\r\n        # var can only be a `str` at this point,\r\n        # but `mypy` complains that\r\n        # Argument 1 to \"bar\" has incompatible type \"Optional[str]\"; expected \"str\"\r\n        bar(var)\r\n\r\ndef foo2(var: Optional[str]=None):\r\n    if not(var is None):\r\n        # no complaints from mypy\r\n        bar(var)\r\n```\r\n\r\n* What is the actual behavior/output?\r\n\r\nRunning `mypy` on this reproducer returns:\r\n\r\n`error: Argument 1 to \"bar\" has incompatible type \"Optional[str]\"; expected \"str\"\r\nFound 1 error in 1 file (checked 1 source file)`\r\n\r\n* What is the behavior/output you expect?\r\n\r\nNo errors, both `foo2` and `foo` are equivalent.\r\n\r\n* What are the versions of mypy and Python you are using?\r\n\r\n`mypy 0.782` and `Python 3.6.8`\r\n\r\n* Do you see the same issue after installing mypy from Git master?\r\n\r\nYup, unless I did something wrong 😅 \r\n\r\n**Summary:**\r\n\r\nWhen you have an `Optional[str]`-typed variable `var`, one would expect that an `not (var is None)` check in an `if-statement` should tell `mypy` that all code within that branch has that the variable has type `str`. Indeed, `mypy` shows the expected behaviour for this, as shown in function `foo2` above.\r\n\r\nHowever, there are _many_ instances where you want to check if a variable is `None` outside of the if-statement. For instance, if your if-statement were to check many boolean conditions at once. In this situation, one may save the result of the check into a variable. This is the case in the `foo` function above, where `mypy` complains.\r\n\r\nI suspect this problem may not be solvable in the general case, but perhaps we can improve the status-quo nonetheless to catch this error.\r\n\r\nIf this is a beginner-friendly bug, I would love to help fix it! I've been meaning to get involved with the `mypy` project; just some guidance would do. Thanks!\r\n","author":{"url":"https://github.com/davidmrdavid","@type":"Person","name":"davidmrdavid"},"datePublished":"2020-07-29T02:55:58Z","url":"https://github.com/python/mypy/issues/9229"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f17b3420-149f-a26d-66d3-aeddf111094d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9028:251AC0:7474E2:9A5DCB:6B00382B
html-safe-nonce59297ed302fc6d0a095f4d2fb08e9c59d9c4070c76177fac4025af1722482637
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MDI4OjI1MUFDMDo3NDc0RTI6OUE1RENCOjZCMDAzODJCIiwidmlzaXRvcl9pZCI6Ijg1NzUyNzExNjIxMDY0OTEzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6b70652911c8478f619e26e2510cd2fe82d4b897a07c0404c3c4362ad76b8f76
hovercard-subject-tagissue:667508754
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/9229/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f1777b9d6c4f97b82789a24b2beef4c3ab6f4495449545bf87c3ff27d1ee95e3/python/mypy/issues/9229
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f1777b9d6c4f97b82789a24b2beef4c3ab6f4495449545bf87c3ff27d1ee95e3/python/mypy/issues/9229
og:image:altAre you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy: from typing import Optional def bar(var: str): pass def foo(var: Optional[str]=No...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedavidmrdavid
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/9229#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9229
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F9229
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/9229
Reloadhttps://github.com/python/mypy/issues/9229
Reloadhttps://github.com/python/mypy/issues/9229
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9229
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/9229
Type fails to get "refined" on branch when is None-check happens in variable assignmenthttps://github.com/python/mypy/issues/9229#top
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-pep-572PEP 572 (walrus operator)https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-pep-572%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/davidmrdavid
davidmrdavidhttps://github.com/davidmrdavid
on Jul 29, 2020https://github.com/python/mypy/issues/9229#issue-667508754
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Jul 29, 2020https://github.com/python/mypy/issues/9229#issuecomment-665560460
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jul 31, 2020https://github.com/python/mypy/issues/9229#issuecomment-667206583
JukkaLhttps://github.com/JukkaL
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Jul 31, 2020https://github.com/python/mypy/issues/9229#event-3609242718
https://github.com/Akuli
Akulihttps://github.com/Akuli
on Jul 31, 2020https://github.com/python/mypy/issues/9229#issuecomment-667215955
https://github.com/kprzybyla
kprzybylahttps://github.com/kprzybyla
on Aug 11, 2020https://github.com/python/mypy/issues/9229#issuecomment-671900010
@Akulihttps://github.com/Akuli
#9288https://github.com/python/mypy/pull/9288
hauntsaninjahttps://github.com/hauntsaninja
topic-pep-572PEP 572 (walrus operator)https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-pep-572%22
on Sep 25, 2020https://github.com/python/mypy/issues/9229#event-3809462544
AlexWaygoodhttps://github.com/AlexWaygood
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on Apr 1, 2022https://github.com/python/mypy/issues/9229#event-6354718509
JelleZijlstrahttps://github.com/JelleZijlstra
Mypy could not do condition inference #19029https://github.com/python/mypy/issues/19029
on May 5, 2025https://github.com/python/mypy/issues/9229#event-17522858140
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/9229
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/9229
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-pep-572PEP 572 (walrus operator)https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-pep-572%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.