Title: Plans for `mypy.myunit` · Issue #908 · python/mypy · GitHub
Open Graph Title: Plans for `mypy.myunit` · Issue #908 · python/mypy
X Title: Plans for `mypy.myunit` · Issue #908 · python/mypy
Description: Since driver is now merged, mypy.myunit is a package instead of a module; however all the logic is still in __init__.py and has irritating limitations. Note that in these plans I am not yet making myunit and the driver aware of each othe...
Open Graph Description: Since driver is now merged, mypy.myunit is a package instead of a module; however all the logic is still in __init__.py and has irritating limitations. Note that in these plans I am not yet making ...
X Description: Since driver is now merged, mypy.myunit is a package instead of a module; however all the logic is still in __init__.py and has irritating limitations. Note that in these plans I am not yet making ...
Opengraph URL: https://github.com/python/mypy/issues/908
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Plans for `mypy.myunit`","articleBody":"Since `driver` is now merged, `mypy.myunit` is a package instead of a module; however all the logic is still in `__init__.py` and has irritating limitations.\n\nNote that in these plans I am _not_ yet making myunit and the driver aware of each other, just laying out a framework.\n- Document which parts of `myunit` are actually used from elsewhere.\n- Remove the unnecessary use of `Any`.\n- Split \"collect tests\" logic from \"run tests\" logic, add `-l` to only collect and print.\n- Split \"collect results\" logic from \"print results\" logic.\n- Allow fetching a single test by name (see below) instead of collecting _everything_ and then filtering even when there are no wildcards.\n- Use `fnmatch` instead of hand-written glob functions (likely via regex conversion, so we can add a command-line option to take a regex directly).\n- Add tests for `myunit` itself.\n- Move assertions so you can do `from mypy.myunit.assertions import *`\n- Add decorators in `mypy.myunit.annotations`, see https://gist.github.com/o11c/ef8f0886d5967dfebc3d\n- Also add an decorator for \"this is an `assert_foo` function\" to replace the current traceback-cleaning logic, which is wrong if something goes wrong in the assert function itself.\n- Add a check that some `assert_foo` function is actually run for every testcase.\n- Record results of a test run to file so that diffs can be displayed from previous runs.\n- Move mutable globals to `mypy.myunit.ick`\n- Move main function and related logic to `mypy.myunit.main`\n- Allow free functions to be used as tests instead of requiring them to be wrapped in a class.\n- Support opting out of the tempdir logic.\n- Support fixtures by looking up `(name.strip('_'), annotated_type)` in current module and in `mypy.myunit.fixtures` (use this for tempdir maybe?)\n- Change data-driven testcases from overriding `cases` to overriding `init`, likely in a base class that takes care of calling `parse_tests`.\n- Support a \"keep going\" mode of assertion failure.\n\nAnyway, the big change is global test naming.\n\n---\n\nNew test names have more dots, and will look like `mypy.test.testlex.LexerSuite.test_empty`. It is not always as simple as `getattr` - modules need to be imported, classes need to be instantiated, data-driven cases need to be parsed, etc.\n\nThe first component name will _always_ be a module, and most likely always be just `'mypy'` depending on what is done about #724 \n\nI introduce two new classes, `TestFactory` and `Test`, to avoid refactoring the responsibilities of `Suite` and `TestCase`. There will be a bridge of course, or maybe the old classes will just be subclasses of the new ones. Possibly the old classes will go away entirely.\n\nAPI will look something like:\n\n```\nTestOrTestFactory = Union['Test', 'TestFactory']\n\nclass Test:\n name = ''\n # Basically just TestCase without all the cruft,\n # but also stores the annotations.\n # It is now forbidden to create your own subclasses, use fixtures instead.\n\nclass TestFactory:\n name = ''\n @abstractmethod\n def list_immediate_children(self) -> Iterable[str]: ...\n @abstractmethod\n def get_immediate_child(self, name: str) -> TestOrTestFactory: ...\n\n @staticmethod\n def list_recursive_children(name: str) -> Iterable[str]: ...\n @staticmethod\n def get_recursive_child(name: str) -> TestOrTestFactory: ...\n\nclass ModuleTestFactory(TestFactory):\n def __init__(self, module: types.ModuleType) -> None: ...\n # implementation uses `getattr`, `__path__`, and `__import__`\n # to find both contained modules (but not imported ones from elsewhere!)\n # and test objects (functions, classes, or instances) from the current module.\n\nclass SuiteTestFactory(TestFactory):\n def __init__(self, suite: Suite) -> None: ...\n # implementation uses `suite.cases()`, now restricted to only return `TestCase`s.\n # (The only remaining suite with suites as children is the temporary `ListSuite`).\n```\n\nBikeshed: what do we call the module in which `Suite`, `TestCase`, `TestFactory`, and `Test` reside? Same module or separate ones?\n","author":{"url":"https://github.com/o11c","@type":"Person","name":"o11c"},"datePublished":"2015-10-11T21:15:14Z","url":"https://github.com/python/mypy/issues/908"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:90d80ae3-da13-5f53-ac38-bd4f08c7f9ab |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 829C:302FC:E055CE:12BF19F:6B0054F2 |
| html-safe-nonce | 97735c83c665d739efd554b273040e1f6b53a8371992025ad9814369ac11893e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjlDOjMwMkZDOkUwNTVDRToxMkJGMTlGOjZCMDA1NEYyIiwidmlzaXRvcl9pZCI6IjYxNTk4NDAzMDY3MTcwMjE0MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1468acb86eab1da37d5931c4f8ea422ceb164c20ef95689fb6260a3de0b7efe7 |
| hovercard-subject-tag | issue:110883218 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/908/issue_layout |
| twitter:image | https://opengraph.githubassets.com/572da6dc42c8cdb240e472bfe2076655c67816f260e8b2585dff7a0e27861805/python/mypy/issues/908 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/572da6dc42c8cdb240e472bfe2076655c67816f260e8b2585dff7a0e27861805/python/mypy/issues/908 |
| og:image:alt | Since driver is now merged, mypy.myunit is a package instead of a module; however all the logic is still in __init__.py and has irritating limitations. Note that in these plans I am not yet making ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | o11c |
| hostname | github.com |
| expected-hostname | github.com |
| None | f420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26e00df917aba0f128135dc073ea0c5e33a70d40 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width