René's URL Explorer Experiment


Title: Should concrete implementations be required to implement protocol? · Issue #8926 · python/mypy · GitHub

Open Graph Title: Should concrete implementations be required to implement protocol? · Issue #8926 · python/mypy

X Title: Should concrete implementations be required to implement protocol? · Issue #8926 · python/mypy

Description: Are you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to simplify your case to a minimal repro. fro...

Open Graph Description: Are you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to si...

X Description: Are you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to si...

Opengraph URL: https://github.com/python/mypy/issues/8926

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Should concrete implementations be required to implement protocol?","articleBody":"* Are you reporting a bug, or opening a feature request?\r\n\r\nBug\r\n\r\n* Please insert below the code you are checking with mypy,\r\n  or a mock-up repro if the source is private. We would appreciate\r\n  if you try to simplify your case to a minimal repro.\r\n\r\n```python\r\n\r\nfrom typing import Protocol\r\n\r\n\r\nclass Person(Protocol):\r\n    first_name: str\r\n\r\n    def greeting(self, message: str) -> str:\r\n        ...\r\n\r\n\r\nclass FrenchPerson(Person):\r\n    prenom: str\r\n\r\n    def __init__(self, name: str):\r\n        self.prenom = name\r\n\r\n    def salutation(self, message: str) -> str:\r\n        return f\"{message} {self.prenom}\"\r\n\r\n\r\ndef print_person(person: Person) -> str:\r\n    return person.greeting(message=\"Je m'appelle\")\r\n\r\n\r\ndef main():\r\n    fp = FrenchPerson(name='Henri')\r\n    response = print_person(fp)\r\n    print(response)\r\n```\r\n\r\n* What is the actual behavior/output?\r\n\r\nPEP 544 says you can state that an implementation supports a protocol by\r\n[subclassing the protocol](https://www.python.org/dev/peps/pep-0544/#explicitly-declaring-implementation).\r\n\r\nIt also says: \"If one omits Protocol in the base class list, this would\r\nbe a regular (non-protocol) class that must implement Sized.\"\r\n\r\n* What is the behavior/output you expect?\r\n\r\nI would hope `mypy` would, either at declaration time or in the `print_person` function, spot that something claimed to be a `Person` but had neither the protocol variable `name` nor the method `greeting`.\r\n\r\nIt's also a shame that `FrenchPerson` got the `greeting` method added to it from the subclassing.\r\n\r\n* What are the versions of mypy and Python you are using?\r\n\r\n`mypy` 0.770 and Python 3.8.1\r\n\r\n* What are the mypy flags you are using? (For example --strict-optional)\r\n\r\nNone.\r\n","author":{"url":"https://github.com/pauleveritt","@type":"Person","name":"pauleveritt"},"datePublished":"2020-05-31T12:04:13Z","url":"https://github.com/python/mypy/issues/8926"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:18d94698-4ae9-0683-4b33-423e13964591
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC38A:22BD05:23E7B39:30BBB24:6B002FCF
html-safe-nonce3fbf411d6558bd4934a3a0400fb506a3745b73c3da5e8e873a2170c82a533b0f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzhBOjIyQkQwNToyM0U3QjM5OjMwQkJCMjQ6NkIwMDJGQ0YiLCJ2aXNpdG9yX2lkIjoiNjQ0NTY2NjgwMjU1ODA1NDM1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8bd66384b189bf69c1cc50423ee6fb5fcffa6f29932b502dcbb02832313b8d8a
hovercard-subject-tagissue:627949531
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/8926/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a578ab92b7f9d8baeaa9a85d13352b9fdcc8e59c0983980c3a110bb7334098ff/python/mypy/issues/8926
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a578ab92b7f9d8baeaa9a85d13352b9fdcc8e59c0983980c3a110bb7334098ff/python/mypy/issues/8926
og:image:altAre you reporting a bug, or opening a feature request? Bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to si...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepauleveritt
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/8926#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8926
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8926
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/8926
Reloadhttps://github.com/python/mypy/issues/8926
Reloadhttps://github.com/python/mypy/issues/8926
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8926
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8926
#12118https://github.com/python/mypy/pull/12118
Should concrete implementations be required to implement protocol?https://github.com/python/mypy/issues/8926#top
#12118https://github.com/python/mypy/pull/12118
https://github.com/JukkaL
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-protocolshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-protocols%22
https://github.com/pauleveritt
pauleveritthttps://github.com/pauleveritt
on May 31, 2020https://github.com/python/mypy/issues/8926#issue-627949531
subclassing the protocolhttps://www.python.org/dev/peps/pep-0544/#explicitly-declaring-implementation
https://github.com/louwers
louwershttps://github.com/louwers
on Jun 5, 2020https://github.com/python/mypy/issues/8926#issuecomment-639413669
JukkaLhttps://github.com/JukkaL
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
on Jun 8, 2020https://github.com/python/mypy/issues/8926#event-3420861634
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jun 8, 2020https://github.com/python/mypy/issues/8926#issuecomment-640726605
@ilevkivskyihttps://github.com/ilevkivskyi
JukkaLhttps://github.com/JukkaL
on Jul 3, 2020https://github.com/python/mypy/issues/8926#event-3510766306
https://github.com/nickgaya
nickgayahttps://github.com/nickgaya
on Nov 30, 2020https://github.com/python/mypy/issues/8926#issuecomment-736073446
https://github.com/pauleveritt
pauleveritthttps://github.com/pauleveritt
on Dec 1, 2020https://github.com/python/mypy/issues/8926#issuecomment-736156137
https://github.com/nickgaya
nickgayahttps://github.com/nickgaya
on Dec 1, 2020https://github.com/python/mypy/issues/8926#issuecomment-736377588
https://github.com/ktbarrett
ktbarretthttps://github.com/ktbarrett
on Jun 15, 2021https://github.com/python/mypy/issues/8926#issuecomment-861131810
https://github.com/nickgaya
nickgayahttps://github.com/nickgaya
on Jun 15, 2021https://github.com/python/mypy/issues/8926#issuecomment-861663222
@ktbarretthttps://github.com/ktbarrett
#9772https://github.com/python/mypy/issues/9772
https://github.com/ktbarrett
ktbarretthttps://github.com/ktbarrett
on Jun 15, 2021https://github.com/python/mypy/issues/8926#issuecomment-861727106
https://github.com/tmke8
tmke8https://github.com/tmke8
on Feb 3, 2022https://github.com/python/mypy/issues/8926#issuecomment-1029025071
#8005https://github.com/python/mypy/issues/8005
#8395https://github.com/python/mypy/issues/8395
tmke8https://github.com/tmke8
on Feb 3, 2022https://github.com/python/mypy/issues/8926#event-6004097010
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/2f9d921fa3d756c268065f03b591272032637ded
https://docs.github.com/articles/closing-issues-via-commit-messages
2f9d921https://github.com/tmke8/mypy/commit/2f9d921fa3d756c268065f03b591272032637ded
https://github.com/ktbarrett
ktbarretthttps://github.com/ktbarrett
on Feb 4, 2022https://github.com/python/mypy/issues/8926#issuecomment-1029995137
The relevant part of PEP544https://www.python.org/dev/peps/pep-0544/#explicitly-declaring-implementation
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on Feb 4, 2022https://github.com/python/mypy/issues/8926#issuecomment-1030196832
https://user-images.githubusercontent.com/7040122/152572695-76627dc2-ec60-446d-9666-586c27dc736f.png
https://github.com/ktbarrett
ktbarretthttps://github.com/ktbarrett
on Feb 4, 2022https://github.com/python/mypy/issues/8926#issuecomment-1030284263
tmke8https://github.com/tmke8
on Feb 10, 2022https://github.com/python/mypy/issues/8926#event-6042422755
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/bf2a40d4546c835181185ef917800193b7e282ad
https://docs.github.com/articles/closing-issues-via-commit-messages
bf2a40dhttps://github.com/tmke8/mypy/commit/bf2a40d4546c835181185ef917800193b7e282ad
tmke8https://github.com/tmke8
on Feb 23, 2022https://github.com/python/mypy/issues/8926#event-6124725894
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/985f464e569a7d0af905f3e6e14469d3f13f039b
https://docs.github.com/articles/closing-issues-via-commit-messages
985f464https://github.com/tmke8/mypy/commit/985f464e569a7d0af905f3e6e14469d3f13f039b
JelleZijlstrahttps://github.com/JelleZijlstra
topic-protocolshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-protocols%22
on Mar 19, 2022https://github.com/python/mypy/issues/8926#event-6270240515
tmke8https://github.com/tmke8
on Jul 29, 2022https://github.com/python/mypy/issues/8926#event-7088892073
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/af4e8fd24d65c1cca82b4c647a4a367409ff6fe6
https://docs.github.com/articles/closing-issues-via-commit-messages
af4e8fdhttps://github.com/tmke8/mypy/commit/af4e8fd24d65c1cca82b4c647a4a367409ff6fe6
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#12118https://github.com/python/mypy/pull/12118
on Aug 2, 2022https://github.com/python/mypy/issues/8926#event-7112411523
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/8926
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/8926
JukkaLhttps://github.com/JukkaL
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-protocolshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-protocols%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.