René's URL Explorer Experiment


Title: Cannot return concrete type within `isinstance` block of generic function · Issue #8354 · python/mypy · GitHub

Open Graph Title: Cannot return concrete type within `isinstance` block of generic function · Issue #8354 · python/mypy

X Title: Cannot return concrete type within `isinstance` block of generic function · Issue #8354 · python/mypy

Description: I'm not sure if this is a bug or a known limitation. I think this is different to the other similar generics vs isinstance issues, but please do point me at another if this is a duplicate. Given some function: from typing import TypeVar ...

Open Graph Description: I'm not sure if this is a bug or a known limitation. I think this is different to the other similar generics vs isinstance issues, but please do point me at another if this is a duplicate. Given so...

X Description: I'm not sure if this is a bug or a known limitation. I think this is different to the other similar generics vs isinstance issues, but please do point me at another if this is a duplicate. Give...

Opengraph URL: https://github.com/python/mypy/issues/8354

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Cannot return concrete type within `isinstance` block of generic function","articleBody":"I'm not sure if this is a bug or a known limitation. I think this is different to the other similar generics vs `isinstance` issues, but please do point me at another if this is a duplicate.\r\n\r\nGiven some function:\r\n``` python\r\nfrom typing import TypeVar\r\n\r\nT = TypeVar('T')\r\n\r\ndef foo(val: T) -> T:\r\n    if isinstance(val, str):\r\n        return \"abc\"\r\n    return val\r\n```\r\n\r\nI would hope that `mypy` can tell that, within the `isinstance` block, `T` can only be `str` (since that's what `val` is) and thus returning something which is explicitly `str` is fine.\r\n\r\nUnfortunately this case seems to error:\r\n```\r\nfoo.py:5: error: Incompatible return value type (got \"str\", expected \"T\")\r\n```\r\n\r\nI realise this construct looks a bit odd in the cut-down above -- my actual use-case involves walking nested list and dictionary structures to modify values, but ends up with what I believe is the same error. Just to give a sense of that a slightly larger but still very cut-down version would be:\r\n\r\n``` python\r\nfrom typing import Any, List, TypeVar, Union\r\n\r\nT = TypeVar('T', bound=Union[str, List[Any], int])\r\n\r\ndef do_expansion(value: T) -> T:\r\n    if isinstance(value, str):\r\n        return value.upper()  # just using .upper() as an example\r\n    elif isinstance(value, list):\r\n        return [do_expansion(x) for x in value]\r\n    else:\r\n        return value\r\n```\r\n\r\nI realise I could use overloads to achieve a similar effect for consumers of the function, however I would also like to be able to type the implementation and get checking there.\r\n\r\nIn case it's useful, I'm using `mypy` version `0.761` (latest at the time of writing) on Python 3.5.2.","author":{"url":"https://github.com/PeterJCLaw","@type":"Person","name":"PeterJCLaw"},"datePublished":"2020-02-02T01:20:39Z","url":"https://github.com/python/mypy/issues/8354"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:948a8160-ad01-9b9d-bfe0-72a68083a905
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8822:2DCAE8:2407F6F:3123906:6B003450
html-safe-nonced77e63f77f216ef76b756b6272db789f74686e0269b992d428674581a995c74d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODIyOjJEQ0FFODoyNDA3RjZGOjMxMjM5MDY6NkIwMDM0NTAiLCJ2aXNpdG9yX2lkIjoiNTYyMjIwMTg2MjU4NjM4MTM5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac73c71a32c3e211e4f20f3ddd081d2454b08332189f8c03eb389deb0df08320f3
hovercard-subject-tagissue:558625163
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/8354/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d9231692d89dbc27404a00e735510fe4c86b945d6ca7bab2b416abc7fed7c355/python/mypy/issues/8354
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d9231692d89dbc27404a00e735510fe4c86b945d6ca7bab2b416abc7fed7c355/python/mypy/issues/8354
og:image:altI'm not sure if this is a bug or a known limitation. I think this is different to the other similar generics vs isinstance issues, but please do point me at another if this is a duplicate. Given so...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamePeterJCLaw
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/8354#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8354
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8354
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/8354
Reloadhttps://github.com/python/mypy/issues/8354
Reloadhttps://github.com/python/mypy/issues/8354
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8354
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8354
Cannot return concrete type within isinstance block of generic functionhttps://github.com/python/mypy/issues/8354#top
https://github.com/PeterJCLaw
PeterJCLawhttps://github.com/PeterJCLaw
on Feb 2, 2020https://github.com/python/mypy/issues/8354#issue-558625163
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Feb 2, 2020https://github.com/python/mypy/issues/8354#issuecomment-581111659
https://github.com/PeterJCLaw
PeterJCLawhttps://github.com/PeterJCLaw
on Feb 2, 2020https://github.com/python/mypy/issues/8354#issuecomment-581146583
functools.singledispatchhttps://docs.python.org/3/library/functools.html#functools.singledispatch
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Feb 2, 2020https://github.com/python/mypy/issues/8354#issuecomment-581177827
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Feb 4, 2020https://github.com/python/mypy/issues/8354#issuecomment-581939848
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 4, 2020https://github.com/python/mypy/issues/8354#event-3006343036
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/8354
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/8354
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.