Title: Conditional import via try-except renders error for imported type · Issue #8319 · python/mypy · GitHub
Open Graph Title: Conditional import via try-except renders error for imported type · Issue #8319 · python/mypy
X Title: Conditional import via try-except renders error for imported type · Issue #8319 · python/mypy
Description: I'm running python 3.5 (mypy 0.761). TypedDict is not in typing so I have typing_extensions installed (for python < 3.8). However, the library I'm building supports python up to 3.8, which has TypedDict built-in so I might as well use th...
Open Graph Description: I'm running python 3.5 (mypy 0.761). TypedDict is not in typing so I have typing_extensions installed (for python < 3.8). However, the library I'm building supports python up to 3.8, which has Type...
X Description: I'm running python 3.5 (mypy 0.761). TypedDict is not in typing so I have typing_extensions installed (for python < 3.8). However, the library I'm building supports python up to 3.8, whi...
Opengraph URL: https://github.com/python/mypy/issues/8319
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Conditional import via try-except renders error for imported type","articleBody":"I'm running python 3.5 (mypy `0.761`). `TypedDict` is not in `typing` so I have `typing_extensions` installed (for python \u003c 3.8).\r\n\r\nHowever, the library I'm building supports python up to 3.8, which has `TypedDict` built-in so I might as well use that.\r\n\r\nSo I tried conditional import:\r\n\r\n```python\r\ntry:\r\n from typing import TypedDict # type: ignore\r\nexcept ImportError:\r\n from typing_extensions import TypedDict\r\n\r\nFoo = TypedDict('Foo', {\r\n 'id': str,\r\n})\r\n\r\ndef whatever(data: Foo) -> None:\r\n pass\r\n```\r\n\r\nResults in:\r\n\r\n```\r\ntypetest.py:12: error: Variable \"typetest.Foo\" is not valid as a type\r\n```\r\n\r\nAdjusting the import as so makes the problem go away:\r\n\r\n```python\r\nimport sys\r\nif sys.version_info >= (3, 8):\r\n from typing import TypedDict\r\nelse:\r\n from typing_extensions import TypedDict\r\n```\r\n\r\nhttps://mypy.readthedocs.io/en/stable/common_issues.html#python-version-and-system-platform-checks doesn't at least directly suggest to use this style for imports, though. What is the proper/preferred way to do conditional imports?","author":{"url":"https://github.com/mtvx","@type":"Person","name":"mtvx"},"datePublished":"2020-01-23T12:44:46Z","url":"https://github.com/python/mypy/issues/8319"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:ca596c4f-024b-70b2-a34b-cdf6495bd83e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D96E:1DA187:28D973F:35768DD:6B0005FC |
| html-safe-nonce | ed8043cfd7df15752c00943fe5a7adab7fce6990e518f6059dfe05e377589b52 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTZFOjFEQTE4NzoyOEQ5NzNGOjM1NzY4REQ6NkIwMDA1RkMiLCJ2aXNpdG9yX2lkIjoiMzQ2NjE0ODI4MTY1NzA2NzAwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9b1552dd481e3e8e4cfe17540ca06aadc7aafae5ab765de8cd4e6faf11586141 |
| hovercard-subject-tag | issue:554134720 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/8319/issue_layout |
| twitter:image | https://opengraph.githubassets.com/d589aa92600be8f874addda9248cf9bcabf154e99d01c0c9ed1f6835b809746c/python/mypy/issues/8319 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d589aa92600be8f874addda9248cf9bcabf154e99d01c0c9ed1f6835b809746c/python/mypy/issues/8319 |
| og:image:alt | I'm running python 3.5 (mypy 0.761). TypedDict is not in typing so I have typing_extensions installed (for python < 3.8). However, the library I'm building supports python up to 3.8, which has Type... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mtvx |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width