René's URL Explorer Experiment


Title: Incorrent "Missing return statement" in presence of bad combination of decorated function call, definition order and NoReturn · Issue #8129 · python/mypy · GitHub

Open Graph Title: Incorrent "Missing return statement" in presence of bad combination of decorated function call, definition order and NoReturn · Issue #8129 · python/mypy

X Title: Incorrent "Missing return statement" in presence of bad combination of decorated function call, definition order and NoReturn · Issue #8129 · python/mypy

Description: Code to reproduce: from typing import Callable, NoReturn, TypeVar def no_return() -> NoReturn: pass def use_decorated_before_defined() -> int: decorated() if bool(): return 0 else: no_return() T = TypeVar('T') def wrapper(function: T) ->...

Open Graph Description: Code to reproduce: from typing import Callable, NoReturn, TypeVar def no_return() -> NoReturn: pass def use_decorated_before_defined() -> int: decorated() if bool(): return 0 else: no_return() T = ...

X Description: Code to reproduce: from typing import Callable, NoReturn, TypeVar def no_return() -> NoReturn: pass def use_decorated_before_defined() -> int: decorated() if bool(): return 0 else: no_return(...

Opengraph URL: https://github.com/python/mypy/issues/8129

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrent \"Missing return statement\" in presence of bad combination of decorated function call, definition order and NoReturn","articleBody":"Code to reproduce:\r\n\r\n```python\r\nfrom typing import Callable, NoReturn, TypeVar\r\n\r\n\r\ndef no_return() -> NoReturn:\r\n    pass\r\n\r\n\r\ndef use_decorated_before_defined() -> int:\r\n    decorated()\r\n    if bool():\r\n        return 0\r\n    else:\r\n        no_return()\r\n\r\n\r\nT = TypeVar('T')\r\n\r\n\r\ndef wrapper(function: T) -> T:\r\n    return function\r\n\r\n\r\ndef decorator() -> Callable[[T], T]:\r\n    return wrapper\r\n\r\n\r\n@decorator()\r\ndef decorated() -> None: pass\r\n\r\n\r\ndef use_decorated_after_defined() -> int:\r\n    decorated()\r\n    if bool():\r\n        return 0\r\n    else:\r\n        no_return()\r\n\r\n\r\ndef use_wrapped_before_defined() -> int:\r\n    wrapped()\r\n    if bool():\r\n        return 0\r\n    else:\r\n        no_return()\r\n\r\n\r\n@wrapper\r\ndef wrapped() -> None: pass\r\n```\r\n\r\nI tested this both with mypy 0.750 and one from the current master branch (526a2187bbd2da35862899e7529394a74a6f6ced), running on CPython 3.7.5. The command line and the output:\r\n\r\n```\r\n% python -m mypy repro.py\r\nrepro.py:8: error: Missing return statement\r\nFound 1 error in 1 file (checked 1 source file)\r\n```\r\n\r\nI'd expect no errors here. After some digging in mypy source code I believe `use_decorated_before_defined` can't be fully processed when it's type-checked (at least the first time it's entered) because of a) the call to `decorated` being looked at before `decorated` is defined and b) `decorated` being decorated (pardon my repetition) with a result of another function call which I suspect creates a difficult environment for mypy to deduce things and it defers further processing of `use_decorated_before_defined` (or at least part of it).\r\n\r\nThen, when the call to `no_return` is encountered its type is detected as `Any` because of the processing being deferred per above, hence the error.\r\n\r\nI left two similar variants of the function (`use_decorated_after_defined` and `use_wrapped_before_defined`) to help narrow things down as those don't trigger the error.","author":{"url":"https://github.com/jstasiak","@type":"Person","name":"jstasiak"},"datePublished":"2019-12-10T21:44:31Z","url":"https://github.com/python/mypy/issues/8129"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6f9c10de-fd0e-0a01-635b-d57f817a756e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA758:18020:22B4ED:2ECB1F:6B0022CB
html-safe-noncee4081820dca89bc15f6c61ae42c5b0ff7a380d5614aac143365b8c5843223315
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzU4OjE4MDIwOjIyQjRFRDoyRUNCMUY6NkIwMDIyQ0IiLCJ2aXNpdG9yX2lkIjoiNzU4NjgyMzc4NjE1MDc2NTI2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2fcb26c92b4bd91400d1342937f0207bd3c87fc25ca0f4f50d4ef650ab29c474
hovercard-subject-tagissue:536011841
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/8129/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b65bd4ebbd214126db9435e1617fff9b11089a9cb7ac59143deddec51977231b/python/mypy/issues/8129
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b65bd4ebbd214126db9435e1617fff9b11089a9cb7ac59143deddec51977231b/python/mypy/issues/8129
og:image:altCode to reproduce: from typing import Callable, NoReturn, TypeVar def no_return() -> NoReturn: pass def use_decorated_before_defined() -> int: decorated() if bool(): return 0 else: no_return() T = ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejstasiak
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/8129#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8129
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8129
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/8129
Reloadhttps://github.com/python/mypy/issues/8129
Reloadhttps://github.com/python/mypy/issues/8129
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8129
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8129
#13575https://github.com/python/mypy/pull/13575
Incorrent "Missing return statement" in presence of bad combination of decorated function call, definition order and NoReturnhttps://github.com/python/mypy/issues/8129#top
#13575https://github.com/python/mypy/pull/13575
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com/jstasiak
jstasiakhttps://github.com/jstasiak
on Dec 10, 2019https://github.com/python/mypy/issues/8129#issue-536011841
526a218https://github.com/python/mypy/commit/526a2187bbd2da35862899e7529394a74a6f6ced
https://github.com/msullivan
msullivanhttps://github.com/msullivan
on Dec 12, 2019https://github.com/python/mypy/issues/8129#issuecomment-564808616
msullivanhttps://github.com/msullivan
on Dec 14, 2019https://github.com/python/mypy/issues/8129#event-2883084791
ilevkivskyihttps://github.com/ilevkivskyi
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Feb 17, 2020https://github.com/python/mypy/issues/8129#event-3043195525
msullivanhttps://github.com/msullivan
on Jun 18, 2020https://github.com/python/mypy/issues/8129#event-3456625220
https://github.com/LEdoian
LEdoianhttps://github.com/LEdoian
on Aug 12, 2022https://github.com/python/mypy/issues/8129#issuecomment-1212692269
#8401https://github.com/python/mypy/issues/8401
#8401https://github.com/python/mypy/issues/8401
Michael0x2ahttps://github.com/Michael0x2a
on Sep 1, 2022https://github.com/python/mypy/issues/8129#event-7301599343
Fix spurious unreachable and disallow-any errors from deferred passeshttps://github.com/Michael0x2a/mypy/commit/19c3869d368c83f817f49c52582cde4834a2b8b2
https://docs.github.com/articles/closing-issues-via-commit-messages
19c3869https://github.com/Michael0x2a/mypy/commit/19c3869d368c83f817f49c52582cde4834a2b8b2
Fix spurious unreachable and disallow-any errors from deferred passeshttps://github.com/Michael0x2a/mypy/commit/3eb30a87931a0bdd00943b43319a26317f57fb80
https://docs.github.com/articles/closing-issues-via-commit-messages
3eb30a8https://github.com/Michael0x2a/mypy/commit/3eb30a87931a0bdd00943b43319a26317f57fb80
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#13575https://github.com/python/mypy/pull/13575
on Sep 2, 2022https://github.com/python/mypy/issues/8129#event-7316231896
hauntsaninjahttps://github.com/hauntsaninja
on Sep 2, 2022https://github.com/python/mypy/issues/8129#event-7316231930
Fix spurious unreachable and disallow-any errors from deferred passes (…https://github.com/python/mypy/commit/0a8d425420ae958da4f11539a648707e9025b737
…https://github.com/python/mypy/pull/13575
https://docs.github.com/articles/closing-issues-via-commit-messages
0a8d425https://github.com/python/mypy/commit/0a8d425420ae958da4f11539a648707e9025b737
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/8129
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/8129
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.