René's URL Explorer Experiment


Title: Extending a Protocol leads to unsafe behavior · Issue #8005 · python/mypy · GitHub

Open Graph Title: Extending a Protocol leads to unsafe behavior · Issue #8005 · python/mypy

X Title: Extending a Protocol leads to unsafe behavior · Issue #8005 · python/mypy

Description: Are you reporting a bug, or opening a feature request? bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to simplify your case to a minimal repro. fro...

Open Graph Description: Are you reporting a bug, or opening a feature request? bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to si...

X Description: Are you reporting a bug, or opening a feature request? bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to si...

Opengraph URL: https://github.com/python/mypy/issues/8005

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Extending a Protocol leads to unsafe behavior","articleBody":"* Are you reporting a bug, or opening a feature request?\r\nbug\r\n\r\n* Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to simplify your case to a minimal repro.\r\n```\r\nfrom typing import Protocol\r\n\r\nclass P(Protocol):\r\n    def foo(self) -> int: ...\r\n\r\nclass A(P):  # mypy does not flag this\r\n    pass\r\n\r\nclass B:\r\n    pass\r\n\r\ntest: P = A()  # mypy does not flag this\r\ntest = B()  # mypy flags this\r\n\r\nprint(A().foo() + 5)  # both error at runtime\r\nprint(B().foo() + 5)\r\n```\r\n\r\n* What is the actual behavior/output?\r\n`A().foo() + 5` crashes at runtime with `TypeError: unsupported operand type(s) for +: 'NoneType' and 'int'`\r\n`B` is correctly type checked and rejected.\r\n\r\n* What is the behavior/output you expect?\r\nAccording to https://mypy.readthedocs.io/en/latest/protocols.html#defining-subprotocols-and-subclassing-protocols, \"Explicitly including a protocol as a base class ... forces mypy to verify that your class implementation is actually compatible with the protocol.\"\r\nI would expect extending a Protocol to be similar to implementing an interface in Java.\r\nIn this particular example, mypy should ideally detect that `A` does not fill in the stub method from `P`, like it does for `B`. Alternatively, if that is not possible, perhaps extending a protocol should not be allowed.\r\n\r\n* What are the versions of mypy and Python you are using? Do you see the same issue after installing mypy from Git master?\r\nPython 3.8.0\r\nmypy 0.750+dev.d9dea5f3ad30bb449e4167b3e8476684ded0482e\r\n\r\n* What are the mypy flags you are using? (For example --strict-optional)\r\n`mypy --strict test.py`","author":{"url":"https://github.com/jingw","@type":"Person","name":"jingw"},"datePublished":"2019-11-23T02:12:25Z","url":"https://github.com/python/mypy/issues/8005"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:cb22039a-314d-ec6e-029f-ecaaaba968fd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD41E:2A087:4B1770:648C5A:6B002F29
html-safe-noncec7c72e2435ce075f38a4f1a2a7cd4352b28661a9db399cccb275a16cb7e99f3e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDFFOjJBMDg3OjRCMTc3MDo2NDhDNUE6NkIwMDJGMjkiLCJ2aXNpdG9yX2lkIjoiNjQ2NTEzMDg5ODU1ODgyNDIzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3ca50f319e8b35ecd1eac6686c473973debd6846a361de2edea09127e9600a49
hovercard-subject-tagissue:527495312
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/8005/issue_layout
twitter:imagehttps://opengraph.githubassets.com/71b1306e739b321e388e7b43d186ed5a478378ee49c60b2e23bf5211cd7bb6c8/python/mypy/issues/8005
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/71b1306e739b321e388e7b43d186ed5a478378ee49c60b2e23bf5211cd7bb6c8/python/mypy/issues/8005
og:image:altAre you reporting a bug, or opening a feature request? bug Please insert below the code you are checking with mypy, or a mock-up repro if the source is private. We would appreciate if you try to si...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejingw
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/8005#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8005
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F8005
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/8005
Reloadhttps://github.com/python/mypy/issues/8005
Reloadhttps://github.com/python/mypy/issues/8005
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8005
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/8005
#12118https://github.com/python/mypy/pull/12118
Extending a Protocol leads to unsafe behaviorhttps://github.com/python/mypy/issues/8005#top
#12118https://github.com/python/mypy/pull/12118
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-protocolshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-protocols%22
https://github.com/jingw
jingwhttps://github.com/jingw
on Nov 23, 2019https://github.com/python/mypy/issues/8005#issue-527495312
https://mypy.readthedocs.io/en/latest/protocols.html#defining-subprotocols-and-subclassing-protocolshttps://mypy.readthedocs.io/en/latest/protocols.html#defining-subprotocols-and-subclassing-protocols
JelleZijlstrahttps://github.com/JelleZijlstra
topic-protocolshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-protocols%22
on Nov 23, 2019https://github.com/python/mypy/issues/8005#event-2825108031
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 25, 2019https://github.com/python/mypy/issues/8005#issuecomment-558341465
#2350https://github.com/python/mypy/issues/2350
ilevkivskyihttps://github.com/ilevkivskyi
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Nov 25, 2019https://github.com/python/mypy/issues/8005#event-2829638967
https://github.com/tmke8
tmke8https://github.com/tmke8
on Jan 23, 2022https://github.com/python/mypy/issues/8005#issuecomment-1019562293
1.1.213https://github.com/microsoft/pyright/releases/tag/1.1.213
microsoft/pyright@44c98fehttps://github.com/microsoft/pyright/commit/44c98fe74734e692683b9b71ae743c82f2072154
tmke8https://github.com/tmke8
on Jan 24, 2022https://github.com/python/mypy/issues/8005#event-5945373290
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/22ca0110e8f87873674c770040aca0f9d4993722
22ca011https://github.com/tmke8/mypy/commit/22ca0110e8f87873674c770040aca0f9d4993722
tmke8https://github.com/tmke8
on Feb 3, 2022https://github.com/python/mypy/issues/8005#event-6004097004
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/2f9d921fa3d756c268065f03b591272032637ded
https://docs.github.com/articles/closing-issues-via-commit-messages
2f9d921https://github.com/tmke8/mypy/commit/2f9d921fa3d756c268065f03b591272032637ded
https://github.com/nickgaya
nickgayahttps://github.com/nickgaya
on Feb 4, 2022https://github.com/python/mypy/issues/8005#issuecomment-1029608868
tmke8https://github.com/tmke8
on Feb 10, 2022https://github.com/python/mypy/issues/8005#event-6042422747
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/bf2a40d4546c835181185ef917800193b7e282ad
https://docs.github.com/articles/closing-issues-via-commit-messages
bf2a40dhttps://github.com/tmke8/mypy/commit/bf2a40d4546c835181185ef917800193b7e282ad
tmke8https://github.com/tmke8
on Feb 23, 2022https://github.com/python/mypy/issues/8005#event-6124725889
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/985f464e569a7d0af905f3e6e14469d3f13f039b
https://docs.github.com/articles/closing-issues-via-commit-messages
985f464https://github.com/tmke8/mypy/commit/985f464e569a7d0af905f3e6e14469d3f13f039b
tmke8https://github.com/tmke8
on Jul 29, 2022https://github.com/python/mypy/issues/8005#event-7088892067
Treat methods with empty bodies in Protocols as abstracthttps://github.com/tmke8/mypy/commit/af4e8fd24d65c1cca82b4c647a4a367409ff6fe6
https://docs.github.com/articles/closing-issues-via-commit-messages
af4e8fdhttps://github.com/tmke8/mypy/commit/af4e8fd24d65c1cca82b4c647a4a367409ff6fe6
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#12118https://github.com/python/mypy/pull/12118
on Aug 2, 2022https://github.com/python/mypy/issues/8005#event-7112411484
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/8005
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/8005
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-protocolshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-protocols%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.