René's URL Explorer Experiment


Title: Isinstance checks against Type[SomeProtocol] unexpectedly fails · Issue #7932 · python/mypy · GitHub

Open Graph Title: Isinstance checks against Type[SomeProtocol] unexpectedly fails · Issue #7932 · python/mypy

X Title: Isinstance checks against Type[SomeProtocol] unexpectedly fails · Issue #7932 · python/mypy

Description: Apologies in advance if this is a duplicate issue. When I try type-checking this program, the final line is inferred to be unreachable. This was a bit surprising to me: I expected to get a "Revealed type is 'SupportsLookup'" note instead...

Open Graph Description: Apologies in advance if this is a duplicate issue. When I try type-checking this program, the final line is inferred to be unreachable. This was a bit surprising to me: I expected to get a "Reveale...

X Description: Apologies in advance if this is a duplicate issue. When I try type-checking this program, the final line is inferred to be unreachable. This was a bit surprising to me: I expected to get a "Re...

Opengraph URL: https://github.com/python/mypy/issues/7932

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Isinstance checks against Type[SomeProtocol] unexpectedly fails","articleBody":"Apologies in advance if this is a duplicate issue.\r\n\r\nWhen I try type-checking this program, the final line is inferred to be unreachable. This was a bit surprising to me: I expected to get a \"Revealed type is 'SupportsLookup'\" note instead.\r\n\r\n```python\r\nfrom typing import Type\r\nfrom typing_extensions import Protocol\r\n\r\nclass SupportsLookup(Protocol):\r\n    def lookup(self, key: str) -> int: ...\r\n\r\nclass Parent: pass\r\n\r\nclass Child(Parent):\r\n    def lookup(self, key: str) -> int: ...\r\n\r\ndef cast_and_use(template: Type[SupportsLookup], x: Parent) -> None:\r\n    if isinstance(x, template):\r\n        reveal_type(x)\r\n```\r\n\r\nSomewhat curiously, if I make `x` be of type `object` instead of `Parent`, everything works as expected.\r\n\r\nThis seems a bit inconsistent to me. Assuming I'm not overlooking some type safety issue in my example, I think it'd be better to always narrow `x` to `SupportsLookup` regardless of how it's originally typed as long as the protocol doesn't directly conflict with any signatures defined in `Parent`.\r\n\r\nNote: this issue is a simplification of the root cause of the mypyc error I had in https://github.com/python/mypy/pull/7917 -- my original version of `make_indexing_replay_lookup_func` had this issue.","author":{"url":"https://github.com/Michael0x2a","@type":"Person","name":"Michael0x2a"},"datePublished":"2019-11-12T05:29:12Z","url":"https://github.com/python/mypy/issues/7932"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0534e0ab-7628-eac5-5439-8b4c1a3b662c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDEB4:100874:10C7810:16047FA:6B0007C4
html-safe-nonce7540a9cf6eaf48f7163abb9759d31d44df9f526535b15987dab0e22174f61ec4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUI0OjEwMDg3NDoxMEM3ODEwOjE2MDQ3RkE6NkIwMDA3QzQiLCJ2aXNpdG9yX2lkIjoiNDQyMzM0MzE4MzA3NzgzNjc0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac70217e464a7412b85d82b63eba1fab30d77da83f0f2ef95d3248e76fe02c73cc
hovercard-subject-tagissue:521337297
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/7932/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3c5a15fe713a0bee56ab5e20a8e940aa94069d43802b9fd872ce6ca3b418878a/python/mypy/issues/7932
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3c5a15fe713a0bee56ab5e20a8e940aa94069d43802b9fd872ce6ca3b418878a/python/mypy/issues/7932
og:image:altApologies in advance if this is a duplicate issue. When I try type-checking this program, the final line is inferred to be unreachable. This was a bit surprising to me: I expected to get a "Reveale...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/7932#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7932
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7932
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/7932
Reloadhttps://github.com/python/mypy/issues/7932
Reloadhttps://github.com/python/mypy/issues/7932
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7932
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7932
Isinstance checks against Type[SomeProtocol] unexpectedly failshttps://github.com/python/mypy/issues/7932#top
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Nov 12, 2019https://github.com/python/mypy/issues/7932#issue-521337297
#7917https://github.com/python/mypy/pull/7917
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 12, 2019https://github.com/python/mypy/issues/7932#issuecomment-552813751
mypyc/mypyc#586https://github.com/mypyc/mypyc/issues/586
#3830https://github.com/python/mypy/issues/3830
#3827https://github.com/python/mypy/issues/3827
#3603https://github.com/python/mypy/issues/3603
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 12, 2019https://github.com/python/mypy/issues/7932#event-2790765689
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/7932
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/7932
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.