René's URL Explorer Experiment


Title: Mypy does not correctly narrow indexing operations when using Literal or Final keys · Issue #7905 · python/mypy · GitHub

Open Graph Title: Mypy does not correctly narrow indexing operations when using Literal or Final keys · Issue #7905 · python/mypy

X Title: Mypy does not correctly narrow indexing operations when using Literal or Final keys · Issue #7905 · python/mypy

Description: Consider the following program: from typing_extensions import Literal, TypedDict from enum import Enum class Key(Enum): X = 1 Y = 2 Z = 3 class MyDict(TypedDict): key: Literal[Key.X, Key.Y] blah: int KEY: Literal["key"] = "key" d: MyDict...

Open Graph Description: Consider the following program: from typing_extensions import Literal, TypedDict from enum import Enum class Key(Enum): X = 1 Y = 2 Z = 3 class MyDict(TypedDict): key: Literal[Key.X, Key.Y] blah: i...

X Description: Consider the following program: from typing_extensions import Literal, TypedDict from enum import Enum class Key(Enum): X = 1 Y = 2 Z = 3 class MyDict(TypedDict): key: Literal[Key.X, Key.Y] blah: i...

Opengraph URL: https://github.com/python/mypy/issues/7905

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Mypy does not correctly narrow indexing operations when using Literal or Final keys","articleBody":"Consider the following program:\r\n\r\n```\r\nfrom typing_extensions import Literal, TypedDict\r\nfrom enum import Enum\r\n\r\nclass Key(Enum):\r\n    X = 1\r\n    Y = 2\r\n    Z = 3\r\n\r\nclass MyDict(TypedDict):\r\n    key: Literal[Key.X, Key.Y]\r\n    blah: int\r\n\r\nKEY: Literal[\"key\"] = \"key\"\r\n\r\nd: MyDict\r\n\r\nif d[\"key\"] is Key.X:\r\n    reveal_type(d[\"key\"])  # note: Revealed type is 'Literal[Key.X]'\r\n\r\nif d[KEY] is Key.X:\r\n    reveal_type(d[KEY])  # note: Revealed type is 'Literal[Key.X, Key.Y]'\r\n\r\n```\r\n\r\nMypy is currently capable of narrowing expressions like `d[\"key\"]`, which we can see in the first expression.\r\n\r\nSo, it's natural to assume that mypy would be able to do the same for the second since the two programs are theoretically identical -- but we can't.\r\n\r\nThe root cause has to do with the \"literal\" subsystem (which is not to be confused with the Literal types subsystem) here: https://github.com/python/mypy/blob/master/mypy/literals.py#L65\r\n\r\nThe index in the second example is a NameExpr, which causes the if statement to evaluate to false and return a `LITERAL_NO`. This then makes the narrowing logic rule out `d[KEY]` as a candidate for narrowing in https://github.com/python/mypy/blob/master/mypy/checker.py#L3775.\r\n\r\nI'm not really sure what the best way of fixing this would be. The natural solution would be to also pass along the expression type into the `literal(...)` function, but that seems very annoying to do. I'm also not entirely sure whether this is even a sound narrowing: I'm not very familiar with the \"literals\" subsystem, or how it's meant to interact with Literal types.","author":{"url":"https://github.com/Michael0x2a","@type":"Person","name":"Michael0x2a"},"datePublished":"2019-11-08T03:20:55Z","url":"https://github.com/python/mypy/issues/7905"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e9c60c19-4721-8def-c772-0b5b2260c9a6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9E26:22BD05:22C04AB:2F22796:6B0029C6
html-safe-nonce0b4250ff751f85815f7de4c1f4509135f118259ae51551655f788594dd74f9ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTI2OjIyQkQwNToyMkMwNEFCOjJGMjI3OTY6NkIwMDI5QzYiLCJ2aXNpdG9yX2lkIjoiNDExNTIwNzA3NjYxODE4NTE1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2796bc990f71d7d8c7da9c3bde0888fab6f5607de4a2cb61c565e928f1bba6b1
hovercard-subject-tagissue:519635729
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/7905/issue_layout
twitter:imagehttps://opengraph.githubassets.com/11e74727f2c047e0b89407bf7c02762864033fe484e53e131777f781d9644799/python/mypy/issues/7905
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/11e74727f2c047e0b89407bf7c02762864033fe484e53e131777f781d9644799/python/mypy/issues/7905
og:image:altConsider the following program: from typing_extensions import Literal, TypedDict from enum import Enum class Key(Enum): X = 1 Y = 2 Z = 3 class MyDict(TypedDict): key: Literal[Key.X, Key.Y] blah: i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/7905#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7905
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7905
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/7905
Reloadhttps://github.com/python/mypy/issues/7905
Reloadhttps://github.com/python/mypy/issues/7905
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7905
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7905
Mypy does not correctly narrow indexing operations when using Literal or Final keyshttps://github.com/python/mypy/issues/7905#top
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
topic-literal-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-literal-types%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Nov 8, 2019https://github.com/python/mypy/issues/7905#issue-519635729
https://github.com/python/mypy/blob/master/mypy/literals.py#L65https://github.com/python/mypy/blob/master/mypy/literals.py#L65
https://github.com/python/mypy/blob/master/mypy/checker.py#L3775https://github.com/python/mypy/blob/master/mypy/checker.py#L3775
Michael0x2ahttps://github.com/Michael0x2a
topic-literal-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-literal-types%22
on Nov 8, 2019https://github.com/python/mypy/issues/7905#event-2781571564
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2019https://github.com/python/mypy/issues/7905#issuecomment-551877245
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2019https://github.com/python/mypy/issues/7905#issuecomment-551878619
#7339https://github.com/python/mypy/issues/7339
Michael0x2ahttps://github.com/Michael0x2a
on Nov 9, 2019https://github.com/python/mypy/issues/7905#event-2784969585
Refine parent type when narrowing "lookup" expressionshttps://github.com/Michael0x2a/mypy/commit/9b308b67848e3d93cd40b0d442e1782fccea49e4
9b308b6https://github.com/Michael0x2a/mypy/commit/9b308b67848e3d93cd40b0d442e1782fccea49e4
Refine parent type when narrowing "lookup" expressionshttps://github.com/Michael0x2a/mypy/commit/052613381476768441d5b246c22386e42f6c0d54
0526133https://github.com/Michael0x2a/mypy/commit/052613381476768441d5b246c22386e42f6c0d54
Refine parent type when narrowing "lookup" expressionshttps://github.com/Michael0x2a/mypy/commit/14fa27f167d23fab76942e8d943daae6100e225b
14fa27fhttps://github.com/Michael0x2a/mypy/commit/14fa27f167d23fab76942e8d943daae6100e225b
Michael0x2ahttps://github.com/Michael0x2a
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Nov 10, 2019https://github.com/python/mypy/issues/7905#event-2786147925
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Nov 10, 2019https://github.com/python/mypy/issues/7905#issuecomment-552218551
Michael0x2ahttps://github.com/Michael0x2a
on Nov 13, 2019https://github.com/python/mypy/issues/7905#event-2793645075
Refine parent type when narrowing "lookup" expressions (#7917)https://github.com/python/mypy/commit/648d99aaac2436358aabefa8be018632768c3e3e
#7917https://github.com/python/mypy/pull/7917
648d99ahttps://github.com/python/mypy/commit/648d99aaac2436358aabefa8be018632768c3e3e
97littleleaf11https://github.com/97littleleaf11
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
on Jan 14, 2022https://github.com/python/mypy/issues/7905#event-5895012100
AlexWaygoodhttps://github.com/AlexWaygood
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
on Mar 28, 2022https://github.com/python/mypy/issues/7905#event-6316758786
AlexWaygoodhttps://github.com/AlexWaygood
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on May 3, 2022https://github.com/python/mypy/issues/7905#event-6541433914
https://github.com/alicederyn
alicederynhttps://github.com/alicederyn
on May 1, 2026https://github.com/python/mypy/issues/7905#issuecomment-4360081135
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on May 1, 2026https://github.com/python/mypy/issues/7905#issuecomment-4362201372
@Michael0x2ahttps://github.com/Michael0x2a
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/7905
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/7905
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
topic-literal-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-literal-types%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-typed-dicthttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-typed-dict%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.