René's URL Explorer Experiment


Title: Refactor all member access to go through checkmember.py (meta issue) · Issue #7724 · python/mypy · GitHub

Open Graph Title: Refactor all member access to go through checkmember.py (meta issue) · Issue #7724 · python/mypy

X Title: Refactor all member access to go through checkmember.py (meta issue) · Issue #7724 · python/mypy

Description: There are bunch of places where we duplicate some parts of code for special logic in member access (such as properties, class methods, descriptors, __getattr__(), etc): The checkmember.py itself Override checks for variables Override che...

Open Graph Description: There are bunch of places where we duplicate some parts of code for special logic in member access (such as properties, class methods, descriptors, __getattr__(), etc): The checkmember.py itself Ov...

X Description: There are bunch of places where we duplicate some parts of code for special logic in member access (such as properties, class methods, descriptors, __getattr__(), etc): The checkmember.py itself Ov...

Opengraph URL: https://github.com/python/mypy/issues/7724

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor all member access to go through checkmember.py (meta issue)","articleBody":"There are bunch of places where we duplicate some parts of code for special logic in member access (such as properties, class methods, descriptors, `__getattr__()`, etc):\r\n* The `checkmember.py` itself\r\n* Override checks for variables\r\n* Override checks for methods\r\n* Multiple inheritance checks\r\n* Checks for special methods via `check_op()` and `has_member()`\r\n* Protocol implementation check\r\n\r\nHere are some issues that will be solved (or significantly simplified) by refactoring this to go through the same place (probably `checkmember.py`):\r\n* https://github.com/python/mypy/issues/4125\r\n* https://github.com/python/mypy/issues/5425\r\n* https://github.com/python/mypy/issues/5136\r\n* https://github.com/python/mypy/issues/3832\r\n* https://github.com/python/mypy/issues/7565\r\n* https://github.com/python/mypy/issues/7153\r\n* https://github.com/python/mypy/issues/5836\r\n* https://github.com/python/mypy/issues/5803\r\n* https://github.com/python/mypy/issues/5491\r\n* https://github.com/python/mypy/issues/5481\r\n\r\nAlso I think having member access cleaned-up, centralized, and documented will open the way to finally solving https://github.com/python/mypy/issues/708 (currently the oldest high priority issue), and to having general support for descriptor protocol (for historical reasons, several things like properties are supported via some special-casing).","author":{"url":"https://github.com/ilevkivskyi","@type":"Person","name":"ilevkivskyi"},"datePublished":"2019-10-16T14:17:25Z","url":"https://github.com/python/mypy/issues/7724"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3d89cc9f-dfbc-daf4-3196-9e6a40422728
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE4F2:144E47:2464357:2F5235F:6AFFEF86
html-safe-nonce1adb6561faf904d87c261a1f6bb62a23d9b6bda718d305bc76ca5aa9d483794e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNEYyOjE0NEU0NzoyNDY0MzU3OjJGNTIzNUY6NkFGRkVGODYiLCJ2aXNpdG9yX2lkIjoiNjQ5NjA3MTg4MTYxMzg5NzYwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacffe4bb7b8507ae0769074ae4b4d09c506333d2a83b5882c995cf167b1498179f
hovercard-subject-tagissue:507882541
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/7724/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2ac0b1b1aa127b3bdb1d0b984e08f36e9d609bc92b223cb75acee169ef3b6e06/python/mypy/issues/7724
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2ac0b1b1aa127b3bdb1d0b984e08f36e9d609bc92b223cb75acee169ef3b6e06/python/mypy/issues/7724
og:image:altThere are bunch of places where we duplicate some parts of code for special logic in member access (such as properties, class methods, descriptors, __getattr__(), etc): The checkmember.py itself Ov...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/7724#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7724
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7724
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/7724
Reloadhttps://github.com/python/mypy/issues/7724
Reloadhttps://github.com/python/mypy/issues/7724
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7724
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7724
#19180https://github.com/python/mypy/pull/19180
Refactor all member access to go through checkmember.py (meta issue)https://github.com/python/mypy/issues/7724#top
#19180https://github.com/python/mypy/pull/19180
metaIssues tracking a broad area of workhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22meta%22
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Oct 16, 2019https://github.com/python/mypy/issues/7724#issue-507882541
Mypy disallows overriding an attribute with a property #4125https://github.com/python/mypy/issues/4125
Overriding definition such as type alias in a subclass causes a crash #5425https://github.com/python/mypy/issues/5425
Refactor operator method access and protocol checks to use checkmember.py #5136https://github.com/python/mypy/issues/5136
Refactor common code in analyze_member_access and find_member #3832https://github.com/python/mypy/issues/3832
Overriding method with a property results in a false negative #7565https://github.com/python/mypy/issues/7565
mypy false positive with custom property descriptors  #7153https://github.com/python/mypy/issues/7153
Decorated method type-incompatibility with superclass #5836https://github.com/python/mypy/issues/5836
Custom property/descriptor and base classes #5803https://github.com/python/mypy/issues/5803
Clean up kludges for handling metaclasses and Type[...] in check_op_reversible #5491https://github.com/python/mypy/issues/5491
Protocols don't support descriptors #5481https://github.com/python/mypy/issues/5481
#708https://github.com/python/mypy/issues/708
ilevkivskyihttps://github.com/ilevkivskyi
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
on Oct 16, 2019https://github.com/python/mypy/issues/7724#event-2717809782
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 27, 2019https://github.com/python/mypy/issues/7724#event-2836512418
Make logic around bind_self() consistent in different code paths (#8021)https://github.com/python/mypy/commit/1122fc6eabbbba9eb2f9912494e3e19aca8c3156
#8021https://github.com/python/mypy/pull/8021
1122fc6https://github.com/python/mypy/commit/1122fc6eabbbba9eb2f9912494e3e19aca8c3156
Apply generic class fix also to non-callable types (#8030)https://github.com/python/mypy/commit/b5f4df9862f43d71029ccc6307d679953ccdfca8
#8030https://github.com/python/mypy/pull/8030
b5f4df9https://github.com/python/mypy/commit/b5f4df9862f43d71029ccc6307d679953ccdfca8
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Jun 23, 2021https://github.com/python/mypy/issues/7724#issuecomment-866768947
https://github.com/sobolevn
sobolevnhttps://github.com/sobolevn
on Jun 23, 2021https://github.com/python/mypy/issues/7724#issuecomment-866776226
97littleleaf11https://github.com/97littleleaf11
metaIssues tracking a broad area of workhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22meta%22
on Dec 1, 2021https://github.com/python/mypy/issues/7724#event-5701795652
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 15, 2022https://github.com/python/mypy/issues/7724#event-7817903565
Add support for Self type (#14041)https://github.com/python/mypy/commit/77dd4b4df5b8bcd716352144feeb78862427f4dd
#14041https://github.com/python/mypy/pull/14041
77dd4b4https://github.com/python/mypy/commit/77dd4b4df5b8bcd716352144feeb78862427f4dd
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 15, 2024https://github.com/python/mypy/issues/7724#issuecomment-2169474093
ilevkivskyihttps://github.com/ilevkivskyi
on Mar 31, 2025https://github.com/python/mypy/issues/7724#event-17057659644
Use checkmember.py to check variable overrides (#18847)https://github.com/python/mypy/commit/4629de44c1fdbfc0d77ffaa5458c64481ba6976c
#18847https://github.com/python/mypy/pull/18847
4629de4https://github.com/python/mypy/commit/4629de44c1fdbfc0d77ffaa5458c64481ba6976c
Use checkmember.py to check method override (#18870)https://github.com/python/mypy/commit/b6a662c3e639bf47a51b93a3e3198e7de25af424
#18870https://github.com/python/mypy/pull/18870
b6a662chttps://github.com/python/mypy/commit/b6a662c3e639bf47a51b93a3e3198e7de25af424
Use checkmember.py to check multiple inheritance (#18876)https://github.com/python/mypy/commit/fcabf19782c95372753e148629c962e3c9218b09
#18876https://github.com/python/mypy/pull/18876
fcabf19https://github.com/python/mypy/commit/fcabf19782c95372753e148629c962e3c9218b09
ilevkivskyihttps://github.com/ilevkivskyi
on May 30, 2025https://github.com/python/mypy/issues/7724#event-17892000277
Use checkmember.py to check protocol subtyping (#18943)https://github.com/python/mypy/commit/39570250e35151e387e6e1daf08b4f4e4262726e
#18943https://github.com/python/mypy/pull/18943
3957025https://github.com/python/mypy/commit/39570250e35151e387e6e1daf08b4f4e4262726e
lsrafael13https://github.com/lsrafael13
on May 30, 2025https://github.com/python/mypy/issues/7724#event-17892784327
Prohibit assignment to __class__ inside instance methodshttps://github.com/lsrafael13/mypy/commit/59450e8a0c43def8bc619b23a1855c799382049e
https://docs.github.com/articles/closing-issues-via-commit-messages
59450e8https://github.com/lsrafael13/mypy/commit/59450e8a0c43def8bc619b23a1855c799382049e
cdce8phttps://github.com/cdce8p
on May 31, 2025https://github.com/python/mypy/issues/7724#event-17902197758
Use checkmember.py to check protocol subtyping (python#18943)https://github.com/cdce8p/mypy/commit/2b175b2cd6fa183fbd0c8320fbb4f96866857ebe
python#18943https://github.com/python/mypy/pull/18943
2b175b2https://github.com/cdce8p/mypy/commit/2b175b2cd6fa183fbd0c8320fbb4f96866857ebe
lsrafael13https://github.com/lsrafael13
on Jun 1, 2025https://github.com/python/mypy/issues/7724#event-17918097874
Fix assignment to __class__ check to use errors.report() in VarAssign…https://github.com/lsrafael13/mypy/commit/111a3c4ec60f6487e4247f61e8597d6befd528aa
https://docs.github.com/articles/closing-issues-via-commit-messages
111a3c4https://github.com/lsrafael13/mypy/commit/111a3c4ec60f6487e4247f61e8597d6befd528aa
Disallow assignment to '__class__' in TypeChecker.visit_assignment_stmthttps://github.com/lsrafael13/mypy/commit/cd6d90b5526522bec63fbb64a45734d36f7baa1c
https://docs.github.com/articles/closing-issues-via-commit-messages
cd6d90bhttps://github.com/lsrafael13/mypy/commit/cd6d90b5526522bec63fbb64a45734d36f7baa1c
Add __class__ assignment check to TypeChecker.visit_assignment_stmthttps://github.com/lsrafael13/mypy/commit/78a6c991ab4b628718bc1097daf5a113b87bad48
https://docs.github.com/articles/closing-issues-via-commit-messages
78a6c99https://github.com/lsrafael13/mypy/commit/78a6c991ab4b628718bc1097daf5a113b87bad48
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 9, 2025https://github.com/python/mypy/issues/7724#event-18056808679
Clean-up and move operator access to checkmember.py (#19250)https://github.com/python/mypy/commit/ac511d6c4615ca45a9404ed3eb53ea7092b0aca1
#19250https://github.com/python/mypy/pull/19250
ac511d6https://github.com/python/mypy/commit/ac511d6c4615ca45a9404ed3eb53ea7092b0aca1
Refactor/unify access to static attributes (#19254)https://github.com/python/mypy/commit/929377ac57fb1b4466d5dcc871648b56e41e583b
#19254https://github.com/python/mypy/pull/19254
929377ahttps://github.com/python/mypy/commit/929377ac57fb1b4466d5dcc871648b56e41e583b
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 14, 2025https://github.com/python/mypy/issues/7724#issuecomment-2973005707
#19299https://github.com/python/mypy/issues/19299
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 14, 2025https://github.com/python/mypy/issues/7724#event-18151381655
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 19, 2025https://github.com/python/mypy/issues/7724#event-18233621867
Cleanup generic class variable access (#19292)https://github.com/python/mypy/commit/ad570933924b3810ba61d2e4a13eac596f74672b
#19292https://github.com/python/mypy/pull/19292
ad57093https://github.com/python/mypy/commit/ad570933924b3810ba61d2e4a13eac596f74672b
Re-widen custom properties after narrowing (#19296)https://github.com/python/mypy/commit/96fcd59585d1460440967f5dd6bdc82d43703187
#19296https://github.com/python/mypy/pull/19296
96fcd59https://github.com/python/mypy/commit/96fcd59585d1460440967f5dd6bdc82d43703187
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/7724
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/7724
metaIssues tracking a broad area of workhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22meta%22
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.