René's URL Explorer Experiment


Title: Type refinements are not applied to index expressions · Issue #7339 · python/mypy · GitHub

Open Graph Title: Type refinements are not applied to index expressions · Issue #7339 · python/mypy

X Title: Type refinements are not applied to index expressions · Issue #7339 · python/mypy

Description: Ran into this issue today, I believe mypy is incorrectly flagging this as an error: from typing import Any, Dict, Optional def rename_keys( original_dict: Dict[str, Any], key_mapping: Dict[str, Optional[str]] ) -> Dict[str, Any]: """Rena...

Open Graph Description: Ran into this issue today, I believe mypy is incorrectly flagging this as an error: from typing import Any, Dict, Optional def rename_keys( original_dict: Dict[str, Any], key_mapping: Dict[str, Opt...

X Description: Ran into this issue today, I believe mypy is incorrectly flagging this as an error: from typing import Any, Dict, Optional def rename_keys( original_dict: Dict[str, Any], key_mapping: Dict[str, Opt...

Opengraph URL: https://github.com/python/mypy/issues/7339

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type refinements are not applied to index expressions","articleBody":"Ran into this issue today, I believe mypy is incorrectly flagging this as an error:\r\n```\r\nfrom typing import Any, Dict, Optional\r\n\r\n\r\ndef rename_keys(\r\n    original_dict: Dict[str, Any], key_mapping: Dict[str, Optional[str]]\r\n) -> Dict[str, Any]:\r\n    \"\"\"Renames keys in the dictionary using the key_mapping. If the value in key_mapping is None then it will remove the key entirely\"\"\"\r\n    return {\r\n        key_mapping.get(k, k): v\r\n        for k, v in original_dict.items()\r\n        if k not in key_mapping or key_mapping[k] is not None\r\n    }\r\n```\r\n\r\noutput from mypy:\r\n```\r\n/tmp/mypytest.py:8: error: Key expression in dictionary comprehension has incompatible type \"Optional[str]\"; expected type \"str\"\r\n```\r\n\r\nif `key_mapping.get(k)` is `None` then it would fail the if-statement at the end of the dictionary comprehension and therefore get filtered out\r\n\r\nif `k` is not in `key_mapping` then `k` is the result of the expression `key_mapping.get(k,k)`. `k` can't be `None` because `k` comes from the keys of `original_dict` which has the type `Dict[str, Any]`\r\n\r\nVersions: mypy 0.701, Python 3.7.4\r\n\r\nno flags","author":{"url":"https://github.com/tomalexander","@type":"Person","name":"tomalexander"},"datePublished":"2019-08-14T14:37:50Z","url":"https://github.com/python/mypy/issues/7339"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e824fd18-ca39-91ea-a033-b3e1be19afc7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD036:1AC37C:A2AF54:D91717:6B004717
html-safe-nonce1b605810c6ec0ff407524e3594de20a5d8f91b56dbdcc556bea540b05f309103
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDM2OjFBQzM3QzpBMkFGNTQ6RDkxNzE3OjZCMDA0NzE3IiwidmlzaXRvcl9pZCI6IjgwMDQ0MzAyMTY2MTkzNzg0NTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3d675ae5e5acbfc96a906b60de47615866f265af34e10fc2ba981e2916cbc5d4
hovercard-subject-tagissue:480717468
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/7339/issue_layout
twitter:imagehttps://opengraph.githubassets.com/1c32b3a1419ea7bbfe85a75f7d62009345b23925189961fa7f40374de0d9ec57/python/mypy/issues/7339
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1c32b3a1419ea7bbfe85a75f7d62009345b23925189961fa7f40374de0d9ec57/python/mypy/issues/7339
og:image:altRan into this issue today, I believe mypy is incorrectly flagging this as an error: from typing import Any, Dict, Optional def rename_keys( original_dict: Dict[str, Any], key_mapping: Dict[str, Opt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametomalexander
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/7339#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7339
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7339
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/7339
Reloadhttps://github.com/python/mypy/issues/7339
Reloadhttps://github.com/python/mypy/issues/7339
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7339
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7339
Type refinements are not applied to index expressionshttps://github.com/python/mypy/issues/7339#top
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/tomalexander
tomalexanderhttps://github.com/tomalexander
on Aug 14, 2019https://github.com/python/mypy/issues/7339#issue-480717468
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 14, 2019https://github.com/python/mypy/issues/7339#issuecomment-521295382
@JukkaLhttps://github.com/JukkaL
ilevkivskyihttps://github.com/ilevkivskyi
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Aug 14, 2019https://github.com/python/mypy/issues/7339#event-2557004011
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Aug 26, 2019https://github.com/python/mypy/issues/7339#issuecomment-524837255
ilevkivskyihttps://github.com/ilevkivskyi
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
on Oct 14, 2019https://github.com/python/mypy/issues/7339#event-2710596731
ilevkivskyihttps://github.com/ilevkivskyi
on Oct 14, 2019https://github.com/python/mypy/issues/7339#event-2710599192
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Oct 14, 2019https://github.com/python/mypy/issues/7339#issuecomment-541705287
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Nov 8, 2019https://github.com/python/mypy/issues/7339#issuecomment-551878486
#2458https://github.com/python/mypy/issues/2458
JelleZijlstrahttps://github.com/JelleZijlstra
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on Mar 19, 2022https://github.com/python/mypy/issues/7339#event-6270156683
https://github.com/rnestler
rnestlerhttps://github.com/rnestler
on Feb 13, 2023https://github.com/python/mypy/issues/7339#issuecomment-1427805016
https://github.com/rnestler/minimal-example-for-mypy-dict-issuehttps://github.com/rnestler/minimal-example-for-mypy-dict-issue
https://github.com/lafrech
lafrechhttps://github.com/lafrech
on Nov 22, 2023https://github.com/python/mypy/issues/7339#issuecomment-1823080654
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/7339
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/7339
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.