René's URL Explorer Experiment


Title: mypy false positive with custom property descriptors · Issue #7153 · python/mypy · GitHub

Open Graph Title: mypy false positive with custom property descriptors · Issue #7153 · python/mypy

X Title: mypy false positive with custom property descriptors · Issue #7153 · python/mypy

Description: Note: if you are reporting a wrong signature of a function or a class in the standard library, then the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues Please provide more information to help ...

Open Graph Description: Note: if you are reporting a wrong signature of a function or a class in the standard library, then the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues ...

X Description: Note: if you are reporting a wrong signature of a function or a class in the standard library, then the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues ...

Opengraph URL: https://github.com/python/mypy/issues/7153

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mypy false positive with custom property descriptors ","articleBody":"\r\nNote: if you are reporting a wrong signature of a function or a class in\r\nthe standard library, then the typeshed tracker is better suited\r\nfor this report: https://github.com/python/typeshed/issues\r\n\r\nPlease provide more information to help us understand the issue:\r\n\r\n* Are you reporting a bug, or opening a feature request? \r\n\r\nBug.\r\n\r\n* Please insert below the code you are checking with mypy,\r\n  or a mock-up repro if the source is private. We would appreciate\r\n  if you try to simplify your case to a minimal repro.\r\n\r\nSee below.\r\n\r\n* What is the actual behavior/output?\r\n\r\nSee below.\r\n\r\n* What is the behavior/output you expect?\r\n\r\nError as shown n output should not be reported.\r\n\r\n* What are the versions of mypy and Python you are using?\r\n\r\nmypy 0.711, python 3.7.3\r\n\r\n* What are the mypy flags you are using? (For example --strict-optional)\r\n\r\nNone.\r\n\r\n--------------------------------------------------------------------------------------\r\n\r\nIt doesn't seem to be possible to create an explicit descriptor class that behaves\r\nthe same way as @Property does with respect to methods of sub-types declaring more constrained return types.\r\n\r\nIn the example below, we have classes \"Obj\" > \"Foo\", and \"AA\" > \"BB\".\r\nAll methods of Obj return AA. Foo overrides all methods of Obj, but all of those methods\r\nreturn \"BB\". Note that all methods of Foo are still consistent with the definitions in\r\nObj.\r\n\r\nThe method func1 has no decorators and is accepted without complaints, and its types are correctly recognized.\r\n\r\nMethod func3 is decorated with \"@Property\". Here too, mypy handles this case without error.\r\n\r\nMethod func2 is decorated with \"@prop\", which is a custom property descriptor.\r\nThe revealed types for func2 are consistent with func3 -- hence the typing for the \"prop\" class appears to be consistent with what \"@property\" does. However, mypy flags an error that\r\nFoo.func2 is not consistent with the super type definition Obj.func2. (As a related issue, I haven't been able to come up with a better typing scheme for \"prop\" without using \"type:ignore\", which still gives the same type results.)\r\n\r\nIn this example below, I'd expect mypy to report no errors on either func2 or func3, or to report errors for both. As it stands, it appears that it's not possible to create a typing scheme for a descriptor that fully mirrors mypy's special handling for \"@property\".\r\n\r\n```\r\n\r\nfrom typing import Generic, TypeVar,Type, Callable,Any, Union, overload,Optional\r\n\r\nOwnerType = TypeVar(\"OwnerType\", bound=object)\r\nT = TypeVar('T', covariant=True)\r\nCallableType = TypeVar(\"CallableType\", bound=Callable)\r\n\r\n\r\nclass prop(Generic[T]):\r\n    def __init__(self, func: Callable[[Any], T]):\r\n        self.func = func\r\n\r\n    def __get__(self, obj: Any, owner: Type[Any]) -> T:\r\n        if obj is None:\r\n            return self # type: ignore\r\n        return self.func(obj)\r\n\r\nclass AA:\r\n    def foo(self) -> int:\r\n        return 1\r\n\r\nclass BB(AA):\r\n    def bar(self) -> int:\r\n        return 1\r\n\r\n    \r\nclass Obj:\r\n    def func1(self) -> AA:\r\n        return AA()\r\n    @prop\r\n    def func2(self) -> AA:\r\n        return AA()\r\n    @property\r\n    def func3(self) -> AA:\r\n        return AA()        \r\n\r\nclass Foo(Obj):\r\n    def func1(self) -> BB:\r\n        return BB()\r\n    @prop\r\n    def func2(self) -> BB:\r\n        return BB()\r\n    @property\r\n    def func3(self) -> BB:\r\n        return BB()    \r\n\r\n\r\nx = Obj()\r\ny = Foo()\r\nreveal_type(Obj.func1)\r\nreveal_type(Obj.func2)\r\nreveal_type(Obj.func3)\r\nreveal_type(Foo.func1)\r\nreveal_type(Foo.func2)\r\nreveal_type(Foo.func3)\r\nreveal_type(x.func1)\r\nreveal_type(x.func2)\r\nreveal_type(x.func3)\r\nreveal_type(y.func1)\r\nreveal_type(y.func2)\r\nreveal_type(y.func3)\r\n```\r\nMypy output:\r\n\r\n/tmp/xx.py:40: error: Signature of \"func2\" incompatible with supertype \"Obj\"\r\n/tmp/xx.py:49: note: Revealed type is 'def (self: xx.Obj) -> xx.AA'\r\n/tmp/xx.py:50: note: Revealed type is 'xx.AA*'\r\n/tmp/xx.py:51: note: Revealed type is 'def (self: xx.Obj) -> xx.AA'\r\n/tmp/xx.py:52: note: Revealed type is 'def (self: xx.Foo) -> xx.BB'\r\n/tmp/xx.py:53: note: Revealed type is 'xx.BB*'\r\n/tmp/xx.py:54: note: Revealed type is 'def (self: xx.Foo) -> xx.BB'\r\n/tmp/xx.py:55: note: Revealed type is 'def () -> xx.AA'\r\n/tmp/xx.py:56: note: Revealed type is 'xx.AA*'\r\n/tmp/xx.py:57: note: Revealed type is 'xx.AA'\r\n/tmp/xx.py:58: note: Revealed type is 'def () -> xx.BB'\r\n/tmp/xx.py:59: note: Revealed type is 'xx.BB*'\r\n/tmp/xx.py:60: note: Revealed type is 'xx.BB'","author":{"url":"https://github.com/mostrows2","@type":"Person","name":"mostrows2"},"datePublished":"2019-07-04T17:40:13Z","url":"https://github.com/python/mypy/issues/7153"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2d813246-2ec0-394f-46da-2bc910c6185f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD022:2E6021:240FE47:2F03016:6AFFF26B
html-safe-noncedd44d8a1e3147526354ebcf350041dc84af540a289d79e40fce456eeb9abb2e4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDIyOjJFNjAyMToyNDBGRTQ3OjJGMDMwMTY6NkFGRkYyNkIiLCJ2aXNpdG9yX2lkIjoiNDQzNzMwOTM4NTkzMjI3MjIzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2bef18b9b7e0334d222e981252d78d8b2232d3cb87cd6b5134d7c4416077ad1d
hovercard-subject-tagissue:464356820
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/7153/issue_layout
twitter:imagehttps://opengraph.githubassets.com/90c8e38b5532ea5bd6a5fcf4e162feec47787878560781cc3759e4bd2e4ce0b7/python/mypy/issues/7153
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90c8e38b5532ea5bd6a5fcf4e162feec47787878560781cc3759e4bd2e4ce0b7/python/mypy/issues/7153
og:image:altNote: if you are reporting a wrong signature of a function or a class in the standard library, then the typeshed tracker is better suited for this report: https://github.com/python/typeshed/issues ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemostrows2
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/7153#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7153
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7153
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/7153
Reloadhttps://github.com/python/mypy/issues/7153
Reloadhttps://github.com/python/mypy/issues/7153
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7153
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7153
mypy false positive with custom property descriptors https://github.com/python/mypy/issues/7153#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
https://github.com/mostrows2
mostrows2https://github.com/mostrows2
on Jul 4, 2019https://github.com/python/mypy/issues/7153#issue-464356820
https://github.com/python/typeshed/issueshttps://github.com/python/typeshed/issues
@Propertyhttps://github.com/Property
@Propertyhttps://github.com/Property
@prophttps://github.com/prop
@Propertyhttps://github.com/Property
@Propertyhttps://github.com/Property
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 12, 2019https://github.com/python/mypy/issues/7153#issuecomment-520412847
#2566https://github.com/python/mypy/issues/2566
ilevkivskyihttps://github.com/ilevkivskyi
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Aug 12, 2019https://github.com/python/mypy/issues/7153#event-2550090312
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 12, 2019https://github.com/python/mypy/issues/7153#issuecomment-520419864
#3208https://github.com/python/mypy/issues/3208
ilevkivskyihttps://github.com/ilevkivskyi
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Aug 12, 2019https://github.com/python/mypy/issues/7153#event-2550151261
JelleZijlstrahttps://github.com/JelleZijlstra
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
on Mar 19, 2022https://github.com/python/mypy/issues/7153#event-6270152672
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Mar 26, 2022https://github.com/python/mypy/issues/7153#issuecomment-1079716898
Can't reproduce this issuehttps://mypy-play.net/?mypy=latest&python=3.10&flags=strict&gist=04ccf5658839057e438d52b3b657a4a5
AlexWaygoodhttps://github.com/AlexWaygood
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 26, 2022https://github.com/python/mypy/issues/7153#event-6312012457
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/7153
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/7153
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-descriptorsProperties, class vs. instance attributeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-descriptors%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.