René's URL Explorer Experiment


Title: Overriding final method only raises error if overriding method is annotated · Issue #7015 · python/mypy · GitHub

Open Graph Title: Overriding final method only raises error if overriding method is annotated · Issue #7015 · python/mypy

X Title: Overriding final method only raises error if overriding method is annotated · Issue #7015 · python/mypy

Description: In the code below I expected both subclasses to raise errors due to overriding method marked with @final, but only the B class raises an error, it seems like adding the return type annotation triggers the check. The same behavior is not ...

Open Graph Description: In the code below I expected both subclasses to raise errors due to overriding method marked with @final, but only the B class raises an error, it seems like adding the return type annotation trigg...

X Description: In the code below I expected both subclasses to raise errors due to overriding method marked with @final, but only the B class raises an error, it seems like adding the return type annotation trigg...

Opengraph URL: https://github.com/python/mypy/issues/7015

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Overriding final method only raises error if overriding method is annotated ","articleBody":"In the code below I expected both subclasses to raise errors due to overriding method marked with `@final`, but only the `B` class raises an error, it seems like adding the return type annotation triggers the check. The same behavior is not specific to `__init__` but happens with any method name.\r\n\r\n\r\n```python\r\nfrom typing_extensions import final\r\n\r\n\r\nclass Base:\r\n    @final\r\n    def __init__(self):\r\n        pass\r\n\r\n\r\nclass A(Base):\r\n    def __init__(self):  # no error raised\r\n        pass\r\n\r\n\r\nclass B(Base):\r\n    def __init__(self) -> None:  # raises an error\r\n        pass\r\n```\r\n\r\nsetup.cfg:\r\n\r\n```\r\n[mypy]\r\nignore_missing_imports = True\r\nstrict_optional = True\r\nno_implicit_optional = True\r\ncheck_untyped_defs = True\r\ndisallow_incomplete_defs = True\r\ndisallow_any_unimported = True\r\ndisallow_untyped_decorators = True\r\n```\r\n\r\nSame result with both master `mypy 0.710+dev.44172caa122b01af5a63ec5787931b910f272eb6` and latest stable `mypy 0.701` using Python 3.7.0.\r\n","author":{"url":"https://github.com/antonagestam","@type":"Person","name":"antonagestam"},"datePublished":"2019-06-18T07:17:47Z","url":"https://github.com/python/mypy/issues/7015"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1a70b9f1-c29a-80b2-6db0-f49d8d87d50d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8D4C:1BAA33:19E2BB3:22588A1:6B0026FE
html-safe-nonce7390531df406d5271e7ee8f5c588cdf6a13c1b027c39796ad16417ac70aded01
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDRDOjFCQUEzMzoxOUUyQkIzOjIyNTg4QTE6NkIwMDI2RkUiLCJ2aXNpdG9yX2lkIjoiNDY0MDc2NjcxMTIwNzgzMTI5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac48d2f81d00124ec50866f7e016bd5f516eed13bd9522b28010d2d58fb411c55f
hovercard-subject-tagissue:457302055
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/7015/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fe740bea4c3bde8c05a858f6d289cd6a4b0dd46fd1de2121c942f77f1fa28adf/python/mypy/issues/7015
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fe740bea4c3bde8c05a858f6d289cd6a4b0dd46fd1de2121c942f77f1fa28adf/python/mypy/issues/7015
og:image:altIn the code below I expected both subclasses to raise errors due to overriding method marked with @final, but only the B class raises an error, it seems like adding the return type annotation trigg...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameantonagestam
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/7015#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7015
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F7015
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/7015
Reloadhttps://github.com/python/mypy/issues/7015
Reloadhttps://github.com/python/mypy/issues/7015
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7015
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/7015
Overriding final method only raises error if overriding method is annotated https://github.com/python/mypy/issues/7015#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
https://github.com/antonagestam
antonagestamhttps://github.com/antonagestam
on Jun 18, 2019https://github.com/python/mypy/issues/7015#issue-457302055
antonagestamhttps://github.com/antonagestam
on Jun 18, 2019https://github.com/python/mypy/issues/7015#event-2419812886
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 18, 2019https://github.com/python/mypy/issues/7015#issuecomment-503072754
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 18, 2019https://github.com/python/mypy/issues/7015#event-2420573666
ilevkivskyihttps://github.com/ilevkivskyi
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Jun 18, 2019https://github.com/python/mypy/issues/7015#event-2420573934
AlexWaygoodhttps://github.com/AlexWaygood
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
on Mar 27, 2022https://github.com/python/mypy/issues/7015#event-6313451172
hauntsaninjahttps://github.com/hauntsaninja
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 1, 2024https://github.com/python/mypy/issues/7015#event-13729666511
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/7015
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/7015
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-finalPEP 591https://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-final%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.