Title: Strange "Attributes without a default cannot follow attributes with one" when extending a dataclass from a package · Issue #6960 · python/mypy · GitHub
Open Graph Title: Strange "Attributes without a default cannot follow attributes with one" when extending a dataclass from a package · Issue #6960 · python/mypy
X Title: Strange "Attributes without a default cannot follow attributes with one" when extending a dataclass from a package · Issue #6960 · python/mypy
Description: Apologies upfront, this must be the worst bug report I've ever made. I can only reproduce it every now and then, and only in a quite complicated code base. Just logging it here in case it rings a bell (or someone else has the same issue)...
Open Graph Description: Apologies upfront, this must be the worst bug report I've ever made. I can only reproduce it every now and then, and only in a quite complicated code base. Just logging it here in case it rings a b...
X Description: Apologies upfront, this must be the worst bug report I've ever made. I can only reproduce it every now and then, and only in a quite complicated code base. Just logging it here in case it rings...
Opengraph URL: https://github.com/python/mypy/issues/6960
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Strange \"Attributes without a default cannot follow attributes with one\" when extending a dataclass from a package","articleBody":"Apologies upfront, this must be the worst bug report I've ever made. I can only reproduce it every now and then, and only in a quite complicated code base. Just logging it here in case it rings a bell (or someone else has the same issue).\r\n\r\nI have a package (which we distribute through our own, private, pypi), with type-support (`py.typed` file present). There are no stub files, all types are inline.\r\n\r\nThe package defines a dataclass, e.g. file `cars.py`\r\n```\r\n 1. import dataclasses\r\n 2.\r\n 3.\r\n 4.\r\n 5. # some empty lines to illustrate a point\r\n 6.\r\n 7.\r\n 8.\r\n 9.\r\n10. @dataclasses.dataclass(frozen=True)\r\n11. class Car:\r\n12. name: str\r\n13. top_speed: float\r\n14. brand: str = \"Renault\"\r\n```\r\n\r\nNow in my main program (main.py) I need to get a dataclass that is very much like a Car, I just need to be able to set the top_speed to \"uknown\" (a string).\r\n```\r\n 1. import dataclasses\r\n 2. from mypackage import cars\r\n 3.\r\n 4. @dataclasses.dataclass(frozen=True)\r\n 5. class UnknownCar(cars.Car):\r\n 6. top_speed: str\r\n 7.\r\n 8. mycar = UnknownCar(name=\"unknown\", top_speed=\"unkown\", brand=\"unknown\")\r\n```\r\n\r\nNow I would expect mypy to give a warning (Subclass not compatible with super class). What happens however is this:\r\n\r\nThe first run, no errors. Subsequent runs (same command) give the errors below (until `.mypy-cache/` is removed, after which the first run again is errorfree)\r\n```\r\nmain.py:6 error: Attributes without a default cannot follow attributes with one\r\nmain.py:12 error: Attributes without a default cannot follow attributes with one\r\nmain.py:13 error: Attributes without a default cannot follow attributes with one\r\n```\r\n\r\nSo what seems to happen is that mypy (incorrectly) assumes that the `top_speed` for UnknownCar will be added as last argument (and then it complains, correctly, that the argument before it, brand, has a default)\r\n\r\nThe next 2 error however point to the lines where `name` and `top_speed` are defined in `cars.py` (even though the error says `main.py`). If I add more newlines to the cars.py file, these line numbers in the errormessage change, and if I give default values to them, the errors disappear. By giving a fake default (of `dataclasses.field()`) to all entries, all errors disappear. Note that no amount of `type: ignore` in the `main.py` file seems to be able to get rid of the errors.\r\n\r\nThe behaviour was observed (however not always consistently) in mypy 0.670, 0.701 and HEAD.","author":{"url":"https://github.com/reinhrst","@type":"Person","name":"reinhrst"},"datePublished":"2019-06-08T21:18:31Z","url":"https://github.com/python/mypy/issues/6960"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:58a61e6c-1918-1f95-902f-b4fc8ad9d408 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 985E:3AE712:4F7324:6AED3B:6B002FE1 |
| html-safe-nonce | e339ba3d0d54f5c0b75aa9444228fa3f75e385b4ed314b86f3974e63bb53a874 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5ODVFOjNBRTcxMjo0RjczMjQ6NkFFRDNCOjZCMDAyRkUxIiwidmlzaXRvcl9pZCI6Ijc0MzE0MzI5OTQ2NjI5MjAxNjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8b399e6cb7d2a716819cd73930caf3bdbc7643cbdb65d690e88c68861cdbc930 |
| hovercard-subject-tag | issue:453836769 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/6960/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b34e899e99db8e93da2eef55a5e597c16b213ec9d0f83aa1bba1a50fb58ddee1/python/mypy/issues/6960 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b34e899e99db8e93da2eef55a5e597c16b213ec9d0f83aa1bba1a50fb58ddee1/python/mypy/issues/6960 |
| og:image:alt | Apologies upfront, this must be the worst bug report I've ever made. I can only reproduce it every now and then, and only in a quite complicated code base. Just logging it here in case it rings a b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | reinhrst |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width