René's URL Explorer Experiment


Title: New semantic analyzer: Clean-up logic for classes in functions · Issue #6422 · python/mypy · GitHub

Open Graph Title: New semantic analyzer: Clean-up logic for classes in functions · Issue #6422 · python/mypy

X Title: New semantic analyzer: Clean-up logic for classes in functions · Issue #6422 · python/mypy

Description: While working on #6421 I looked again at logic for storing symbols for local (function- or method-level) classes in prepare_class_def(). The logic is too ad-hoc and needs to be cleaned up. Here are some points that should be fixed: defn....

Open Graph Description: While working on #6421 I looked again at logic for storing symbols for local (function- or method-level) classes in prepare_class_def(). The logic is too ad-hoc and needs to be cleaned up. Here are...

X Description: While working on #6421 I looked again at logic for storing symbols for local (function- or method-level) classes in prepare_class_def(). The logic is too ad-hoc and needs to be cleaned up. Here are...

Opengraph URL: https://github.com/python/mypy/issues/6422

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"New semantic analyzer: Clean-up logic for classes in functions","articleBody":"While working on https://github.com/python/mypy/pull/6421 I looked again at logic for storing symbols for local (function- or method-level) classes in `prepare_class_def()`. The logic is too ad-hoc and needs to be cleaned up. Here are some points that should be fixed:\r\n* `defn.fullname` and `info.fullname()` should always coincide\r\n* `info.fullname()` prefix should coincide with the symbol table where the info is actually stored (for serialization)\r\n* things should work for double nested classes\r\n* things should work in fine-grained mode\r\n\r\nI think the logic should be as following. Consider this example:\r\n```python\r\nclass Out:\r\n    def meth(self) -> None:\r\n        class In:\r\n            def meth(self) -> None:\r\n                class C: pass\r\n```\r\nThe class `C` should be stored in its local namespace under name `'C'`. In addition it should be stored in the namespace of `__main__.Out` under name `'C@5'`. `info.fullname()` and `defn.fullname` should be both `'__main__.Out.C@5'`.","author":{"url":"https://github.com/ilevkivskyi","@type":"Person","name":"ilevkivskyi"},"datePublished":"2019-02-17T19:25:20Z","url":"https://github.com/python/mypy/issues/6422"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2739c43b-175d-01cd-c95f-44f4a6a15f6b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD852:C5FC2:184A472:200D284:6B002573
html-safe-nonce2a94037143fcad0fff15d32f8bd5e8f063774a42595fb406bf534f2c46f6f0ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODUyOkM1RkMyOjE4NEE0NzI6MjAwRDI4NDo2QjAwMjU3MyIsInZpc2l0b3JfaWQiOiI2MTM5MDc2ODE5OTAwNDQxOTcxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdd10bcb7cf88e1f14f9a4b43fc1c46328bf729a2b58ea33d9b0e4d198d5a6249
hovercard-subject-tagissue:411224646
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/6422/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a6bd84d60d8d91f72b8dcd0e05e8b88a2e2cfbe8a511c041787b74326ee1bc26/python/mypy/issues/6422
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a6bd84d60d8d91f72b8dcd0e05e8b88a2e2cfbe8a511c041787b74326ee1bc26/python/mypy/issues/6422
og:image:altWhile working on #6421 I looked again at logic for storing symbols for local (function- or method-level) classes in prepare_class_def(). The logic is too ad-hoc and needs to be cleaned up. Here are...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/6422#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6422
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6422
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/6422
Reloadhttps://github.com/python/mypy/issues/6422
Reloadhttps://github.com/python/mypy/issues/6422
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6422
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6422
#21478https://github.com/python/mypy/pull/21478
New semantic analyzer: Clean-up logic for classes in functionshttps://github.com/python/mypy/issues/6422#top
#21478https://github.com/python/mypy/pull/21478
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
semantic-analyzerProblems that happen during semantic analysishttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22semantic-analyzer%22
topic-incrementalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-incremental%22
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Feb 17, 2019https://github.com/python/mypy/issues/6422#issue-411224646
#6421https://github.com/python/mypy/pull/6421
ilevkivskyihttps://github.com/ilevkivskyi
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
semantic-analyzerProblems that happen during semantic analysishttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22semantic-analyzer%22
on Feb 17, 2019https://github.com/python/mypy/issues/6422#event-2144852479
ilevkivskyihttps://github.com/ilevkivskyi
on Feb 19, 2019https://github.com/python/mypy/issues/6422#event-2147499886
ilevkivskyihttps://github.com/ilevkivskyi
on Mar 15, 2019https://github.com/python/mypy/issues/6422#event-2207712189
New semantic analyzer: Make assignment analysis logic more straightfo…https://github.com/python/mypy/commit/5d52eac9662abe6efb3f40479463dbfe1b0d13d4
5d52eachttps://github.com/python/mypy/commit/5d52eac9662abe6efb3f40479463dbfe1b0d13d4
ilevkivskyihttps://github.com/ilevkivskyi
on Dec 9, 2019https://github.com/python/mypy/issues/6422#event-2866790497
https://github.com/MatthieuDartiailh
MatthieuDartiailhhttps://github.com/MatthieuDartiailh
on May 25, 2020https://github.com/python/mypy/issues/6422#issuecomment-633695330
#7281https://github.com/python/mypy/issues/7281
https://github.com/MatthieuDartiailh
MatthieuDartiailhhttps://github.com/MatthieuDartiailh
on Jun 4, 2020https://github.com/python/mypy/issues/6422#issuecomment-638530695
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jun 8, 2020https://github.com/python/mypy/issues/6422#issuecomment-640610946
https://github.com/MatthieuDartiailh
MatthieuDartiailhhttps://github.com/MatthieuDartiailh
on Jun 8, 2020https://github.com/python/mypy/issues/6422#issuecomment-640674777
@JukkaLhttps://github.com/JukkaL
https://github.com/MatthieuDartiailh
MatthieuDartiailhhttps://github.com/MatthieuDartiailh
on Jun 10, 2020https://github.com/python/mypy/issues/6422#issuecomment-642318850
05571b1https://github.com/python/mypy/commit/05571b17a29ef83708ffaa02756e32e60621f69f
patrick91https://github.com/patrick91
on Nov 23, 2021https://github.com/python/mypy/issues/6422#event-5663587841
Only check mypy on main codebasehttps://github.com/mcsheehan/strawberry/commit/3bf7b2c1fd2d8f17fd6b6b839c88fea5597969f0
3bf7b2chttps://github.com/mcsheehan/strawberry/commit/3bf7b2c1fd2d8f17fd6b6b839c88fea5597969f0
ilevkivskyihttps://github.com/ilevkivskyi
topic-incrementalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-incremental%22
on May 12, 2026https://github.com/python/mypy/issues/6422#event-25455850877
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#21478https://github.com/python/mypy/pull/21478
on May 23, 2026https://github.com/python/mypy/issues/6422#event-25873140166
ilevkivskyihttps://github.com/ilevkivskyi
on May 23, 2026https://github.com/python/mypy/issues/6422#event-25873140206
Clean-up classes nested in functions (#21478)https://github.com/python/mypy/commit/37ee4323e574668c083c5b4d9d1f272591e3a3aa
#21478https://github.com/python/mypy/pull/21478
37ee432https://github.com/python/mypy/commit/37ee4323e574668c083c5b4d9d1f272591e3a3aa
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/6422
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/6422
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
semantic-analyzerProblems that happen during semantic analysishttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22semantic-analyzer%22
topic-incrementalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-incremental%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.