René's URL Explorer Experiment


Title: Unintended consequences of eliminating promotions with isinstance? · Issue #6180 · python/mypy · GitHub

Open Graph Title: Unintended consequences of eliminating promotions with isinstance? · Issue #6180 · python/mypy

X Title: Unintended consequences of eliminating promotions with isinstance? · Issue #6180 · python/mypy

Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Open Graph Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

X Description: Optional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.

Opengraph URL: https://github.com/python/mypy

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Unintended consequences of eliminating promotions with isinstance?","articleBody":"Previously, the following code:\r\n```\r\ndef foo(x):\r\n    # type: (unicode) -> None\r\n    if isinstance(x, str):\r\n        reveal_type(x)\r\n    else:\r\n        reveal_type(x)\r\n```\r\nwould emit the expected types (str, unicode) in each branch\r\nPost #6114, which removed the use of promotions when doing isinstance,\r\nit only emits that the type is unicode and skips checking the first branch.\r\n\r\nIs this bad? Should we be doing something else? Obviously str is not really a subtype of unicode, but there are a lot of places where things declared unicode can actually be str.\r\n\r\nI think the intention with the first fix was to mostly to fix Union-related issues, so maybe we need a special case for non-unions? Argh.\r\n\r\nThoughts?","author":{"url":"https://github.com/msullivan","@type":"Person","name":"msullivan"},"datePublished":"2019-01-11T01:26:49Z","url":"https://github.com/python/mypy/issues/6180"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/issues/:id(.:format)
route-controllerissues
route-actionshow
fetch-noncev2:ae6e026f-6512-a9a8-0270-63d555f18513
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idED14:1833B7:2846E1D:36B6F80:6B004529
html-safe-noncead73e3bb701e74733b248080bed5cae2940e7fbd0b5563e0114431a64e65d603
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDE0OjE4MzNCNzoyODQ2RTFEOjM2QjZGODA6NkIwMDQ1MjkiLCJ2aXNpdG9yX2lkIjoiNjc5Mzk2OTA0MzczNzk1MzU3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4a4f3e65e75eff6e7e46b234639c861789fe9933dad79b7bd66228c5fceccf99
hovercard-subject-tagrepository:7053637
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///issues/show
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/mypy/issues/6180
twitter:imagehttps://opengraph.githubassets.com/f79ae5636353a0db17350af0a02700f2e9c3bbcf096f9450bf0c369c77cd1022/python/mypy
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f79ae5636353a0db17350af0a02700f2e9c3bbcf096f9450bf0c369c77cd1022/python/mypy
og:image:altOptional static typing for Python. Contribute to python/mypy development by creating an account on GitHub.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-cache
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/6180#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6180
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6180
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fissues%2Fshow&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/6180
Reloadhttps://github.com/python/mypy/issues/6180
Reloadhttps://github.com/python/mypy/issues/6180
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6180
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6180
Unintended consequences of eliminating promotions with isinstance?https://github.com/python/mypy/issues/6180#top
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
https://github.com/msullivan
msullivanhttps://github.com/msullivan
on Jan 11, 2019https://github.com/python/mypy/issues/6180#issue-398090694
#6114https://github.com/python/mypy/pull/6114
msullivanhttps://github.com/msullivan
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
on Jan 11, 2019https://github.com/python/mypy/issues/6180#event-2067422279
https://github.com/msullivan
msullivanhttps://github.com/msullivan
on Jan 11, 2019https://github.com/python/mypy/issues/6180#issuecomment-453333800
#6130https://github.com/python/mypy/issues/6130
https://github.com/msullivan
msullivanhttps://github.com/msullivan
on Jan 11, 2019https://github.com/python/mypy/issues/6180#issuecomment-453333882
@Michael0x2ahttps://github.com/Michael0x2a
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Jan 11, 2019https://github.com/python/mypy/issues/6180#issuecomment-453337197
#6060https://github.com/python/mypy/issues/6060
https://github.com/msullivan
msullivanhttps://github.com/msullivan
on Jan 11, 2019https://github.com/python/mypy/issues/6180#issuecomment-453338642
Michael0x2ahttps://github.com/Michael0x2a
on Jan 11, 2019https://github.com/python/mypy/issues/6180#event-2067455802
Re-enable promtions in isinstance checkshttps://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555
ab7f641https://github.com/Michael0x2a/mypy/commit/ab7f6412bf958d924128d41f8f2a2290bfcd9555
Re-enable promotions in isinstance checks (#6181)https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
#6181https://github.com/python/mypy/pull/6181
401a4e0https://github.com/python/mypy/commit/401a4e05bb111d248bae0b892aae9c25855f2534
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jan 11, 2019https://github.com/python/mypy/issues/6180#issuecomment-453473998
#6060https://github.com/python/mypy/issues/6060
#6060https://github.com/python/mypy/issues/6060
msullivanhttps://github.com/msullivan
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 11, 2019https://github.com/python/mypy/issues/6180#event-2068958599
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/6180
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/6180
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.