René's URL Explorer Experiment


Title: Else block of `isinstance` check with promotable types has for type · Issue #6141 · python/mypy · GitHub

Open Graph Title: Else block of `isinstance` check with promotable types has for type · Issue #6141 · python/mypy

X Title: Else block of `isinstance` check with promotable types has for type · Issue #6141 · python/mypy

Description: This test case from typing import Union def asdf(val: Union[int, float]): if isinstance(val, float): reveal_type(val) else: reveal_type(val) produces: /home/msullivan/lol2.py:4: error: Revealed type is 'builtins.float' /home/msullivan/lo...

Open Graph Description: This test case from typing import Union def asdf(val: Union[int, float]): if isinstance(val, float): reveal_type(val) else: reveal_type(val) produces: /home/msullivan/lol2.py:4: error: Revealed typ...

X Description: This test case from typing import Union def asdf(val: Union[int, float]): if isinstance(val, float): reveal_type(val) else: reveal_type(val) produces: /home/msullivan/lol2.py:4: error: Revealed typ...

Opengraph URL: https://github.com/python/mypy/issues/6141

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Else block of `isinstance` check with promotable types has \u003cnothing> for type","articleBody":"This test case\r\n```\r\nfrom typing import Union\r\ndef asdf(val: Union[int, float]):\r\n    if isinstance(val, float):\r\n        reveal_type(val)\r\n    else:\r\n        reveal_type(val)\r\n```\r\nproduces:\r\n```\r\n/home/msullivan/lol2.py:4: error: Revealed type is 'builtins.float'\r\n/home/msullivan/lol2.py:6: error: Revealed type is '\u003cnothing>'\r\n```\r\nBut the type in the `else` branch ought to be `int`.\r\n\r\nPrior to  #6114, it produced\r\n```\r\n/home/msullivan/lol2.py:4: error: Revealed type is 'Union[builtins.int, builtins.float]'\r\n```\r\nwhich is of course also wrong.\r\nThe prior version produced false positives in the then branch and false negatives in the else branch, while the new version produces false positives in the else branch and works correctly in the then branch.","author":{"url":"https://github.com/msullivan","@type":"Person","name":"msullivan"},"datePublished":"2019-01-04T21:48:15Z","url":"https://github.com/python/mypy/issues/6141"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d7d6d27b-76e0-32f2-bbe6-768d77fdca93
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id86C6:245A38:DCD42A:12974BC:6B005801
html-safe-nonceb0d5207a86a077e7f679e037029edf204d93061929ca757d793fd23cdfef17bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkM2OjI0NUEzODpEQ0Q0MkE6MTI5NzRCQzo2QjAwNTgwMSIsInZpc2l0b3JfaWQiOiI1ODEzODYxMDI0MzY4OTczODI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac83b2a0b71ae491fca118dc299ea4122d08b2c5e5b41f9876afc66fbc230fe916
hovercard-subject-tagissue:396078940
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/6141/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ad998f9fc85637946bc5e22b4c4953290a7df72cae11f4e7576e88ece95356f7/python/mypy/issues/6141
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad998f9fc85637946bc5e22b4c4953290a7df72cae11f4e7576e88ece95356f7/python/mypy/issues/6141
og:image:altThis test case from typing import Union def asdf(val: Union[int, float]): if isinstance(val, float): reveal_type(val) else: reveal_type(val) produces: /home/msullivan/lol2.py:4: error: Revealed typ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemsullivan
hostnamegithub.com
expected-hostnamegithub.com
None29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeacd927ba6112e3b01ba99c762bd699a4a4f5df7
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/6141#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6141
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6141
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/6141
Reloadhttps://github.com/python/mypy/issues/6141
Reloadhttps://github.com/python/mypy/issues/6141
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6141
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6141
#6142https://github.com/python/mypy/pull/6142
Else block of isinstance check with promotable types has for typehttps://github.com/python/mypy/issues/6141#top
#6142https://github.com/python/mypy/pull/6142
https://github.com/msullivan
msullivanhttps://github.com/msullivan
on Jan 4, 2019https://github.com/python/mypy/issues/6141#issue-396078940
#6114https://github.com/python/mypy/pull/6114
msullivanhttps://github.com/msullivan
on Jan 4, 2019https://github.com/python/mypy/issues/6141#event-2055446242
Disable promotions when restricting types in isinstance checkshttps://github.com/python/mypy/commit/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
https://docs.github.com/articles/closing-issues-via-commit-messages
79f14b0https://github.com/python/mypy/commit/79f14b0ada3f214089fd42578a8b6c851f3c6f9f
msullivanhttps://github.com/msullivan
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6142https://github.com/python/mypy/pull/6142
on Jan 4, 2019https://github.com/python/mypy/issues/6141#event-2055477343
msullivanhttps://github.com/msullivan
on Jan 4, 2019https://github.com/python/mypy/issues/6141#event-2055477406
Disable promotions when restricting types in isinstance checks (#6142)https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9
#6142https://github.com/python/mypy/pull/6142
https://docs.github.com/articles/closing-issues-via-commit-messages
103f5f3https://github.com/python/mypy/commit/103f5f3ec3fcc8fba429edcc4ee61c1370153ff9
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/6141
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/6141
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.