René's URL Explorer Experiment


Title: Crash with star imports and new file in the build · Issue #6110 · python/mypy · GitHub

Open Graph Title: Crash with star imports and new file in the build · Issue #6110 · python/mypy

X Title: Crash with star imports and new file in the build · Issue #6110 · python/mypy

Description: This test case: [case testAddedSubStar] # cmd: mypy -m a pack pack.mod b # cmd2: mypy -m other [file a.py] from pack import * [file pack/__init__.py] [file pack/mod.py] [file b.py] import pack.mod [file other.py] import a [out] [out2] cr...

Open Graph Description: This test case: [case testAddedSubStar] # cmd: mypy -m a pack pack.mod b # cmd2: mypy -m other [file a.py] from pack import * [file pack/__init__.py] [file pack/mod.py] [file b.py] import pack.mod ...

X Description: This test case: [case testAddedSubStar] # cmd: mypy -m a pack pack.mod b # cmd2: mypy -m other [file a.py] from pack import * [file pack/__init__.py] [file pack/mod.py] [file b.py] import pack.mod ...

Opengraph URL: https://github.com/python/mypy/issues/6110

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash with star imports and new file in the build","articleBody":"This test case:\r\n```\r\n[case testAddedSubStar]\r\n# cmd: mypy -m a pack pack.mod b\r\n# cmd2: mypy -m other\r\n[file a.py]\r\nfrom pack import *\r\n[file pack/__init__.py]\r\n[file pack/mod.py]\r\n[file b.py]\r\nimport pack.mod\r\n[file other.py]\r\nimport a\r\n[out]\r\n[out2]\r\n```\r\ncrashes with\r\n```\r\n/Users/ilevkivskyi/src/mypy/mypy/build.py:157: in build\r\n    result = _build(sources, options, alt_lib_path, flush_errors, fscache)\r\n/Users/ilevkivskyi/src/mypy/mypy/build.py:207: in _build\r\n    graph = dispatch(sources, manager)\r\n/Users/ilevkivskyi/src/mypy/mypy/build.py:2214: in dispatch\r\n    process_graph(graph, manager)\r\n/Users/ilevkivskyi/src/mypy/mypy/build.py:2505: in process_graph\r\n    process_fresh_modules(graph, prev_scc, manager)\r\n/Users/ilevkivskyi/src/mypy/mypy/build.py:2591: in process_fresh_modules\r\n    graph[id].fix_cross_refs()\r\n/Users/ilevkivskyi/src/mypy/mypy/build.py:1598: in fix_cross_refs\r\n    self.options.use_fine_grained_cache)\r\n/Users/ilevkivskyi/src/mypy/mypy/fixup.py:25: in fixup_module\r\n    node_fixer.visit_symbol_table(tree.names)\r\n/Users/ilevkivskyi/src/mypy/mypy/fixup.py:77: in visit_symbol_table\r\n    self.quick_and_dirty)\r\n/Users/ilevkivskyi/src/mypy/mypy/fixup.py:261: in lookup_qualified_stnode\r\n    return lookup_fully_qualified(name, modules, raise_on_missing=not quick_and_dirty)\r\n/Users/ilevkivskyi/src/mypy/mypy/lookup.py:47: in lookup_fully_qualified\r\n    assert key in names, \"Cannot find %s for %s\" % (key, name)\r\nAssertionError: Cannot find mod for pack.mod\r\n```\r\nI think this is high priority because the crash affects users who adds new files to typed builds in existing code bases. There must be another way to reproduce this where all files from first command are also present in the second, but I didn't find a simple version of it.\r\n\r\nAnyway, the crux seems to be the interference between lack of dependencies from star import (that can also import modules), and `add_submodules_to_parent_modules()`.","author":{"url":"https://github.com/ilevkivskyi","@type":"Person","name":"ilevkivskyi"},"datePublished":"2018-12-27T19:58:38Z","url":"https://github.com/python/mypy/issues/6110"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3ed07613-f6ec-502f-86e1-7843356ce68a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDBB4:102136:2C45BD:3B63CF:6B0025C7
html-safe-nonced6d1ec7c9c3b611572a78c269874ea04ef3543ab62cc8b09cdd4614c60882640
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkI0OjEwMjEzNjoyQzQ1QkQ6M0I2M0NGOjZCMDAyNUM3IiwidmlzaXRvcl9pZCI6IjY5MjUxNTI4MzI2MDk4NTQ5MTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac676b72e4f9d53f2440198b3c55ac645d2b56efc3f8cc67009dfcf82e9717ab56
hovercard-subject-tagissue:394476816
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/6110/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6a145f2e326efc4957613d4eb244b2bbb89985330bc0c9f0bc059b931716ca05/python/mypy/issues/6110
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6a145f2e326efc4957613d4eb244b2bbb89985330bc0c9f0bc059b931716ca05/python/mypy/issues/6110
og:image:altThis test case: [case testAddedSubStar] # cmd: mypy -m a pack pack.mod b # cmd2: mypy -m other [file a.py] from pack import * [file pack/__init__.py] [file pack/mod.py] [file b.py] import pack.mod ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/6110#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6110
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6110
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/6110
Reloadhttps://github.com/python/mypy/issues/6110
Reloadhttps://github.com/python/mypy/issues/6110
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6110
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6110
#6179https://github.com/python/mypy/pull/6179
Crash with star imports and new file in the buildhttps://github.com/python/mypy/issues/6110#top
#6179https://github.com/python/mypy/pull/6179
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Dec 27, 2018https://github.com/python/mypy/issues/6110#issue-394476816
ilevkivskyihttps://github.com/ilevkivskyi
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
on Dec 27, 2018https://github.com/python/mypy/issues/6110#event-2046370477
msullivanhttps://github.com/msullivan
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6179https://github.com/python/mypy/pull/6179
on Jan 11, 2019https://github.com/python/mypy/issues/6110#event-2067500854
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/6110
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/6110
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.