René's URL Explorer Experiment


Title: mypy fails to narrow Union[float,int] to float after isinstance(x, float) · Issue #6060 · python/mypy · GitHub

Open Graph Title: mypy fails to narrow Union[float,int] to float after isinstance(x, float) · Issue #6060 · python/mypy

X Title: mypy fails to narrow Union[float,int] to float after isinstance(x, float) · Issue #6060 · python/mypy

Description: Mypy fails to typecheck the following valid code: from typing import Union def maybe_convert_to_int(x: Union[float,int]) -> Union[float,int]: '''Convert x from float to int if it can be done losslessly.''' if isinstance(x, float): # x mu...

Open Graph Description: Mypy fails to typecheck the following valid code: from typing import Union def maybe_convert_to_int(x: Union[float,int]) -> Union[float,int]: '''Convert x from float to int if it can be done lossle...

X Description: Mypy fails to typecheck the following valid code: from typing import Union def maybe_convert_to_int(x: Union[float,int]) -> Union[float,int]: '''Convert x from float to int if it can...

Opengraph URL: https://github.com/python/mypy/issues/6060

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mypy fails to narrow Union[float,int] to float after isinstance(x, float)","articleBody":"Mypy fails to typecheck the following valid code:\r\n\r\n```python\r\nfrom typing import Union\r\ndef maybe_convert_to_int(x: Union[float,int]) -> Union[float,int]:\r\n    '''Convert x from float to int if it can be done losslessly.'''\r\n    if isinstance(x, float):\r\n        # x must be a float here, so this is a legal operation, but\r\n        # mypy still thinks its type is Union[float,int]\r\n        assert isinstance(x, float)\r\n        if x.is_integer():\r\n            x = int(x)\r\n    return x\r\n```\r\n\r\nWhen I run mypy on it, I get:\r\n\r\n```\r\n$ mypy ~/temp/test_mypy.py\r\ntemp/test_mypy.py:8: error: Item \"int\" of \"Union[float, int]\" has no attribute \"is_integer\"\r\n$ python --version\r\nPython 3.7.1\r\n$ mypy --version\r\nmypy 0.650\r\n```\r\n\r\nI would expect this program to pass the type checker, since I am using `isinstance` to narrow the type to float before performing the float-specific operation `float.is_integer`. If I replace the assertion with `x = float(x)`, that satisfies the type checker.","author":{"url":"https://github.com/DarwinAwardWinner","@type":"Person","name":"DarwinAwardWinner"},"datePublished":"2018-12-12T07:32:44Z","url":"https://github.com/python/mypy/issues/6060"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:531c8034-01a9-cb32-677b-3f19b6a0efc0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEA08:1F5A:168212:246394:6B00302B
html-safe-nonce10cbfcb8d8ed381eb6dea69786f820c9c6e60ee9f4580c7f88e753cd9bdd7679
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTA4OjFGNUE6MTY4MjEyOjI0NjM5NDo2QjAwMzAyQiIsInZpc2l0b3JfaWQiOiIyNjk1MjAyMzE3NzQ1MDA4NjgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6eefc13c9358c324865546a82b27bdcb60fc13255d051f6f3948b91651e35be5
hovercard-subject-tagissue:390098798
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/6060/issue_layout
twitter:imagehttps://opengraph.githubassets.com/afd5aa8d2a82548e2e322daafc1ff407d6c6b9a8705a15c28194b6588bb4714d/python/mypy/issues/6060
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/afd5aa8d2a82548e2e322daafc1ff407d6c6b9a8705a15c28194b6588bb4714d/python/mypy/issues/6060
og:image:altMypy fails to typecheck the following valid code: from typing import Union def maybe_convert_to_int(x: Union[float,int]) -> Union[float,int]: '''Convert x from float to int if it can be done lossle...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDarwinAwardWinner
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/6060#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6060
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F6060
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/6060
Reloadhttps://github.com/python/mypy/issues/6060
Reloadhttps://github.com/python/mypy/issues/6060
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6060
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/6060
#13781https://github.com/python/mypy/pull/13781
#6114https://github.com/python/mypy/pull/6114
mypy fails to narrow Union[float,int] to float after isinstance(x, float)https://github.com/python/mypy/issues/6060#top
#13781https://github.com/python/mypy/pull/13781
#6114https://github.com/python/mypy/pull/6114
https://github.com/Michael0x2a
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/DarwinAwardWinner
DarwinAwardWinnerhttps://github.com/DarwinAwardWinner
on Dec 12, 2018https://github.com/python/mypy/issues/6060#issue-390098798
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Dec 12, 2018https://github.com/python/mypy/issues/6060#issuecomment-446547239
ilevkivskyihttps://github.com/ilevkivskyi
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
on Dec 12, 2018https://github.com/python/mypy/issues/6060#event-2021169065
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Dec 12, 2018https://github.com/python/mypy/issues/6060#issuecomment-446547599
@Michael0x2ahttps://github.com/Michael0x2a
https://github.com/DarwinAwardWinner
DarwinAwardWinnerhttps://github.com/DarwinAwardWinner
on Dec 12, 2018https://github.com/python/mypy/issues/6060#issuecomment-446634241
DarwinAwardWinnerhttps://github.com/DarwinAwardWinner
on Dec 12, 2018https://github.com/python/mypy/issues/6060#event-2022015660
Replace NumericType with floathttps://github.com/DarwinAwardWinner/roll/commit/0576699104ca96281e6bc867aab3d535d2a0bdb2
0576699https://github.com/DarwinAwardWinner/roll/commit/0576699104ca96281e6bc867aab3d535d2a0bdb2
Michael0x2ahttps://github.com/Michael0x2a
on Dec 12, 2018https://github.com/python/mypy/issues/6060#event-2022167552
Michael0x2ahttps://github.com/Michael0x2a
on Dec 29, 2018https://github.com/python/mypy/issues/6060#event-2047859055
Disable promotions in isinstance checkshttps://github.com/Michael0x2a/mypy/commit/f7069cacaa55bf7163e4cb32e02c861a3bc30d26
f7069cahttps://github.com/Michael0x2a/mypy/commit/f7069cacaa55bf7163e4cb32e02c861a3bc30d26
Michael0x2ahttps://github.com/Michael0x2a
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#6114https://github.com/python/mypy/pull/6114
on Dec 31, 2018https://github.com/python/mypy/issues/6060#event-2048701105
Michael0x2ahttps://github.com/Michael0x2a
on Dec 31, 2018https://github.com/python/mypy/issues/6060#event-2048701141
Disable promotions in isinstance checks (#6114)https://github.com/python/mypy/commit/51e34fa4e99de909940390c36120bd3bad24f142
#6114https://github.com/python/mypy/pull/6114
51e34fahttps://github.com/python/mypy/commit/51e34fa4e99de909940390c36120bd3bad24f142
msullivanhttps://github.com/msullivan
on Jan 11, 2019https://github.com/python/mypy/issues/6060#event-2067506204
https://github.com/GregHilston
GregHilstonhttps://github.com/GregHilston
on Aug 26, 2019https://github.com/python/mypy/issues/6060#issuecomment-525025173
https://github.com/syastrov
syastrovhttps://github.com/syastrov
on Nov 14, 2019https://github.com/python/mypy/issues/6060#issuecomment-553823048
AlexWaygoodhttps://github.com/AlexWaygood
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on Mar 27, 2022https://github.com/python/mypy/issues/6060#event-6313501972
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#13781https://github.com/python/mypy/pull/13781
on Oct 3, 2022https://github.com/python/mypy/issues/6060#event-7506522399
ilevkivskyihttps://github.com/ilevkivskyi
on Oct 3, 2022https://github.com/python/mypy/issues/6060#event-7506522847
Ignore promotions when simplifying unions (#13781)https://github.com/python/mypy/commit/08c566cfa8a3e9cbf0bbad1db3cdcdff7d1ad2f2
#13781https://github.com/python/mypy/pull/13781
https://docs.github.com/articles/closing-issues-via-commit-messages
08c566chttps://github.com/python/mypy/commit/08c566cfa8a3e9cbf0bbad1db3cdcdff7d1ad2f2
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/6060
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/6060
Michael0x2ahttps://github.com/Michael0x2a
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.