René's URL Explorer Experiment


Title: Idea: short-circuit analysis with `if : return` · Issue #5964 · python/mypy · GitHub

Open Graph Title: Idea: short-circuit analysis with `if : return` · Issue #5964 · python/mypy

X Title: Idea: short-circuit analysis with `if : return` · Issue #5964 · python/mypy

Description: Hey all, I'm adding OS-specific typechecking to a large Python app, and we have a fair number of files and functions that mix OS versions. Currently, mypy only does limited analysis with platform/version/constants to figure out which lin...

Open Graph Description: Hey all, I'm adding OS-specific typechecking to a large Python app, and we have a fair number of files and functions that mix OS versions. Currently, mypy only does limited analysis with platform/v...

X Description: Hey all, I'm adding OS-specific typechecking to a large Python app, and we have a fair number of files and functions that mix OS versions. Currently, mypy only does limited analysis with platfo...

Opengraph URL: https://github.com/python/mypy/issues/5964

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Idea: short-circuit analysis with `if \u003cplatform-check>: return`","articleBody":"Hey all,\r\n\r\nI'm adding OS-specific typechecking to a large Python app, and we have a fair number of files and functions that mix OS versions. Currently, mypy only does limited analysis with platform/version/constants to figure out which lines it shouldn't check. With that limited analysis, it's possible to add OS-specific typechecking to the app, but it'll make the code a bit messier.\r\n\r\nI'd like to get your feedback on two ideas that would make adding OS-specific typechecking easier.\r\n\r\n1. For `if` statements where the expression is a mypy-constant, short-circuit if there's a `return` statement one-level deep in the body of the `if`. (Currently, the inner bodies of the if are conditionally checked, and `return` doesn't short-circuit checking.)\r\n\r\nE.g.\r\n```python\r\n# flags: --always-false=IS_WINDOWS\r\nif IS_WINDOWS:\r\n    import win_specific_import\r\n\r\ndef some_fun_broken() -> int:\r\n    if not IS_WINDOWS:\r\n        return 1 # checked\r\n    # The rest of this function is analyzed even though we returned above. \r\n\r\n    # Blows up since `win_specific_import` isn't defined\r\n    return win_specific_import.something()\r\n\r\ndef some_fun_fixed() -> int:\r\n    if not IS_WINDOWS:\r\n        return 1  # checked\r\n    else:\r\n        # Not analyzed because this is in the `else` part of the `if` statement\r\n        return win_specific_import.something()  # Works\r\n```\r\n\r\nWe use the `if not IS_WINDOWS: return` pattern a fair amount in our codebase, and it would be nice if mypy supported that.\r\n\r\nI'm not sure how we'd implement that in mypy, though. Maybe we can scan for a `return` one-level deep in `if` statement bodies which have a mypy-constant expression and mark the rest of the function as unreachable.\r\n\r\n2. Make mypy-constant asserts also ignore function bodies. This would be an extension of #5308. E.g.\r\n\r\n```python\r\n# flags: --always-false=IS_WINDOWS\r\n\r\nif IS_WINDOWS:\r\n    import win_specific_import\r\n\r\ndef invalid_win_specific_function() -> bool:\r\n    assert IS_WINDOWS\r\n    return win_specific_import.some_func()  # This blows up\r\n\r\nif IS_WINDOWS:\r\n    def valid_win_specific_function() -> bool:\r\n        return win_specific_import.some_func()\r\n```\r\n\r\nIt would be convenient if we ignored the rest of the function body if the first statement in it is a mypy-constant assert. I don't think we'd want to look for asserts elsewhere in the function block, though, even though that would make it a magical special-case.\r\n\r\nAny thoughts on the above ideas?","author":{"url":"https://github.com/samertm","@type":"Person","name":"samertm"},"datePublished":"2018-11-28T03:30:27Z","url":"https://github.com/python/mypy/issues/5964"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:da9f2850-fc2b-1f43-c03a-dfe92111477a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD67E:1F7A:B21B87:F1FD6C:6AFFFAD2
html-safe-nonce0e4d6f28c89b1dfbd5e721769be5c8775948d4b92124ab6ed247b08e44d36a09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjdFOjFGN0E6QjIxQjg3OkYxRkQ2Qzo2QUZGRkFEMiIsInZpc2l0b3JfaWQiOiIyMTQ5MDIzNTQwNTc2MjQyNzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6defba725458333f3f06482893229675fcfad7582739c7390115f4d56bea02d6
hovercard-subject-tagissue:385085868
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/5964/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e9551ee756fd00adf052c38b031b6699409ee43ef634fa603abb07ed47c3e3af/python/mypy/issues/5964
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e9551ee756fd00adf052c38b031b6699409ee43ef634fa603abb07ed47c3e3af/python/mypy/issues/5964
og:image:altHey all, I'm adding OS-specific typechecking to a large Python app, and we have a fair number of files and functions that mix OS versions. Currently, mypy only does limited analysis with platform/v...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesamertm
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/5964#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5964
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5964
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/5964
Reloadhttps://github.com/python/mypy/issues/5964
Reloadhttps://github.com/python/mypy/issues/5964
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5964
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5964
Idea: short-circuit analysis with if : returnhttps://github.com/python/mypy/issues/5964#top
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
https://github.com/samertm
samertmhttps://github.com/samertm
on Nov 28, 2018https://github.com/python/mypy/issues/5964#issue-385085868
Idea: allow assert with platform or version check at top of file #5308https://github.com/python/mypy/issues/5308
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Nov 28, 2018https://github.com/python/mypy/issues/5964#issuecomment-442313423
#5894https://github.com/python/mypy/pull/5894
#5308https://github.com/python/mypy/issues/5308
AlexWaygoodhttps://github.com/AlexWaygood
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
on Apr 3, 2022https://github.com/python/mypy/issues/5964#event-6358330512
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/5964
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/5964
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.