Title: Importing packages can poison the `mypy` cache. · Issue #5534 · python/mypy · GitHub
Open Graph Title: Importing packages can poison the `mypy` cache. · Issue #5534 · python/mypy
X Title: Importing packages can poison the `mypy` cache. · Issue #5534 · python/mypy
Description: Ok -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hinting), but I'm cross-posting this issue to both...
Open Graph Description: Ok -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hinting), ...
X Description: Ok -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hintin...
Opengraph URL: https://github.com/python/mypy/issues/5534
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Importing packages can poison the `mypy` cache.","articleBody":"Ok -- this is a weird one, but I think I've got it down to the smallest possible repro.\r\n\r\nI first noticed this issue with the `aiohttp` library as of version `3.4.0` (when they introduced type-hinting), but I'm cross-posting this issue to both projects since the issue seems to run deeper than just a library issue. Importing the `aiohttp` library, even if it is unused, causes the `mypy` cache to occasionally get poisoned.\r\n\r\nHere's the repro case:\r\n```\r\nimport aiohttp\r\ndef trigger() -> dict:\r\n return 'foo'\r\n```\r\n\r\nRunning `python -m mypy repro.py` against this file works as expected (eg. returns an incompatible return type error). Replacing the `-> dict` with `-> str` throws the following assertion (attached at bottom of report) on re-running the type check. Note that this holds true in the opposite direction -- if we begin with `-> str`, the first typecheck is successful, but replacing `-> str` with `-> dict` causes the same assertion error. Either way, the situation can only be resolved by clearing the `.mypy_cache` folder, at which point `mypy` acts as expected once more.\r\n\r\nInterestingly, removing the `aiohttp` import prevents this poisoning from occurring. In addition, removing the import once the cache is poisoned also fixes the issue.\r\n\r\nI speculate there are two issues here, one with `aiohttp` and one with `mypy`:\r\n- `aiohttp` seems to have some weirdness going on in their type hinting\r\n- regardless of what a library does, the above repro case should not cause `mypy` issues when dealing only with stdlib types.\r\n\r\nError Trace:\r\n```\r\nTraceback (most recent call last):\r\n File \"/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py\", line 193, in _run_module_as_main\r\n \"__main__\", mod_spec)\r\n File \"/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py\", line 85, in _run_code\r\n exec(code, run_globals)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/__main__.py\", line 11, in \u003cmodule>\r\n main(None)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/main.py\", line 91, in main\r\n res = type_check_only(sources, bin_dir, options, flush_errors, fscache) # noqa\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/main.py\", line 148, in type_check_only\r\n fscache=fscache)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 177, in build\r\n flush_errors, fscache)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 350, in _build\r\n graph = dispatch(sources, manager)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 2560, in dispatch\r\n process_graph(graph, manager)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 2846, in process_graph\r\n process_fresh_modules(graph, prev_scc, manager)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 2932, in process_fresh_modules\r\n graph[id].fix_cross_refs()\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 1975, in fix_cross_refs\r\n self.options.use_fine_grained_cache)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 24, in fixup_module\r\n node_fixer.visit_symbol_table(tree.names)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 89, in visit_symbol_table\r\n value.node.accept(self)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/nodes.py\", line 2539, in accept\r\n return visitor.visit_type_alias(self)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 135, in visit_type_alias\r\n a.target.accept(self.type_fixer)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/types.py\", line 511, in accept\r\n return visitor.visit_instance(self)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 149, in visit_instance\r\n inst.type = lookup_qualified_typeinfo(self.modules, type_ref, self.quick_and_dirty)\r\n File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 239, in lookup_qualified_typeinfo\r\n assert quick_and_dirty, \"Should never get here in normal mode\"\r\nAssertionError: Should never get here in normal mode\r\n```\r\n\r\nVersions:\r\n```\r\n(venv) kevin@box ~/c/mypy-bug » python --version\r\nPython 3.7.0\r\n(venv) kevin@box ~/c/mypy-bug » python -m mypy --version\r\nmypy 0.620\r\n(venv) kevin@box ~/c/mypy-bug » python -m pip freeze | grep aiohttp\r\naiohttp==3.4.0\r\n```","author":{"url":"https://github.com/TheKevJames","@type":"Person","name":"TheKevJames"},"datePublished":"2018-08-28T20:05:01Z","url":"https://github.com/python/mypy/issues/5534"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bcbfc45b-c111-4a78-e1c8-7988336800c1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D1C0:1EF2:277D37:36C2E4:6B0007E6 |
| html-safe-nonce | bc3d239ab9a54970003a61c591a9ba33516266f2b5ef18187cb2a571e9608134 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUMwOjFFRjI6Mjc3RDM3OjM2QzJFNDo2QjAwMDdFNiIsInZpc2l0b3JfaWQiOiI2MzUzMzE2MjYwMTE3MjM3NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1c87f1bfce9dcc4d85a0e577f148050c37065cc3a83e270ce6164580c84363c1 |
| hovercard-subject-tag | issue:354883139 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/5534/issue_layout |
| twitter:image | https://opengraph.githubassets.com/4730ec71c082b417c89279bd0dbdb7e8def35f142e4871040bfff2cac1bbed5f/python/mypy/issues/5534 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4730ec71c082b417c89279bd0dbdb7e8def35f142e4871040bfff2cac1bbed5f/python/mypy/issues/5534 |
| og:image:alt | Ok -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hinting), ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TheKevJames |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width