René's URL Explorer Experiment


Title: Importing packages can poison the `mypy` cache. · Issue #5534 · python/mypy · GitHub

Open Graph Title: Importing packages can poison the `mypy` cache. · Issue #5534 · python/mypy

X Title: Importing packages can poison the `mypy` cache. · Issue #5534 · python/mypy

Description: Ok -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hinting), but I'm cross-posting this issue to both...

Open Graph Description: Ok -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hinting), ...

X Description: Ok -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hintin...

Opengraph URL: https://github.com/python/mypy/issues/5534

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Importing packages can poison the `mypy` cache.","articleBody":"Ok -- this is a weird one, but I think I've got it down to the smallest possible repro.\r\n\r\nI first noticed this issue with the `aiohttp` library as of version `3.4.0` (when they introduced type-hinting), but I'm cross-posting this issue to both projects since the issue seems to run deeper than just a library issue. Importing the `aiohttp` library, even if it is unused, causes the `mypy` cache to occasionally get poisoned.\r\n\r\nHere's the repro case:\r\n```\r\nimport aiohttp\r\ndef trigger() -> dict:\r\n    return 'foo'\r\n```\r\n\r\nRunning `python -m mypy repro.py` against this file works as expected (eg. returns an incompatible return type error). Replacing the `-> dict` with `-> str` throws the following assertion (attached at bottom of report) on re-running the type check. Note that this holds true in the opposite direction -- if we begin with `-> str`, the first typecheck is successful, but replacing `-> str` with `-> dict` causes the same assertion error. Either way, the situation can only be resolved by clearing the `.mypy_cache` folder, at which point `mypy` acts as expected once more.\r\n\r\nInterestingly, removing the `aiohttp` import prevents this poisoning from occurring. In addition, removing the import once the cache is poisoned also fixes the issue.\r\n\r\nI speculate there are two issues here, one with `aiohttp` and one with `mypy`:\r\n- `aiohttp` seems to have some weirdness going on in their type hinting\r\n- regardless of what a library does, the above repro case should not cause `mypy` issues when dealing only with stdlib types.\r\n\r\nError Trace:\r\n```\r\nTraceback (most recent call last):\r\n  File \"/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py\", line 193, in _run_module_as_main\r\n    \"__main__\", mod_spec)\r\n  File \"/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py\", line 85, in _run_code\r\n    exec(code, run_globals)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/__main__.py\", line 11, in \u003cmodule>\r\n    main(None)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/main.py\", line 91, in main\r\n    res = type_check_only(sources, bin_dir, options, flush_errors, fscache)  # noqa\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/main.py\", line 148, in type_check_only\r\n    fscache=fscache)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 177, in build\r\n    flush_errors, fscache)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 350, in _build\r\n    graph = dispatch(sources, manager)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 2560, in dispatch\r\n    process_graph(graph, manager)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 2846, in process_graph\r\n    process_fresh_modules(graph, prev_scc, manager)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 2932, in process_fresh_modules\r\n    graph[id].fix_cross_refs()\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/build.py\", line 1975, in fix_cross_refs\r\n    self.options.use_fine_grained_cache)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 24, in fixup_module\r\n    node_fixer.visit_symbol_table(tree.names)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 89, in visit_symbol_table\r\n    value.node.accept(self)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/nodes.py\", line 2539, in accept\r\n    return visitor.visit_type_alias(self)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 135, in visit_type_alias\r\n    a.target.accept(self.type_fixer)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/types.py\", line 511, in accept\r\n    return visitor.visit_instance(self)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 149, in visit_instance\r\n    inst.type = lookup_qualified_typeinfo(self.modules, type_ref, self.quick_and_dirty)\r\n  File \"/Users/kevin/coding/mypy-bug/venv/lib/python3.7/site-packages/mypy/fixup.py\", line 239, in lookup_qualified_typeinfo\r\n    assert quick_and_dirty, \"Should never get here in normal mode\"\r\nAssertionError: Should never get here in normal mode\r\n```\r\n\r\nVersions:\r\n```\r\n(venv) kevin@box ~/c/mypy-bug » python --version\r\nPython 3.7.0\r\n(venv) kevin@box ~/c/mypy-bug » python -m mypy --version\r\nmypy 0.620\r\n(venv) kevin@box ~/c/mypy-bug » python -m pip freeze | grep aiohttp\r\naiohttp==3.4.0\r\n```","author":{"url":"https://github.com/TheKevJames","@type":"Person","name":"TheKevJames"},"datePublished":"2018-08-28T20:05:01Z","url":"https://github.com/python/mypy/issues/5534"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bcbfc45b-c111-4a78-e1c8-7988336800c1
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD1C0:1EF2:277D37:36C2E4:6B0007E6
html-safe-noncebc3d239ab9a54970003a61c591a9ba33516266f2b5ef18187cb2a571e9608134
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUMwOjFFRjI6Mjc3RDM3OjM2QzJFNDo2QjAwMDdFNiIsInZpc2l0b3JfaWQiOiI2MzUzMzE2MjYwMTE3MjM3NTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1c87f1bfce9dcc4d85a0e577f148050c37065cc3a83e270ce6164580c84363c1
hovercard-subject-tagissue:354883139
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/5534/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4730ec71c082b417c89279bd0dbdb7e8def35f142e4871040bfff2cac1bbed5f/python/mypy/issues/5534
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4730ec71c082b417c89279bd0dbdb7e8def35f142e4871040bfff2cac1bbed5f/python/mypy/issues/5534
og:image:altOk -- this is a weird one, but I think I've got it down to the smallest possible repro. I first noticed this issue with the aiohttp library as of version 3.4.0 (when they introduced type-hinting), ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTheKevJames
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/5534#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5534
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5534
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/5534
Reloadhttps://github.com/python/mypy/issues/5534
Reloadhttps://github.com/python/mypy/issues/5534
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5534
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5534
Importing packages can poison the mypy cache.https://github.com/python/mypy/issues/5534#top
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
https://github.com/TheKevJames
TheKevJameshttps://github.com/TheKevJames
on Aug 28, 2018https://github.com/python/mypy/issues/5534#issue-354883139
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 28, 2018https://github.com/python/mypy/issues/5534#issuecomment-416724574
https://github.com/TheKevJames
TheKevJameshttps://github.com/TheKevJames
on Aug 28, 2018https://github.com/python/mypy/issues/5534#issuecomment-416728237
@gvanrossumhttps://github.com/gvanrossum
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 28, 2018https://github.com/python/mypy/issues/5534#issuecomment-416738600
https://github.com/TheKevJames
TheKevJameshttps://github.com/TheKevJames
on Aug 28, 2018https://github.com/python/mypy/issues/5534#issuecomment-416741186
f0b26f9https://github.com/python/mypy/commit/f0b26f9e6197eeb2f755fae73c949ff01384ded3
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Aug 28, 2018https://github.com/python/mypy/issues/5534#issuecomment-416741917
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 28, 2018https://github.com/python/mypy/issues/5534#issuecomment-416743176
ilevkivskyihttps://github.com/ilevkivskyi
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
on Aug 29, 2018https://github.com/python/mypy/issues/5534#event-1815173254
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 29, 2018https://github.com/python/mypy/issues/5534#issuecomment-416908352
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 29, 2018https://github.com/python/mypy/issues/5534#issuecomment-416908927
@asvetlovhttps://github.com/asvetlov
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
on Aug 29, 2018https://github.com/python/mypy/issues/5534#issuecomment-416917700
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#5565https://github.com/python/mypy/pull/5565
on Sep 4, 2018https://github.com/python/mypy/issues/5534#event-1825683849
ilevkivskyihttps://github.com/ilevkivskyi
on Sep 4, 2018https://github.com/python/mypy/issues/5534#event-1825684009
Original node wins in case of a redefinition (especially if it is a c…https://github.com/python/mypy/commit/cd6712d68de5b4f845c87db5411cfb8a799f506d
https://docs.github.com/articles/closing-issues-via-commit-messages
cd6712dhttps://github.com/python/mypy/commit/cd6712d68de5b4f845c87db5411cfb8a799f506d
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
on Sep 4, 2018https://github.com/python/mypy/issues/5534#issuecomment-418448219
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/5534
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/5534
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.