René's URL Explorer Experiment


Title: meet.is_overlapping_types should be more relaxed for isinstance checks · Issue #5529 · python/mypy · GitHub

Open Graph Title: meet.is_overlapping_types should be more relaxed for isinstance checks · Issue #5529 · python/mypy

X Title: meet.is_overlapping_types should be more relaxed for isinstance checks · Issue #5529 · python/mypy

Description: Currently, the implementation of meet.is_overlapping_types(...) defaults to returning False when it encounters two unexpected types, and doesn't attempt to handle multiple inheritance at all. The current implementation also considers two...

Open Graph Description: Currently, the implementation of meet.is_overlapping_types(...) defaults to returning False when it encounters two unexpected types, and doesn't attempt to handle multiple inheritance at all. The c...

X Description: Currently, the implementation of meet.is_overlapping_types(...) defaults to returning False when it encounters two unexpected types, and doesn't attempt to handle multiple inheritance at all. T...

Opengraph URL: https://github.com/python/mypy/issues/5529

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"meet.is_overlapping_types should be more relaxed for isinstance checks","articleBody":"Currently, the implementation of `meet.is_overlapping_types(...)` defaults to returning False when it encounters two unexpected types, and doesn't attempt to handle multiple inheritance at all. The current implementation also considers two types like `List[A]` and `List[B]` to be non-overlapping, even though they may overlap when both lists are empty.\r\n\r\nThis behavior makes sense when `is_overlapping_types` is used to detect unsafe overload variants, but may be too restrictive/cause branches to be unexpectedly unreachable when used for isinstance checks and `if x is None` checks and the like.\r\n\r\nFor more context, see https://github.com/python/mypy/pull/5476#discussion_r211030040 and https://github.com/python/mypy/issues/3603.\r\n\r\nSome possible solutions include:\r\n\r\n1. Add a flag that makes `is_overlapping_types` default to returning True, not False. The main disadvantage here is that this would then make `is_overlapping_types` consider two unrelated types like `Type[A]` and `TypedDict[...]` to be overlapping, which seems wrong.\r\n2. Add a flag named `allow_multiple_inheritance` which makes the \"if left and right are Instances\" case just always return True. The main disadvantage here is that this may not capture every edge case we want to relax.\r\n\r\nIt may also be the case that neither solutions work and a more careful rearrangement of `is_overlapping_types` is necessary. The existing implementation of `is_overlapping_types` is designed to rule out bad combinations/normalize all types to `Instance` whenever possible, which may or may not be the correct thing to do for reachability checks.","author":{"url":"https://github.com/Michael0x2a","@type":"Person","name":"Michael0x2a"},"datePublished":"2018-08-27T15:51:42Z","url":"https://github.com/python/mypy/issues/5529"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5bd0b410-f8c4-be0f-0c49-2b73bc6e0e85
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8BB8:2AD163:1BE86CC:25B33BA:6B000547
html-safe-nonce82af947e2c939f1d0989c5d4de6c7c956ff2c090f62c9d151f91ba720fe341eb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkI4OjJBRDE2MzoxQkU4NkNDOjI1QjMzQkE6NkIwMDA1NDciLCJ2aXNpdG9yX2lkIjoiNTUzOTg2MTI1Nzg0ODM1ODIxNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac57a29c9277be913c1356ef775c46c9d9264c1a2e3f77a940707f5f9f58b8f917
hovercard-subject-tagissue:354374532
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/5529/issue_layout
twitter:imagehttps://opengraph.githubassets.com/91786eccebf9c54f7b1330f44f1c83f13478fb76216ddef0a3f017723aca9c42/python/mypy/issues/5529
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/91786eccebf9c54f7b1330f44f1c83f13478fb76216ddef0a3f017723aca9c42/python/mypy/issues/5529
og:image:altCurrently, the implementation of meet.is_overlapping_types(...) defaults to returning False when it encounters two unexpected types, and doesn't attempt to handle multiple inheritance at all. The c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/5529#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5529
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5529
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/5529
Reloadhttps://github.com/python/mypy/issues/5529
Reloadhttps://github.com/python/mypy/issues/5529
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5529
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5529
meet.is_overlapping_types should be more relaxed for isinstance checkshttps://github.com/python/mypy/issues/5529#top
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Aug 27, 2018https://github.com/python/mypy/issues/5529#issue-354374532
#5476 (comment)https://github.com/python/mypy/pull/5476#discussion_r211030040
#3603https://github.com/python/mypy/issues/3603
ilevkivskyihttps://github.com/ilevkivskyi
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Aug 28, 2018https://github.com/python/mypy/issues/5529#event-1811869493
JelleZijlstrahttps://github.com/JelleZijlstra
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
on Mar 19, 2022https://github.com/python/mypy/issues/5529#event-6270111125
AlexWaygoodhttps://github.com/AlexWaygood
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
on Aug 24, 2023https://github.com/python/mypy/issues/5529#event-10186730116
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/5529
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/5529
needs discussionhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22needs%20discussion%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
topic-reachabilityDetecting unreachable codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-reachability%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.