René's URL Explorer Experiment


Title: Clean up kludges for handling metaclasses and Type[...] in check_op_reversible · Issue #5491 · python/mypy · GitHub

Open Graph Title: Clean up kludges for handling metaclasses and Type[...] in check_op_reversible · Issue #5491 · python/mypy

X Title: Clean up kludges for handling metaclasses and Type[...] in check_op_reversible · Issue #5491 · python/mypy

Description: The current implementation for checking reversible operators contains two kludges that seem to be related to operators, metaclasses, and Type[...] This call to has_member feels like it ought to be unnecessary/redundant due to the followi...

Open Graph Description: The current implementation for checking reversible operators contains two kludges that seem to be related to operators, metaclasses, and Type[...] This call to has_member feels like it ought to be ...

X Description: The current implementation for checking reversible operators contains two kludges that seem to be related to operators, metaclasses, and Type[...] This call to has_member feels like it ought to be ...

Opengraph URL: https://github.com/python/mypy/issues/5491

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Clean up kludges for handling metaclasses and Type[...] in check_op_reversible","articleBody":"The [current implementation for checking reversible operators][0] contains two kludges that seem to be related to operators, metaclasses, and Type[...]\r\n\r\n1. This call to [has_member][1] feels like it ought to be unnecessary/redundant due to the following `analyze_member_access` -- but removing it causes pythoneval's [OpMetaclassAccess](https://github.com/python/mypy/blob/master/test-data/unit/pythoneval.test#L1159) test case to fail.\r\n\r\n    (Note: if you remove just that call, you also need to add in a `elif isinstance(member, AnyTyp): return None` after calling `analyze_member_access`)\r\n\r\n2. If the reversible operators logic was unable to find a matching operator, it just [tries calling `check_call` on the name directly][2] to get back some generic error message. It seems as if this call ought to always return an error message, but sometimes it surprisingly will not. E.g. see the [TypeTypeComparisonWorks](https://github.com/python/mypy/blob/master/test-data/unit/check-classes.test#L3251) tests in check-classes -- adding an `assert local_errors.is_errors()` causes that test case to crash.\r\n\r\n    This feels related to the first TODO in some way -- either we're not handling operators + metaclasses + Type directly, or there are some weird shenanigans happening due to `Any`...\r\n\r\nFor additional context, see https://github.com/python/mypy/issues/5136 and https://github.com/python/mypy/pull/1806.\r\n\r\n  [0]:https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L1848\r\n  [1]: https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L1879\r\n  [2]: https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L2020","author":{"url":"https://github.com/Michael0x2a","@type":"Person","name":"Michael0x2a"},"datePublished":"2018-08-16T20:19:58Z","url":"https://github.com/python/mypy/issues/5491"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:7f02d5b3-80e2-f5cb-75d7-1aaedb4fd796
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD642:144E47:24F74CD:301CCB6:6AFFF26B
html-safe-nonce3e49f12f0e1be8d0185e3a98dd8f300fde4673adeebed3649bee61a29d1f2d74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjQyOjE0NEU0NzoyNEY3NENEOjMwMUNDQjY6NkFGRkYyNkIiLCJ2aXNpdG9yX2lkIjoiNjc5MTA4NDkxNzM2NDA5MzU0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb81b8bcea58b8b42fd95485f8954c1c7a5f5c09a0f3f085593d888aee63a351e
hovercard-subject-tagissue:351353825
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/5491/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bd40986b7c7ef5efc5630562d35e6001b16fc039ffa646fe6a8060cc1fa0c5ca/python/mypy/issues/5491
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd40986b7c7ef5efc5630562d35e6001b16fc039ffa646fe6a8060cc1fa0c5ca/python/mypy/issues/5491
og:image:altThe current implementation for checking reversible operators contains two kludges that seem to be related to operators, metaclasses, and Type[...] This call to has_member feels like it ought to be ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/5491#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5491
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5491
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/5491
Reloadhttps://github.com/python/mypy/issues/5491
Reloadhttps://github.com/python/mypy/issues/5491
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5491
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5491
#19250https://github.com/python/mypy/pull/19250
Clean up kludges for handling metaclasses and Type[...] in check_op_reversiblehttps://github.com/python/mypy/issues/5491#top
#19250https://github.com/python/mypy/pull/19250
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
topic-metaclasseshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-metaclasses%22
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Aug 16, 2018https://github.com/python/mypy/issues/5491#issue-351353825
current implementation for checking reversible operatorshttps://github.com/python/mypy/blob/master/mypy/checkexpr.py#L1848
has_memberhttps://github.com/python/mypy/blob/master/mypy/checkexpr.py#L1879
OpMetaclassAccesshttps://github.com/python/mypy/blob/master/test-data/unit/pythoneval.test#L1159
tries calling check_call on the name directlyhttps://github.com/python/mypy/blob/master/mypy/checkexpr.py#L2020
TypeTypeComparisonWorkshttps://github.com/python/mypy/blob/master/test-data/unit/check-classes.test#L3251
#5136https://github.com/python/mypy/issues/5136
#1806https://github.com/python/mypy/pull/1806
Michael0x2ahttps://github.com/Michael0x2a
on Aug 16, 2018https://github.com/python/mypy/issues/5491#event-1793289623
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Aug 17, 2018https://github.com/python/mypy/issues/5491#issuecomment-413952404
Michael0x2ahttps://github.com/Michael0x2a
on Aug 17, 2018https://github.com/python/mypy/issues/5491#event-1795431824
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Aug 17, 2018https://github.com/python/mypy/issues/5491#issuecomment-413970646
@elazarghttps://github.com/elazarg
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Sep 16, 2018https://github.com/python/mypy/issues/5491#issuecomment-421777156
@Michael0x2ahttps://github.com/Michael0x2a
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Sep 19, 2018https://github.com/python/mypy/issues/5491#issuecomment-422606092
@elazarghttps://github.com/elazarg
ilevkivskyihttps://github.com/ilevkivskyi
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
on Oct 16, 2019https://github.com/python/mypy/issues/5491#event-2717785073
AlexWaygoodhttps://github.com/AlexWaygood
topic-metaclasseshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-metaclasses%22
on Apr 4, 2022https://github.com/python/mypy/issues/5491#event-6360729306
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
ac511d6https://github.com/python/mypy/commit/ac511d6c4615ca45a9404ed3eb53ea7092b0aca1
on Jun 9, 2025https://github.com/python/mypy/issues/5491#event-18056808630
pullhttps://github.com/apps/pull
on Jun 9, 2025https://github.com/python/mypy/issues/5491#event-18058488653
Clean-up and move operator access to checkmember.py (python#19250)https://github.com/Dareh123/mypy/commit/ac511d6c4615ca45a9404ed3eb53ea7092b0aca1
python#19250https://github.com/python/mypy/pull/19250
ac511d6https://github.com/Dareh123/mypy/commit/ac511d6c4615ca45a9404ed3eb53ea7092b0aca1
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/5491
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/5491
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
refactoringChanging mypy's internalshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22refactoring%22
topic-metaclasseshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-metaclasses%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.