René's URL Explorer Experiment


Title: assertIsNotNone(foo) in tests is not treated the same as `assert foo is not None` · Issue #5088 · python/mypy · GitHub

Open Graph Title: assertIsNotNone(foo) in tests is not treated the same as `assert foo is not None` · Issue #5088 · python/mypy

X Title: assertIsNotNone(foo) in tests is not treated the same as `assert foo is not None` · Issue #5088 · python/mypy

Description: As part of Zulip's strict-optional effort, I had to convert a test that was using assertIsNotNone(foo) to use assert foo is not None in order to get mypy to pass. I think mypy should treat those two the same.

Open Graph Description: As part of Zulip's strict-optional effort, I had to convert a test that was using assertIsNotNone(foo) to use assert foo is not None in order to get mypy to pass. I think mypy should treat those tw...

X Description: As part of Zulip's strict-optional effort, I had to convert a test that was using assertIsNotNone(foo) to use assert foo is not None in order to get mypy to pass. I think mypy should treat thos...

Opengraph URL: https://github.com/python/mypy/issues/5088

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"assertIsNotNone(foo) in tests is not treated the same as `assert foo is not None`","articleBody":"As part of Zulip's strict-optional effort, I had to convert a test that was using `assertIsNotNone(foo)` to use `assert foo is not None` in order to get mypy to pass.  I think mypy should treat those two the same.\r\n\r\n","author":{"url":"https://github.com/timabbott","@type":"Person","name":"timabbott"},"datePublished":"2018-05-20T22:27:00Z","url":"https://github.com/python/mypy/issues/5088"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:84f66e40-f714-dfe0-5f64-d02bbfd6b8de
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA79A:1914F5:1475530:1AC4F7B:6B000AD6
html-safe-nonce61418ad1360b5381dfa909f19c2667a3c6a59a4250da01446759fd4370ef801a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNzlBOjE5MTRGNToxNDc1NTMwOjFBQzRGN0I6NkIwMDBBRDYiLCJ2aXNpdG9yX2lkIjoiMjA1NjA1NDEzNDA0OTYwNjM1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbfa1df4f4207db4792425ab3286885fddd273449c1fbf3f6ece49bf77fe446a8
hovercard-subject-tagissue:324748050
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/5088/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a203deed9c355d6049ac8226dc2812dd504d5dc80a24b299ae3f61e540eccee4/python/mypy/issues/5088
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a203deed9c355d6049ac8226dc2812dd504d5dc80a24b299ae3f61e540eccee4/python/mypy/issues/5088
og:image:altAs part of Zulip's strict-optional effort, I had to convert a test that was using assertIsNotNone(foo) to use assert foo is not None in order to get mypy to pass. I think mypy should treat those tw...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametimabbott
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/5088#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5088
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F5088
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/5088
Reloadhttps://github.com/python/mypy/issues/5088
Reloadhttps://github.com/python/mypy/issues/5088
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5088
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/5088
assertIsNotNone(foo) in tests is not treated the same as assert foo is not Nonehttps://github.com/python/mypy/issues/5088#top
https://github.com/timabbott
timabbotthttps://github.com/timabbott
on May 20, 2018https://github.com/python/mypy/issues/5088#issue-324748050
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on May 20, 2018https://github.com/python/mypy/issues/5088#issuecomment-390518079
https://github.com/elazarg
elazarghttps://github.com/elazarg
on May 20, 2018https://github.com/python/mypy/issues/5088#issuecomment-390520555
@JelleZijlstrahttps://github.com/JelleZijlstra
#4063https://github.com/python/mypy/issues/4063
https://github.com/timabbott
timabbotthttps://github.com/timabbott
on May 21, 2018https://github.com/python/mypy/issues/5088#issuecomment-390523293
https://docs.python.org/2/library/unittest.html#unittest.TestCase.debughttps://docs.python.org/2/library/unittest.html#unittest.TestCase.debug
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
on May 21, 2018https://github.com/python/mypy/issues/5088#issuecomment-390532129
#4063https://github.com/python/mypy/issues/4063
emmatypinghttps://github.com/emmatyping
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 21, 2018https://github.com/python/mypy/issues/5088#event-1636157527
https://github.com/1kastner
1kastnerhttps://github.com/1kastner
on Aug 21, 2022https://github.com/python/mypy/issues/5088#issuecomment-1221551047
https://github.com/python/typeshed/blob/master/stdlib/unittest/case.pyi#L120https://github.com/python/typeshed/blob/master/stdlib/unittest/case.pyi#L120
#4063https://github.com/python/mypy/issues/4063
ThunderKeyhttps://github.com/ThunderKey
on Oct 28, 2022https://github.com/python/mypy/issues/5088#event-7689717585
added type checks to the testshttps://github.com/ThunderKey/typeshed_client/commit/36ea6a709f4ee5bed8642d381401fe0ae04df00d
36ea6a7https://github.com/ThunderKey/typeshed_client/commit/36ea6a709f4ee5bed8642d381401fe0ae04df00d
added type checks to the testshttps://github.com/ThunderKey/typeshed_client/commit/220c29fd4cdf60ad0124082ad9a854de89abfee3
220c29fhttps://github.com/ThunderKey/typeshed_client/commit/220c29fd4cdf60ad0124082ad9a854de89abfee3
PeterJCLawhttps://github.com/PeterJCLaw
on Mar 26, 2023https://github.com/python/mypy/issues/5088#event-8847431313
Ignore (false) error mypy now findshttps://github.com/PeterJCLaw/srcomp/commit/e90354d483f1c36609b74cdfd6d5ba902daf1264
e90354dhttps://github.com/PeterJCLaw/srcomp/commit/e90354d483f1c36609b74cdfd6d5ba902daf1264
bdarnellhttps://github.com/bdarnell
on Jun 10, 2024https://github.com/python/mypy/issues/5088#event-13104408353
test: Fix some lint issues after tornadoweb#3298https://github.com/bdarnell/tornado/commit/b2f419fd5b8920bb3edcfd2a0dc26f5ec7a4adf9
tornadoweb#3298https://github.com/tornadoweb/tornado/pull/3298
b2f419fhttps://github.com/bdarnell/tornado/commit/b2f419fd5b8920bb3edcfd2a0dc26f5ec7a4adf9
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/5088
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/5088
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.