Title: mypy not inferring that variable cannot be None after assignment from dict.get · Issue #4805 · python/mypy · GitHub
Open Graph Title: mypy not inferring that variable cannot be None after assignment from dict.get · Issue #4805 · python/mypy
X Title: mypy not inferring that variable cannot be None after assignment from dict.get · Issue #4805 · python/mypy
Description: Code from typing import Dict, Optional d: Dict[str, str] = {} def foo(arg: Optional[str] = None) -> None: if arg is None: arg = d.get("a", "foo bar") print(arg.split()) Expected output None, since the code is correctly typed (afaict, at ...
Open Graph Description: Code from typing import Dict, Optional d: Dict[str, str] = {} def foo(arg: Optional[str] = None) -> None: if arg is None: arg = d.get("a", "foo bar") print(arg.split()) Expected output None, since ...
X Description: Code from typing import Dict, Optional d: Dict[str, str] = {} def foo(arg: Optional[str] = None) -> None: if arg is None: arg = d.get("a", "foo bar") print(arg.split()) Expec...
Opengraph URL: https://github.com/python/mypy/issues/4805
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"mypy not inferring that variable cannot be None after assignment from dict.get","articleBody":"##### Code\r\n\r\n```python\r\nfrom typing import Dict, Optional\r\n\r\nd: Dict[str, str] = {}\r\n\r\ndef foo(arg: Optional[str] = None) -> None:\r\n if arg is None:\r\n arg = d.get(\"a\", \"foo bar\")\r\n print(arg.split())\r\n```\r\n\r\n##### Expected output\r\n\r\nNone, since the code is correctly typed (afaict, at least)\r\n\r\n##### Actual output\r\n\r\nwith `--strict-optional`:\r\n\r\n```\r\nmvce.py:10: error: Item \"None\" of \"Optional[str]\" has no attribute \"split\"\r\n```\r\n\r\nInserting `reveal_type(arg)` before the print gives `Union[builtins.str, builtins.None]`.\r\n\r\nThe following typechecks fine, so mypy definitely understands the return type of `dict.get` with two arguments:\r\n\r\n```python\r\nd: Dict[str, str] = {}\r\n\r\na: str = d.get(\"a\", \"a\")\r\n```\r\n\r\nSimilarly, mypy can infer that `arg` cannot be None after an `is None` and simple assignment:\r\n\r\n```python\r\nd: Dict[str, str] = {}\r\n\r\ndef foo(arg: Optional[str] = None) -> None:\r\n if arg is None:\r\n arg = \"foo bar\"\r\n reveal_type(arg) # str\r\n print(arg.split())\r\n```\r\n\r\nbut combining the two fails.\r\n\r\n- Python 3.6.3\r\n- mypy 0.580","author":{"url":"https://github.com/keysmashes","@type":"Person","name":"keysmashes"},"datePublished":"2018-03-27T20:06:04Z","url":"https://github.com/python/mypy/issues/4805"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:efbe42aa-066c-133e-259b-c9a84416f14a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9434:3E987B:A22CB6:D9161B:6B00489D |
| html-safe-nonce | fc1e5f47a30522bbe3055d7ee27efb4078acd981dba17d9a79b7115266944eac |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDM0OjNFOTg3QjpBMjJDQjY6RDkxNjFCOjZCMDA0ODlEIiwidmlzaXRvcl9pZCI6IjE5MjQxNTU2MzI1NTQ4ODczMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d09d68116262ab4ded6a6d031a0f4de37c4eb217120d6801a9e49573100d009e |
| hovercard-subject-tag | issue:309114172 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/4805/issue_layout |
| twitter:image | https://opengraph.githubassets.com/047577d7b1041487a13b3fd22bca3e5102cef56b1fb69613b4cfbc8c269368d2/python/mypy/issues/4805 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/047577d7b1041487a13b3fd22bca3e5102cef56b1fb69613b4cfbc8c269368d2/python/mypy/issues/4805 |
| og:image:alt | Code from typing import Dict, Optional d: Dict[str, str] = {} def foo(arg: Optional[str] = None) -> None: if arg is None: arg = d.get("a", "foo bar") print(arg.split()) Expected output None, since ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | keysmashes |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width