René's URL Explorer Experiment


Title: Crash in union with a forward reference to a bad type. · Issue #4543 · python/mypy · GitHub

Open Graph Title: Crash in union with a forward reference to a bad type. · Issue #4543 · python/mypy

X Title: Crash in union with a forward reference to a bad type. · Issue #4543 · python/mypy

Description: This code causes a crash: Alias = Union[Bad, C, D] Bad = object() class C: pass class D: pass option: Alias if isinstance(option, C): pass Here is a traceback: tmp.py:3: error: Invalid type "tmp.Bad" tmp.py:13: error: INTERNAL ERROR -- p...

Open Graph Description: This code causes a crash: Alias = Union[Bad, C, D] Bad = object() class C: pass class D: pass option: Alias if isinstance(option, C): pass Here is a traceback: tmp.py:3: error: Invalid type "tmp.Ba...

X Description: This code causes a crash: Alias = Union[Bad, C, D] Bad = object() class C: pass class D: pass option: Alias if isinstance(option, C): pass Here is a traceback: tmp.py:3: error: Invalid type "t...

Opengraph URL: https://github.com/python/mypy/issues/4543

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crash in union with a forward reference to a bad type.","articleBody":"This code causes a crash:\r\n```python\r\nAlias = Union[Bad, C, D]\r\n\r\nBad = object()\r\n\r\nclass C:\r\n    pass\r\nclass D:\r\n    pass\r\n\r\noption: Alias\r\nif isinstance(option, C):\r\n    pass\r\n```\r\nHere is a traceback:\r\n```\r\ntmp.py:3: error: Invalid type \"tmp.Bad\"\r\ntmp.py:13: error: INTERNAL ERROR -- please report a bug at https://github.com/python/mypy/issues version: 0.570-dev-d2c04190b8d407476c535f30d07a9f6712e7b12a-dirty\r\nTraceback (most recent call last):\r\n  File \"/Users/ilevkivskyi/mypy/bin/mypy\", line 11, in \u003cmodule>\r\n    load_entry_point('mypy===0.570-dev-d2c04190b8d407476c535f30d07a9f6712e7b12a-dirty', 'console_scripts', 'mypy')()\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/__main__.py\", line 7, in console_entry\r\n    main(None)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/main.py\", line 80, in main\r\n    type_check_only(sources, bin_dir, options, flush_errors)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/main.py\", line 129, in type_check_only\r\n    flush_errors=flush_errors)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/build.py\", line 172, in build\r\n    result = _build(sources, options, alt_lib_path, bin_dir, saved_cache, flush_errors)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/build.py\", line 258, in _build\r\n    graph = dispatch(sources, manager)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/build.py\", line 2048, in dispatch\r\n    process_graph(graph, manager)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/build.py\", line 2349, in process_graph\r\n    process_stale_scc(graph, scc, manager)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/build.py\", line 2525, in process_stale_scc\r\n    graph[id].type_check_first_pass()\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/build.py\", line 1923, in type_check_first_pass\r\n    self.type_checker().check_first_pass()\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/checker.py\", line 228, in check_first_pass\r\n    self.accept(d)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/checker.py\", line 323, in accept\r\n    stmt.accept(self)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/nodes.py\", line 928, in accept\r\n    return visitor.visit_if_stmt(self)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/checker.py\", line 2232, in visit_if_stmt\r\n    if_map, else_map = self.find_isinstance_check(e)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/checker.py\", line 2835, in find_isinstance_check\r\n    return conditional_type_map(expr, vartype, type)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/checker.py\", line 3191, in conditional_type_map\r\n    remaining_type = restrict_subtype_away(current_type, proposed_precise_type)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/subtypes.py\", line 817, in restrict_subtype_away\r\n    new_items = [item for item in t.relevant_items()\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/subtypes.py\", line 818, in \u003clistcomp>\r\n    if (not (is_proper_subtype(erase_type(item), erased_s) or\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/erasetype.py\", line 25, in erase_type\r\n    return typ.accept(EraseTypeVisitor())\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/types.py\", line 194, in accept\r\n    return visitor.visit_unbound_type(self)\r\n  File \"/Users/ilevkivskyi/mypy/lib/python3.6/site-packages/mypy/erasetype.py\", line 31, in visit_unbound_type\r\n    assert False, 'Not supported'\r\nAssertionError: Not supported\r\n```\r\n\r\nIt looks like the problem is that clearly erroneous types are not wrapped in `ForwardRef` and are not post-processed in third pass. There are two options that I see now for `UnboundType`s (maybe there are other):\r\n* Expect them in type checker and amend the corresponding visitors\r\n* Replace them with `Any` after giving an `Invalid type` error (maybe with better error message, but we already have an issue for this.)\r\n\r\nI would prefer the second option, since this seems simpler and would probably minimize the amount of not useful errors (because of the initially invalid type).","author":{"url":"https://github.com/ilevkivskyi","@type":"Person","name":"ilevkivskyi"},"datePublished":"2018-02-05T17:02:13Z","url":"https://github.com/python/mypy/issues/4543"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:438cc7d3-ebb6-923c-6f3c-5a95724c48bb
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE946:1EE55B:25F46D2:34196B8:6B00476A
html-safe-nonce02553560ace13cfe4ba32cb91c72285b66c40d33e543421ab8aa23eb44163978
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTQ2OjFFRTU1QjoyNUY0NkQyOjM0MTk2Qjg6NkIwMDQ3NkEiLCJ2aXNpdG9yX2lkIjoiNTI4NzQwMTc5OTI2NTk5NTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb2b3eb93b521c0e35e91b7111630576d879a7d6cfb62e6f0619b340fa26a6ef
hovercard-subject-tagissue:294468163
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/4543/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e20d03a142bd7cd3ea62314fe56e69e141423a1301fb6277f290155a6d6791f4/python/mypy/issues/4543
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e20d03a142bd7cd3ea62314fe56e69e141423a1301fb6277f290155a6d6791f4/python/mypy/issues/4543
og:image:altThis code causes a crash: Alias = Union[Bad, C, D] Bad = object() class C: pass class D: pass option: Alias if isinstance(option, C): pass Here is a traceback: tmp.py:3: error: Invalid type "tmp.Ba...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameilevkivskyi
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/4543#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F4543
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F4543
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/4543
Reloadhttps://github.com/python/mypy/issues/4543
Reloadhttps://github.com/python/mypy/issues/4543
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/4543
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/4543
Crash in union with a forward reference to a bad type.https://github.com/python/mypy/issues/4543#top
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Feb 5, 2018https://github.com/python/mypy/issues/4543#issue-294468163
ilevkivskyihttps://github.com/ilevkivskyi
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
on Feb 5, 2018https://github.com/python/mypy/issues/4543#event-1458374377
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Feb 5, 2018https://github.com/python/mypy/issues/4543#issuecomment-363150002
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Mar 7, 2018https://github.com/python/mypy/issues/4543#issuecomment-371249403
#4653https://github.com/python/mypy/issues/4653
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#5258https://github.com/python/mypy/pull/5258
on Jun 21, 2018https://github.com/python/mypy/issues/4543#event-1693976978
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 21, 2018https://github.com/python/mypy/issues/4543#event-1693977237
Remove an assert triggered by UnboundType leaking from semanal.py (#5258https://github.com/python/mypy/commit/aa82bd52527aaa0d7bd82bcbebcbd9c0198ec85b
#5258https://github.com/python/mypy/pull/5258
https://docs.github.com/articles/closing-issues-via-commit-messages
aa82bd5https://github.com/python/mypy/commit/aa82bd52527aaa0d7bd82bcbebcbd9c0198ec85b
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/4543
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/4543
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.