René's URL Explorer Experiment


Title: Changing order of isinstance checks breaks inferred type · Issue #4422 · python/mypy · GitHub

Open Graph Title: Changing order of isinstance checks breaks inferred type · Issue #4422 · python/mypy

X Title: Changing order of isinstance checks breaks inferred type · Issue #4422 · python/mypy

Description: This works fine: def __add__(self, other: object) -> 'Currency': if isinstance(other, self.__class__) and isinstance(other, Currency): return self.__class__(other.amt + self.amt) return NotImplemented but this does not: def __add__(self,...

Open Graph Description: This works fine: def __add__(self, other: object) -> 'Currency': if isinstance(other, self.__class__) and isinstance(other, Currency): return self.__class__(other.amt + self.amt) return NotImplemen...

X Description: This works fine: def __add__(self, other: object) -> 'Currency': if isinstance(other, self.__class__) and isinstance(other, Currency): return self.__class__(other.amt + self.amt) return ...

Opengraph URL: https://github.com/python/mypy/issues/4422

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Changing order of isinstance checks breaks inferred type","articleBody":"This works fine:\r\n```python\r\ndef __add__(self, other: object) -> 'Currency':\r\n    if isinstance(other, self.__class__) and isinstance(other, Currency):\r\n        return self.__class__(other.amt + self.amt)\r\n    return NotImplemented\r\n```\r\n\r\nbut this does not:\r\n```python\r\ndef __add__(self, other: object) -> 'Currency':\r\n    if isinstance(other, Currency) and isinstance(other, self.__class__):   # only expression order is flipped\r\n        return self.__class__(other.amt + self.amt)\r\n    return NotImplemented\r\n```\r\nthrows: `error: \"object\" has no attribute \"amt\"`\r\n\r\nFull code to reproduce it locally: https://gist.github.com/pirate/b3ef5a25449285dadc366dd926cebcea\r\n\r\nThe intention is to check that `other` is the same class as `self` (to prevent adding `BTC` to `USD` by accident).  That check alone should imply that `other` is a subclass of `Currency` (since the `__add__` method is defined on `Currency`), but it looks like I have to explicitly make both assertions, and make the `Currency` assertion **after** the `self.__class__` one in order for mypy to narrow the type correctly.\r\n\r\nCorrect me if I'm mistaken, but I think there may be two bugs here:\r\n - The order of `isinstance` checks shouldn't matter (especially not in an `and` expression)\r\n - The `isinstance(other, Currency)` should not even be necessary, as it's implied that other is a `Currency` if `other.__class__ == self.__class__`\r\n\r\nThis issue discusses a vaguely similar type-narrowing problem, but I'm not sure if it's actually related: https://github.com/python/mypy/issues/2776\r\n  ","author":{"url":"https://github.com/pirate","@type":"Person","name":"pirate"},"datePublished":"2018-01-03T06:01:21Z","url":"https://github.com/python/mypy/issues/4422"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ca5315c1-5ebd-9e08-e66f-ccc9acbbc660
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBF32:1F3799:298DF1A:3684C08:6B000C50
html-safe-nonce9a1b078b0c6248204bb203e521c82fc31ab5e506f5f6c4c64eaebf9bfa46f5b5
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjMyOjFGMzc5OToyOThERjFBOjM2ODRDMDg6NkIwMDBDNTAiLCJ2aXNpdG9yX2lkIjoiNjkzMjI1MDc1MTM5Nzc5Mjg0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfd0c00a6c45da1919b1a58072ea59a872e33af08c81fcadaef4eb4c17f4e7a70
hovercard-subject-tagissue:285605017
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/4422/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3e3e30b28310f9de6cfe513e80901bb1588ea6674d3b334a725bc86a4be67485/python/mypy/issues/4422
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3e3e30b28310f9de6cfe513e80901bb1588ea6674d3b334a725bc86a4be67485/python/mypy/issues/4422
og:image:altThis works fine: def __add__(self, other: object) -> 'Currency': if isinstance(other, self.__class__) and isinstance(other, Currency): return self.__class__(other.amt + self.amt) return NotImplemen...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepirate
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/4422#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F4422
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F4422
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/4422
Reloadhttps://github.com/python/mypy/issues/4422
Reloadhttps://github.com/python/mypy/issues/4422
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/4422
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/4422
Changing order of isinstance checks breaks inferred typehttps://github.com/python/mypy/issues/4422#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com/pirate
piratehttps://github.com/pirate
on Jan 3, 2018https://github.com/python/mypy/issues/4422#issue-285605017
https://gist.github.com/pirate/b3ef5a25449285dadc366dd926cebceahttps://gist.github.com/pirate/b3ef5a25449285dadc366dd926cebcea
#2776https://github.com/python/mypy/issues/2776
piratehttps://github.com/pirate
on Jan 3, 2018https://github.com/python/mypy/issues/4422#event-1407334346
piratehttps://github.com/pirate
on Jan 3, 2018https://github.com/python/mypy/issues/4422#event-1407334523
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jan 3, 2018https://github.com/python/mypy/issues/4422#issuecomment-354959973
#2776https://github.com/python/mypy/issues/2776
ilevkivskyihttps://github.com/ilevkivskyi
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Jan 3, 2018https://github.com/python/mypy/issues/4422#event-1407420081
piratehttps://github.com/pirate
on Jan 3, 2018https://github.com/python/mypy/issues/4422#event-1407426426
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jan 3, 2018https://github.com/python/mypy/issues/4422#issuecomment-355028860
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jan 3, 2018https://github.com/python/mypy/issues/4422#issuecomment-355034547
python/typeshed#1549https://github.com/python/typeshed/pull/1549
#2776https://github.com/python/mypy/issues/2776
#2776 (comment)https://github.com/python/mypy/issues/2776#issuecomment-276337432
https://github.com/pirate
piratehttps://github.com/pirate
on Feb 4, 2020https://github.com/python/mypy/issues/4422#issuecomment-581687728
#8305https://github.com/python/mypy/pull/8305
https://github.com/97littleleaf11
97littleleaf11https://github.com/97littleleaf11
on Dec 20, 2021https://github.com/python/mypy/issues/4422#issuecomment-998119992
@piratehttps://github.com/pirate
97littleleaf11https://github.com/97littleleaf11
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 20, 2021https://github.com/python/mypy/issues/4422#event-5794205869
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/4422
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/4422
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.