Title: report error for false type assertions · Issue #4306 · python/mypy · GitHub
Open Graph Title: report error for false type assertions · Issue #4306 · python/mypy
X Title: report error for false type assertions · Issue #4306 · python/mypy
Description: I'm currently adding annotations to a complex module, and even after resolving most of the mypy errors within the module I suspect there are still quite a few inaccurately typed functions due to corner-cases which will only be detected i...
Open Graph Description: I'm currently adding annotations to a complex module, and even after resolving most of the mypy errors within the module I suspect there are still quite a few inaccurately typed functions due to co...
X Description: I'm currently adding annotations to a complex module, and even after resolving most of the mypy errors within the module I suspect there are still quite a few inaccurately typed functions due t...
Opengraph URL: https://github.com/python/mypy/issues/4306
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"report error for false type assertions","articleBody":"I'm currently adding annotations to a complex module, and even after resolving most of the mypy errors within the module I suspect there are still quite a few inaccurately typed functions due to corner-cases which will only be detected in code that *uses* the module in specific ways. I already have unittests for this module (written using pytest) that do precisely this, so type checking these would be the ideal way to check my annotations -- all-in-one static and runtime analysis. \r\n\r\nIt would go a long way to easing adoption if mypy raised errors on type assertions that it can detect are false. e.g.:\r\n\r\n```python\r\ni = 0\r\nassert isinstance(i, str) # error\r\nassert type(i) is str # error\r\n```\r\n\r\nBonus points for supporting the python `unittest` module's `assert*()` methods, but most people these days are using `pytest` and as a feature request it seems much easier and more useful to simply support `assert`.\r\n","author":{"url":"https://github.com/chadrik","@type":"Person","name":"chadrik"},"datePublished":"2017-12-01T17:30:22Z","url":"https://github.com/python/mypy/issues/4306"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:78b18f19-afff-1071-1a9c-6f41a1f623f5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8F5C:163716:20C8260:2C8AE16:6B001FFB |
| html-safe-nonce | 6e7d56f72cc364443e9f0e8355f44a474903c0064c0e781b30aaa640c993fdb4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjVDOjE2MzcxNjoyMEM4MjYwOjJDOEFFMTY6NkIwMDFGRkIiLCJ2aXNpdG9yX2lkIjoiNTI4NDA0NDQxNTc2NDAxMzA1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 125673241d4fa112b87937a96aa071a8ee596393bcd193b16c08c9624b95b47d |
| hovercard-subject-tag | issue:278539276 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/4306/issue_layout |
| twitter:image | https://opengraph.githubassets.com/31fb0559a7ab80313d14b27e8cd7e9f1ebeb7b93f0fed02e2891600c39181d35/python/mypy/issues/4306 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/31fb0559a7ab80313d14b27e8cd7e9f1ebeb7b93f0fed02e2891600c39181d35/python/mypy/issues/4306 |
| og:image:alt | I'm currently adding annotations to a complex module, and even after resolving most of the mypy errors within the module I suspect there are still quite a few inaccurately typed functions due to co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | chadrik |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width