René's URL Explorer Experiment


Title: Running mypy with --disallow-untyped-decorators reports an error for overloaded decorators · Issue #4191 · python/mypy · GitHub

Open Graph Title: Running mypy with --disallow-untyped-decorators reports an error for overloaded decorators · Issue #4191 · python/mypy

X Title: Running mypy with --disallow-untyped-decorators reports an error for overloaded decorators · Issue #4191 · python/mypy

Description: Running mypy --disallow-untyped-decorators with a decorator that defines overloads always seems to report: Untyped decorator makes function "xxx" untyped Even though reveal_type(...) calls on the decorated functions seem to indicate type...

Open Graph Description: Running mypy --disallow-untyped-decorators with a decorator that defines overloads always seems to report: Untyped decorator makes function "xxx" untyped Even though reveal_type(...) calls on the d...

X Description: Running mypy --disallow-untyped-decorators with a decorator that defines overloads always seems to report: Untyped decorator makes function "xxx" untyped Even though reveal_type(...) call...

Opengraph URL: https://github.com/python/mypy/issues/4191

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Running mypy with --disallow-untyped-decorators reports an error for overloaded decorators","articleBody":"Running mypy --disallow-untyped-decorators with a decorator that defines overloads always seems to report:\r\n\r\nUntyped decorator makes function \"xxx\" untyped\r\n\r\nEven though reveal_type(...) calls on the decorated functions seem to indicate type information.\r\n\r\nConsider the following code.  \r\n\r\nRunning mypy  --disallow-untyped-decorators here yields the following (mypy 0.540):\r\n\r\n```\r\ndec_issue.py:19: error: Overloaded function signatures 1 and 2 overlap with incompatible return types\r\ndec_issue.py:35: error: Untyped decorator makes function \"default\" untyped\r\ndec_issue.py:41: error: Revealed type is 'def (*Any, **Any) -> builtins.int*'\r\n```\r\n\r\nThe first error seems to be covered by other bug reports here (though, for all I know it may be related).\r\n\r\nHowever, the second error seems to be contradicted by the type_reveal, which indicates at least the return type of the decorated \"default\" function is being picked up.  \r\n\r\nI may be missing something, but at very least, it seems like a more descriptive error may be warranted?  \r\n\r\n```python\r\nfrom typing import *\r\n\r\nR = TypeVar(\"R\")\r\n\r\n\r\ndef _make_decorator(arg: str) -> Callable[[Callable[..., R]], Callable[..., R]]:\r\n    def dec_(fn: Callable[..., R]) -> Callable[..., R]:\r\n        def wrapped(*args: Tuple[Any, ...],\r\n                    **kwargs: Dict[str, Any]) -> R:\r\n            print(f\"Prefix {arg}!\")\r\n            return fn(*args, **kwargs)\r\n\r\n        return wrapped\r\n\r\n    return dec_\r\n\r\n\r\n@overload\r\ndef dec(x: Callable[..., R]) -> Callable[..., R]: ...\r\n\r\n\r\n@overload\r\ndef dec(x: str) -> Callable[[Callable[..., R]], Callable[..., R]]: ...\r\n\r\n\r\ndef dec(x: Any) -> Any:\r\n    if isinstance(x, str):\r\n        return _make_decorator(x)\r\n    elif callable(x):\r\n        return _make_decorator(\"default\")(x)\r\n    else:\r\n        raise Exception(\"unhandled\")\r\n\r\n\r\n@dec\r\ndef default(name: str) -> int:\r\n    print(f\"Hello, {name}!\")\r\n    return 0\r\n\r\n\r\nreveal_type(default)\r\n\r\n\r\n@dec(\"arg\")\r\ndef arg(name: str) -> int:\r\n    print(f\"Hello, {name}!\")\r\n    return 0\r\n\r\n\r\nif __name__ == \"__main__\":\r\n    default(\"Bob\")\r\n    arg(\"Bob\")\r\n\r\n```\r\n\r\n\r\n\r\n","author":{"url":"https://github.com/joshstaiger","@type":"Person","name":"joshstaiger"},"datePublished":"2017-11-01T17:49:57Z","url":"https://github.com/python/mypy/issues/4191"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:48c0398e-f0f6-2e0f-6701-a8312d2641eb
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id93F0:B5253:195B116:219114A:6B002C0B
html-safe-nonce1dfb292c193447067f89abe243b5a2d845988a1fa174c6976730ae5153e7140e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0YwOkI1MjUzOjE5NUIxMTY6MjE5MTE0QTo2QjAwMkMwQiIsInZpc2l0b3JfaWQiOiI0MTYwODIzMTAzOTMwMjQ4MjAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd702ad2216cbcf55788b71657d71a9c28a398b91af9326a375b07918a4d0eba8
hovercard-subject-tagissue:270393205
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/4191/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ea9f28741da90d22bcefcc0368b08bd6704c1d4d3a9b8a4f669fec5bc94bf482/python/mypy/issues/4191
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ea9f28741da90d22bcefcc0368b08bd6704c1d4d3a9b8a4f669fec5bc94bf482/python/mypy/issues/4191
og:image:altRunning mypy --disallow-untyped-decorators with a decorator that defines overloads always seems to report: Untyped decorator makes function "xxx" untyped Even though reveal_type(...) calls on the d...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejoshstaiger
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/4191#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F4191
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F4191
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/4191
Reloadhttps://github.com/python/mypy/issues/4191
Reloadhttps://github.com/python/mypy/issues/4191
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/4191
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/4191
Running mypy with --disallow-untyped-decorators reports an error for overloaded decoratorshttps://github.com/python/mypy/issues/4191#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
https://github.com/joshstaiger
joshstaigerhttps://github.com/joshstaiger
on Nov 1, 2017https://github.com/python/mypy/issues/4191#issue-270393205
ilevkivskyihttps://github.com/ilevkivskyi
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
on May 20, 2018https://github.com/python/mypy/issues/4191#event-1635795566
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jul 6, 2018https://github.com/python/mypy/issues/4191#issuecomment-403000708
ilevkivskyihttps://github.com/ilevkivskyi
on Sep 21, 2018https://github.com/python/mypy/issues/4191#event-1861349045
Fix untyped decorator check for class instances (#5509)https://github.com/python/mypy/commit/5afea77bbb343986309b8b5584825e960553de9e
#5509https://github.com/python/mypy/pull/5509
5afea77https://github.com/python/mypy/commit/5afea77bbb343986309b8b5584825e960553de9e
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Sep 22, 2018https://github.com/python/mypy/issues/4191#issuecomment-423702120
#5509https://github.com/python/mypy/pull/5509
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 22, 2018https://github.com/python/mypy/issues/4191#event-1861374284
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/4191
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/4191
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.