René's URL Explorer Experiment


Title: Don't complain about missing return with `Optional[]` · Issue #3974 · python/mypy · GitHub

Open Graph Title: Don't complain about missing return with `Optional[]` · Issue #3974 · python/mypy

X Title: Don't complain about missing return with `Optional[]` · Issue #3974 · python/mypy

Description: from typing import Optional def s(e: int) -> Optional[int]: if e > 2: return 4 s(2) Currently mypy complains about missing return here and adding return None in the end of the function fixes that. However I think that's undesirable: It's...

Open Graph Description: from typing import Optional def s(e: int) -> Optional[int]: if e > 2: return 4 s(2) Currently mypy complains about missing return here and adding return None in the end of the function fixes that. ...

X Description: from typing import Optional def s(e: int) -> Optional[int]: if e > 2: return 4 s(2) Currently mypy complains about missing return here and adding return None in the end of the function fixes ...

Opengraph URL: https://github.com/python/mypy/issues/3974

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Don't complain about missing return with `Optional[\u003ctype>]`","articleBody":"```python\r\nfrom typing import Optional\r\n\r\ndef s(e: int) -> Optional[int]:\r\n    if e > 2:\r\n        return 4\r\n\r\ns(2)\r\n```\r\n\r\nCurrently mypy complains about missing return here and adding `return None` in the end of the function fixes that. However I think that's undesirable:\r\n\r\n* It's not actually catching a bug: it's a false positive. False positives are bad as they lead to lost time and confusion\r\n* It motivates people to put a useless `return None` line (even `return` doesn't work) which is just noise in the program code in this case\r\n* It invalidates core Python behavior: since the dawn of time, no return, `return` and `return None` mean absolutely the same in each function, but mypy only recognizes one of those forms in this case.\r\n\r\nObviously that seems like a simple example, but I have a longer if/elif function where mypy just says `missing return on \u003cfirst line of function>` which has two issues : it's not a type bug, and mypy doesn't the invalid branch\r\n\r\n","author":{"url":"https://github.com/alehander92","@type":"Person","name":"alehander92"},"datePublished":"2017-09-20T16:17:36Z","url":"https://github.com/python/mypy/issues/3974"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:48f13ada-bb12-017d-9d78-854f1ccf04a5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id82B2:1D865F:55B40F:74F4F9:6B007364
html-safe-nonce6cb4187092c10d6fc260d8ff07ab369bd8b8c4f0c3410c0ea383c6de25c50c70
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkIyOjFEODY1Rjo1NUI0MEY6NzRGNEY5OjZCMDA3MzY0IiwidmlzaXRvcl9pZCI6IjM2NDQ3MDIyNDQwODkxMzE4NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace6b4d61f340fe90d28514575025989fd87c36a9041937583657e2bfa840f3c36
hovercard-subject-tagissue:259222218
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/3974/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b88c11acb84e22e46559bf94033dab7e67f74b401ba6d80a0d1c2c67da9cf3b0/python/mypy/issues/3974
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b88c11acb84e22e46559bf94033dab7e67f74b401ba6d80a0d1c2c67da9cf3b0/python/mypy/issues/3974
og:image:altfrom typing import Optional def s(e: int) -> Optional[int]: if e > 2: return 4 s(2) Currently mypy complains about missing return here and adding return None in the end of the function fixes that. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealehander92
hostnamegithub.com
expected-hostnamegithub.com
None75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84e563eb4b55f8fa102f325f117533cee9e3df4a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/3974#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3974
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3974
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/3974
Reloadhttps://github.com/python/mypy/issues/3974
Reloadhttps://github.com/python/mypy/issues/3974
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests543 (543)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3974
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3974
Don't complain about missing return with Optional[]https://github.com/python/mypy/issues/3974#top
https://github.com/alehander92
alehander92https://github.com/alehander92
on Sep 20, 2017https://github.com/python/mypy/issues/3974#issue-259222218
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Sep 23, 2017https://github.com/python/mypy/issues/3974#issuecomment-331648044
gvanrossumhttps://github.com/gvanrossum
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 23, 2017https://github.com/python/mypy/issues/3974#event-1262383407
https://github.com/MicaelJarniac
MicaelJarniachttps://github.com/MicaelJarniac
on Sep 24, 2020https://github.com/python/mypy/issues/3974#issuecomment-698360152
PEP 8 - Programming Recommendationshttps://www.python.org/dev/peps/pep-0008/#programming-recommendations
https://github.com/abrahammurciano
abrahammurcianohttps://github.com/abrahammurciano
on Mar 3, 2022https://github.com/python/mypy/issues/3974#issuecomment-1057975351
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Mar 3, 2022https://github.com/python/mypy/issues/3974#issuecomment-1057979897
@abrahammurcianohttps://github.com/abrahammurciano
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/3974
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/3974
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.