René's URL Explorer Experiment


Title: AttributeError with abstract property setter and "# type: ignore" · Issue #3491 · python/mypy · GitHub

Open Graph Title: AttributeError with abstract property setter and "# type: ignore" · Issue #3491 · python/mypy

X Title: AttributeError with abstract property setter and "# type: ignore" · Issue #3491 · python/mypy

Description: I noticed the following change in behavior after upgrading to 0.511 from 0.501. Using the following minimal example $ cat abstractproperty.py |nl -b a 1 from abc import ABC 2 from abc import abstractmethod 3 from typing import List 4 5 6...

Open Graph Description: I noticed the following change in behavior after upgrading to 0.511 from 0.501. Using the following minimal example $ cat abstractproperty.py |nl -b a 1 from abc import ABC 2 from abc import abstra...

X Description: I noticed the following change in behavior after upgrading to 0.511 from 0.501. Using the following minimal example $ cat abstractproperty.py |nl -b a 1 from abc import ABC 2 from abc import abstra...

Opengraph URL: https://github.com/python/mypy/issues/3491

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"AttributeError with abstract property setter and \"# type: ignore\"","articleBody":"I noticed the following change in behavior after upgrading to `0.511`  from `0.501`.\r\n\r\nUsing the following minimal example\r\n```\r\n$ cat abstractproperty.py |nl -b a\r\n     1\tfrom abc import ABC\r\n     2\tfrom abc import abstractmethod\r\n     3\tfrom typing import List\r\n     4\r\n     5\r\n     6\tclass Test(ABC):\r\n     7\r\n     8\t    @property\r\n     9\t    def foo(self) -> List:\r\n    10\t        \"\"\"Getter\"\"\"\r\n    11\r\n    12\t    @foo.setter  # type: ignore\r\n    13\t    @abstractmethod\r\n    14\t    def foo(self, value: List) -> None:\r\n    15\t        \"\"\"Setter\"\"\"\r\n```\r\nthe new version of mypy gives the following error\r\n```$ mypy abstractproperty.py                                                                                                                                                              \r\nabstractproperty.py:14: error: Function is missing a type annotation for one or more arguments\r\n```\r\nWhile the error itself is a bit unclear in terms of what exactly is missing the type annotation, attempting to ignore line 14 with a `# type: ignore` comment \r\n```python\r\nfrom abc import ABC\r\nfrom abc import abstractmethod\r\nfrom typing import List\r\n\r\n\r\nclass Test(ABC):\r\n\r\n    @property\r\n    def foo(self) -> List:\r\n        \"\"\"Getter\"\"\"\r\n\r\n    @foo.setter  # type: ignore\r\n    @abstractmethod\r\n    def foo(self, value: List) -> None:  # type: ignore\r\n        \"\"\"Setter\"\"\"\r\n```\r\nresults in an `AttributeError`\r\n```\r\nTraceback (most recent call last):\r\n  File \".../bin/mypy\", line 6, in \u003cmodule>\r\n    main(__file__)\r\n  File \".../lib/python3.5/site-packages/mypy/main.py\", line 46, in main\r\n    res = type_check_only(sources, bin_dir, options)\r\n  File \".../lib/python3.5/site-packages/mypy/main.py\", line 93, in type_check_only\r\n    options=options)\r\n  File \".../lib/python3.5/site-packages/mypy/build.py\", line 188, in build\r\n    graph = dispatch(sources, manager)\r\n  File \".../lib/python3.5/site-packages/mypy/build.py\", line 1595, in dispatch\r\n    process_graph(graph, manager)\r\n  File \".../lib/python3.5/site-packages/mypy/build.py\", line 1838, in process_graph\r\n    process_stale_scc(graph, scc, manager)\r\n  File \".../lib/python3.5/site-packages/mypy/build.py\", line 1946, in process_stale_scc\r\n    graph[id].write_cache()\r\n  File \".../lib/python3.5/site-packages/mypy/build.py\", line 1576, in write_cache\r\n    self.manager)\r\n  File \".../lib/python3.5/site-packages/mypy/build.py\", line 875, in write_cache\r\n    data = tree.serialize()\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 284, in serialize\r\n    'names': self.names.serialize(self._fullname),\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 2377, in serialize\r\n    data[key] = value.serialize(fullname, key)\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 2325, in serialize\r\n    data['node'] = self.node.serialize()\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 2176, in serialize\r\n    'names': self.names.serialize(self.fullname()),\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 2377, in serialize\r\n    data[key] = value.serialize(fullname, key)\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 2325, in serialize\r\n    data['node'] = self.node.serialize()\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 414, in serialize\r\n    'items': [i.serialize() for i in self.items],\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 414, in \u003clistcomp>\r\n    'items': [i.serialize() for i in self.items],\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 636, in serialize\r\n    'func': self.func.serialize(),\r\n  File \".../lib/python3.5/site-packages/mypy/nodes.py\", line 579, in serialize\r\n    'type': None if self.type is None else self.type.serialize(),\r\n  File \".../lib/python3.5/site-packages/mypy/types.py\", line 766, in serialize\r\n    'fallback': self.fallback.serialize(),\r\nAttributeError: 'NoneType' object has no attribute 'serialize'\r\n```\r\nMy `mypy.ini` has the following\r\n```ini\r\n[mypy]\r\ndisallow_subclassing_any = false\r\ndisallow_untyped_defs = true\r\nfollow_imports = skip\r\nignore_missing_imports = true\r\nincremental = false\r\nshow_column_numbers = true\r\nstrict_optional = true\r\nwarn_no_return = false\r\nwarn_redundant_casts = true\r\nwarn_unused_ignores = true\r\n```","author":{"url":"https://github.com/dokai","@type":"Person","name":"dokai"},"datePublished":"2017-06-01T21:24:31Z","url":"https://github.com/python/mypy/issues/3491"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:56352ecc-655b-ee8e-8e65-1abe11b18268
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBBB4:36D598:6156:8250:6B00193C
html-safe-nonceaefbfa47a2fd829ef545eb40fec7910cc6c559fe57269cacba3f80f7c14de69d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkI0OjM2RDU5ODo2MTU2OjgyNTA6NkIwMDE5M0MiLCJ2aXNpdG9yX2lkIjoiNzY5MDk2NjAyMjg0MDM5MTk5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc12ed1021327e953aa6af927b1a9d9fdeac7544c968dc66b3397c9568ddfd321
hovercard-subject-tagissue:233015019
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/3491/issue_layout
twitter:imagehttps://opengraph.githubassets.com/285cfe6f9c9d8b2836e4bc9f4df3d4550c5dd1d4725c88785bfc324d38ce03ad/python/mypy/issues/3491
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/285cfe6f9c9d8b2836e4bc9f4df3d4550c5dd1d4725c88785bfc324d38ce03ad/python/mypy/issues/3491
og:image:altI noticed the following change in behavior after upgrading to 0.511 from 0.501. Using the following minimal example $ cat abstractproperty.py |nl -b a 1 from abc import ABC 2 from abc import abstra...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedokai
hostnamegithub.com
expected-hostnamegithub.com
Nonea2dd2291b1b13cc9c06f27ec92fa3dbaf34116fc24c9347b8539db61884c59f4
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release70121d4e855ee0bb7b75cf15d061d91f8863c0f8
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/3491#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3491
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3491
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/3491
Reloadhttps://github.com/python/mypy/issues/3491
Reloadhttps://github.com/python/mypy/issues/3491
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3491
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3491
AttributeError with abstract property setter and "# type: ignore"https://github.com/python/mypy/issues/3491#top
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
https://github.com/dokai
dokaihttps://github.com/dokai
on Jun 1, 2017https://github.com/python/mypy/issues/3491#issue-233015019
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305663634
…https://github.com/python/mypy/issues/3491
@Propertyhttps://github.com/Property
@AbstractMethodhttps://github.com/AbstractMethod
@Propertyhttps://github.com/Property
@AbstractMethodhttps://github.com/AbstractMethod
#3491https://github.com/python/mypy/issues/3491
https://github.com/notifications/unsubscribe-auth/ACwrMifzmPfLI8P6lMUT1vqmh9Sx1bbOks5r_ywRgaJpZM4NtkFohttps://github.com/notifications/unsubscribe-auth/ACwrMifzmPfLI8P6lMUT1vqmh9Sx1bbOks5r_ywRgaJpZM4NtkFo
https://github.com/dokai
dokaihttps://github.com/dokai
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305806886
gvanrossumhttps://github.com/gvanrossum
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
on Jun 2, 2017https://github.com/python/mypy/issues/3491#event-1107933610
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305809519
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305810068
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305827237
@dokaihttps://github.com/dokai
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305829271
@dokaihttps://github.com/dokai
https://docs.python.org/3/library/abc.html#abc.abstractpropertyhttps://docs.python.org/3/library/abc.html#abc.abstractproperty
JelleZijlstrahttps://github.com/JelleZijlstra
on Jun 2, 2017https://github.com/python/mypy/issues/3491#event-1108065716
fix crash when serializing a type-ignored property setterhttps://github.com/JelleZijlstra/mypy/commit/f00c1c672493d6f3efc898489415946bb14ffce3
f00c1c6https://github.com/JelleZijlstra/mypy/commit/f00c1c672493d6f3efc898489415946bb14ffce3
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305831855
#3493https://github.com/python/mypy/pull/3493
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305838712
https://github.com/dokai
dokaihttps://github.com/dokai
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305841785
@gvanrossumhttps://github.com/gvanrossum
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jun 2, 2017https://github.com/python/mypy/issues/3491#issuecomment-305866359
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Jun 3, 2017https://github.com/python/mypy/issues/3491#issuecomment-305948068
gvanrossumhttps://github.com/gvanrossum
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
b5fa5d2https://github.com/python/mypy/commit/b5fa5d2c12dc88907e07b8e2d854f774faec9d64
on Jun 3, 2017https://github.com/python/mypy/issues/3491#event-1108725166
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/3491
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/3491
crashhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22crash%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.