René's URL Explorer Experiment


Title: Assert at end of if statement does not help mypy value inference · Issue #3431 · python/mypy · GitHub

Open Graph Title: Assert at end of if statement does not help mypy value inference · Issue #3431 · python/mypy

X Title: Assert at end of if statement does not help mypy value inference · Issue #3431 · python/mypy

Description: While working on making zulip pass with mypy --strict-optional, I ran into the following piece of code. Mypy was essentially saying that message.get_realm() was not guaranteed to work ("Not all parts of the union have get_realm() method"...

Open Graph Description: While working on making zulip pass with mypy --strict-optional, I ran into the following piece of code. Mypy was essentially saying that message.get_realm() was not guaranteed to work ("Not all par...

X Description: While working on making zulip pass with mypy --strict-optional, I ran into the following piece of code. Mypy was essentially saying that message.get_realm() was not guaranteed to work ("Not al...

Opengraph URL: https://github.com/python/mypy/issues/3431

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Assert at end of if statement does not help mypy value inference","articleBody":"While working on making zulip pass with `mypy --strict-optional`, I ran into the following piece of code. Mypy was essentially saying that message.get_realm() was not guaranteed to work (\"Not all parts of the union have get_realm() method\", or somesuch.)\r\n\r\n```\r\nif message is None:\r\n    message = Message.objects.select_related().get(id=message_id)\r\n\r\nrendered_content = render_markdown(message, content, realm=message.get_realm())\r\n```\r\nLet's assume, at least for here, that the get() call will never return None. I tried the following change, but mypy was still giving the exact same error:\r\n\r\n```\r\nif message is None:\r\n    message = Message.objects.select_related().get(id=message_id)\r\n    assert message is not None # ADDED\r\n\r\nrendered_content = render_markdown(message, content, realm=message.get_realm())\r\n```\r\n\r\nHowever, with this change, mypy was now happy with the code snippet:\r\n\r\n```\r\nif message is None:\r\n    message = Message.objects.select_related().get(id=message_id)\r\n\r\nassert message is not None # ADDED, but outside the if, now.\r\nrendered_content = render_markdown(message, content, realm=message.get_realm())\r\n```\r\n\r\nThe two asserts clearly have the same code behavior of making it impossible for `message` to be `None` when we reach the `rendered_content = ...` line, but mypy only understands that currently (version 5.111) for the last code snippet only. Opening this bug report for discussion of that.\r\n\r\n(Feel free to change the title of this bug report to a more meaningful / better one.)","author":{"url":"https://github.com/chrish42","@type":"Person","name":"chrish42"},"datePublished":"2017-05-24T00:05:37Z","url":"https://github.com/python/mypy/issues/3431"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1c404abc-24dd-8f42-0290-31344e077351
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCE16:1F75:7F49:5F219:6B003875
html-safe-nonce6af9e43b141d7501e65d12842a1a5dd2612759a313af96c35a0f3058284bea9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTE2OjFGNzU6N0Y0OTo1RjIxOTo2QjAwMzg3NSIsInZpc2l0b3JfaWQiOiIyOTg3MTk3MzM1ODEwODgxNjUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac3291d83921ef47a0b5957a9b7fdde01ee5bf45fe5a50718f571dd104c9ade4ec
hovercard-subject-tagissue:230883462
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/3431/issue_layout
twitter:imagehttps://opengraph.githubassets.com/3d322ae545e91904ab150e54b4c002cd0f7a3ea481883c06c67bb2f9823b4f4d/python/mypy/issues/3431
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3d322ae545e91904ab150e54b4c002cd0f7a3ea481883c06c67bb2f9823b4f4d/python/mypy/issues/3431
og:image:altWhile working on making zulip pass with mypy --strict-optional, I ran into the following piece of code. Mypy was essentially saying that message.get_realm() was not guaranteed to work ("Not all par...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamechrish42
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/3431#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3431
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3431
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/3431
Reloadhttps://github.com/python/mypy/issues/3431
Reloadhttps://github.com/python/mypy/issues/3431
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3431
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3431
Assert at end of if statement does not help mypy value inferencehttps://github.com/python/mypy/issues/3431#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
https://github.com/chrish42
chrish42https://github.com/chrish42
on May 24, 2017https://github.com/python/mypy/issues/3431#issue-230883462
https://github.com/emmatyping
emmatypinghttps://github.com/emmatyping
on May 24, 2017https://github.com/python/mypy/issues/3431#issuecomment-303579704
@pkchhttps://github.com/pkch
#2008https://github.com/python/mypy/issues/2008
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on May 24, 2017https://github.com/python/mypy/issues/3431#issuecomment-303729760
gvanrossumhttps://github.com/gvanrossum
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
on May 24, 2017https://github.com/python/mypy/issues/3431#event-1096451873
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on May 26, 2017https://github.com/python/mypy/issues/3431#issuecomment-304274945
JukkaLhttps://github.com/JukkaL
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
on May 26, 2017https://github.com/python/mypy/issues/3431#event-1098878591
ilevkivskyihttps://github.com/ilevkivskyi
on Jul 25, 2017https://github.com/python/mypy/issues/3431#event-1177469166
JukkaLhttps://github.com/JukkaL
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Sep 18, 2017https://github.com/python/mypy/issues/3431#event-1253352611
JukkaLhttps://github.com/JukkaL
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
on May 19, 2018https://github.com/python/mypy/issues/3431#event-1635337801
https://github.com/hauntsaninja
hauntsaninjahttps://github.com/hauntsaninja
on Aug 28, 2023https://github.com/python/mypy/issues/3431#issuecomment-1694802821
hauntsaninjahttps://github.com/hauntsaninja
not plannedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Aug 28, 2023https://github.com/python/mypy/issues/3431#event-10202746480
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Aug 28, 2023https://github.com/python/mypy/issues/3431#issuecomment-1695320112
#3724https://github.com/python/mypy/issues/3724
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/3431
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/3431
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.