Title: Crashes related to calling isinstance() on a NamedTuple · Issue #3419 · python/mypy · GitHub
Open Graph Title: Crashes related to calling isinstance() on a NamedTuple · Issue #3419 · python/mypy
X Title: Crashes related to calling isinstance() on a NamedTuple · Issue #3419 · python/mypy
Description: I found two separate tracebacks playing with variations on the code from #3418: from typing import Dict, NamedTuple NameDict = Dict[str, 'NameInfo'] class NameInfo(NamedTuple): ast: bool def parse_ast(name_dict: NameDict) -> None: if isi...
Open Graph Description: I found two separate tracebacks playing with variations on the code from #3418: from typing import Dict, NamedTuple NameDict = Dict[str, 'NameInfo'] class NameInfo(NamedTuple): ast: bool def parse_...
X Description: I found two separate tracebacks playing with variations on the code from #3418: from typing import Dict, NamedTuple NameDict = Dict[str, 'NameInfo'] class NameInfo(NamedTuple): ast: bool de...
Opengraph URL: https://github.com/python/mypy/issues/3419
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Crashes related to calling isinstance() on a NamedTuple","articleBody":"I found two separate tracebacks playing with variations on the code from #3418:\r\n```python\r\nfrom typing import Dict, NamedTuple\r\n\r\nNameDict = Dict[str, 'NameInfo']\r\n\r\nclass NameInfo(NamedTuple):\r\n ast: bool\r\n\r\ndef parse_ast(name_dict: NameDict) -> None:\r\n if isinstance(name_dict[''], int):\r\n pass\r\n```\r\nproduces\r\n```\r\nTraceback (most recent call last):\r\n File \"/Users/jzijlstra-mpbt/py/venvs/venv36/bin/mypy\", line 6, in \u003cmodule>\r\n exec(compile(open(__file__).read(), __file__, 'exec'))\r\n File \"/Users/jzijlstra-mpbt/py/mypy/scripts/mypy\", line 6, in \u003cmodule>\r\n main(__file__)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/main.py\", line 46, in main\r\n res = type_check_only(sources, bin_dir, options)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/main.py\", line 93, in type_check_only\r\n options=options)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 188, in build\r\n graph = dispatch(sources, manager)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1595, in dispatch\r\n process_graph(graph, manager)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1838, in process_graph\r\n process_stale_scc(graph, scc, manager)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1937, in process_stale_scc\r\n graph[id].type_check_first_pass()\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1510, in type_check_first_pass\r\n self.type_checker.check_first_pass()\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 177, in check_first_pass\r\n self.accept(d)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 565, in accept\r\n return visitor.visit_func_def(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 510, in visit_func_def\r\n self.check_func_item(defn, name=defn.name())\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 569, in check_func_item\r\n self.check_func_def(defn, typ, name)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 718, in check_func_def\r\n self.accept(item.body)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 811, in accept\r\n return visitor.visit_block(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 1173, in visit_block\r\n self.accept(s)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 970, in accept\r\n return visitor.visit_if_stmt(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 1916, in visit_if_stmt\r\n if_map, else_map = self.find_isinstance_check(e)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 2477, in find_isinstance_check\r\n return find_isinstance_check(n, self.type_map)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 2731, in find_isinstance_check\r\n return conditional_type_map(expr, vartype, type)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 2531, in conditional_type_map\r\n and is_proper_subtype(current_type, proposed_type)):\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/subtypes.py\", line 558, in is_proper_subtype\r\n return left.accept(ProperSubtypeVisitor(right))\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/types.py\", line 411, in accept\r\n return visitor.visit_instance(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/subtypes.py\", line 594, in visit_instance\r\n for base in left.type.mro:\r\nTypeError: 'NoneType' object is not iterable\r\ntypeshed_client/parser.py:9: note: use --pdb to drop into pdb\r\n```\r\n\r\nThe other stack trace I haven't been able to minimize yet, but the traceback is\r\n```\r\n/Users/jzijlstra-mpbt/py/typeshed_client/typeshed_client/resolver.py:61: error: INTERNAL ERROR -- please report a bug at https://github.com/python/mypy/issues version: 0.520-dev-38453c0ddfaa6660309f782b227bd40b8c4634ba-dirty\r\nTraceback (most recent call last):\r\n File \"/Users/jzijlstra-mpbt/py/venvs/venv36/bin/mypy\", line 6, in \u003cmodule>\r\n exec(compile(open(__file__).read(), __file__, 'exec'))\r\n File \"/Users/jzijlstra-mpbt/py/mypy/scripts/mypy\", line 6, in \u003cmodule>\r\n main(__file__)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/main.py\", line 46, in main\r\n res = type_check_only(sources, bin_dir, options)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/main.py\", line 93, in type_check_only\r\n options=options)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 188, in build\r\n graph = dispatch(sources, manager)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1595, in dispatch\r\n process_graph(graph, manager)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1838, in process_graph\r\n process_stale_scc(graph, scc, manager)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1937, in process_stale_scc\r\n graph[id].type_check_first_pass()\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/build.py\", line 1510, in type_check_first_pass\r\n self.type_checker.check_first_pass()\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 177, in check_first_pass\r\n self.accept(d)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 750, in accept\r\n return visitor.visit_class_def(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 1080, in visit_class_def\r\n self.accept(defn.defs)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 811, in accept\r\n return visitor.visit_block(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 1173, in visit_block\r\n self.accept(s)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 565, in accept\r\n return visitor.visit_func_def(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 510, in visit_func_def\r\n self.check_func_item(defn, name=defn.name())\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 569, in check_func_item\r\n self.check_func_def(defn, typ, name)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 718, in check_func_def\r\n self.accept(item.body)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 811, in accept\r\n return visitor.visit_block(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 1173, in visit_block\r\n self.accept(s)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 264, in accept\r\n stmt.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 970, in accept\r\n return visitor.visit_if_stmt(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checker.py\", line 1906, in visit_if_stmt\r\n t = self.expr_checker.accept(e)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 2058, in accept\r\n typ = node.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 1368, in accept\r\n return visitor.visit_unary_expr(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 1408, in visit_unary_expr\r\n operand_type = self.accept(e.expr)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 2058, in accept\r\n typ = node.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 1303, in accept\r\n return visitor.visit_call_expr(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 201, in visit_call_expr\r\n ret_type = self.check_call_expr_with_callee_type(callee_type, e)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 341, in check_call_expr_with_callee_type\r\n e.arg_names, callable_node=e.callee)[0]\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 393, in check_call\r\n callee, args, arg_kinds, formal_to_actual)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 538, in infer_arg_types_in_context2\r\n res[ai] = self.accept(args[ai], callee.arg_types[i])\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 2058, in accept\r\n typ = node.accept(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 1256, in accept\r\n return visitor.visit_member_expr(self)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 1012, in visit_member_expr\r\n result = self.analyze_ordinary_member_access(e, False)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkexpr.py\", line 1027, in analyze_ordinary_member_access\r\n original_type=original_type, chk=self.chk)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkmember.py\", line 100, in analyze_member_access\r\n original_type=original_type, chk=chk)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkmember.py\", line 222, in analyze_member_var_access\r\n v = lookup_member_var_or_accessor(info, name, is_lvalue)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/checkmember.py\", line 341, in lookup_member_var_or_accessor\r\n node = info.get(name)\r\n File \"/Users/jzijlstra-mpbt/py/mypy/mypy/nodes.py\", line 2033, in get\r\n for cls in self.mro:\r\nTypeError: 'NoneType' object is not iterable\r\n/Users/jzijlstra-mpbt/py/typeshed_client/typeshed_client/resolver.py:61: note: use --pdb to drop into pdb\r\n```\r\nThe crashing line is `if not isinstance(info.ast, parser.ImportedName):`, where `info` is a `NameInfo` from the above example. I think it's likely the same underlying bug.","author":{"url":"https://github.com/JelleZijlstra","@type":"Person","name":"JelleZijlstra"},"datePublished":"2017-05-23T07:15:33Z","url":"https://github.com/python/mypy/issues/3419"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:52ac50f0-30fa-70bf-ddf7-6da931403344 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E2FC:14B836:E9E200:139C3E7:6B00582E |
| html-safe-nonce | 255c8c06ab54cb16e6a2a5b0ced86c821f8871c89835b9e5b8c59109500f30b7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkZDOjE0QjgzNjpFOUUyMDA6MTM5QzNFNzo2QjAwNTgyRSIsInZpc2l0b3JfaWQiOiIzNDM1MTAyNTY3NDU0MTEwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 542ba80095c5e07c614f30de76b0101117a820027ccb8a6ded70d38112cf4c18 |
| hovercard-subject-tag | issue:230608420 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/3419/issue_layout |
| twitter:image | https://opengraph.githubassets.com/7f2cb37081fb978ea40db7b8a303019f2e16a731b43e649fb089309696e0d2fa/python/mypy/issues/3419 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/7f2cb37081fb978ea40db7b8a303019f2e16a731b43e649fb089309696e0d2fa/python/mypy/issues/3419 |
| og:image:alt | I found two separate tracebacks playing with variations on the code from #3418: from typing import Dict, NamedTuple NameDict = Dict[str, 'NameInfo'] class NameInfo(NamedTuple): ast: bool def parse_... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JelleZijlstra |
| hostname | github.com |
| expected-hostname | github.com |
| None | 29be975efff6507a5d135de9c7d634cf7ff8f0c55222a64386ab3202209aaf73 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | eacd927ba6112e3b01ba99c762bd699a4a4f5df7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width