Title: Fine grained crash when class is turned into a generic class · Issue #3279 · python/mypy · GitHub
Open Graph Title: Fine grained crash when class is turned into a generic class · Issue #3279 · python/mypy
X Title: Fine grained crash when class is turned into a generic class · Issue #3279 · python/mypy
Description: a.py: import b def f() -> b.C: pass Original b.py: import a class C: pass Updated b.py: from typing import TypeVar, Generic import a T = TypeVar('T') class C(Generic[T]): pass reveal_type(a.f) c: C[int] d = a.f() d = c c = d Now if I run...
Open Graph Description: a.py: import b def f() -> b.C: pass Original b.py: import a class C: pass Updated b.py: from typing import TypeVar, Generic import a T = TypeVar('T') class C(Generic[T]): pass reveal_type(a.f) c: C...
X Description: a.py: import b def f() -> b.C: pass Original b.py: import a class C: pass Updated b.py: from typing import TypeVar, Generic import a T = TypeVar('T') class C(Generic[T]): pass reveal_typ...
Opengraph URL: https://github.com/python/mypy/issues/3279
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Fine grained crash when class is turned into a generic class","articleBody":"`a.py`:\r\n\r\n```py\r\nimport b\r\ndef f() -> b.C: pass\r\n```\r\n\r\nOriginal `b.py`:\r\n\r\n```py\r\nimport a\r\nclass C: pass\r\n```\r\n\r\nUpdated `b.py`:\r\n\r\n```py\r\nfrom typing import TypeVar, Generic\r\nimport a\r\n\r\nT = TypeVar('T')\r\nclass C(Generic[T]): pass\r\n\r\nreveal_type(a.f)\r\nc: C[int]\r\nd = a.f()\r\nd = c\r\nc = d\r\n```\r\n\r\nNow if I run `mypy --quick a.py` first with the original files, then with the updated `b.py`, I get a crash:\r\n\r\n```\r\n$ mypy --quick --show-traceback a.py\r\nb.py:7: error: Revealed type is 'def () -> b.C'\r\n/Users/jukka/src/mypy/b.py:11: error: INTERNAL ERROR -- please report a bug at https://github.com/python/mypy/issues version: 0.510-dev-c856a53fe06c0ad9193d86ab35fb86693940f273-dirty\r\nTraceback (most recent call last):\r\n File \"/Users/jukka/src/mypy/scripts/mypy\", line 6, in \u003cmodule>\r\n main(__file__)\r\n File \"/Users/jukka/src/mypy/mypy/main.py\", line 46, in main\r\n res = type_check_only(sources, bin_dir, options)\r\n File \"/Users/jukka/src/mypy/mypy/main.py\", line 93, in type_check_only\r\n options=options)\r\n File \"/Users/jukka/src/mypy/mypy/build.py\", line 188, in build\r\n graph = dispatch(sources, manager)\r\n File \"/Users/jukka/src/mypy/mypy/build.py\", line 1570, in dispatch\r\n process_graph(graph, manager)\r\n File \"/Users/jukka/src/mypy/mypy/build.py\", line 1813, in process_graph\r\n process_stale_scc(graph, scc, manager)\r\n File \"/Users/jukka/src/mypy/mypy/build.py\", line 1912, in process_stale_scc\r\n graph[id].type_check_first_pass()\r\n File \"/Users/jukka/src/mypy/mypy/build.py\", line 1485, in type_check_first_pass\r\n self.type_checker.check_first_pass()\r\n File \"/Users/jukka/src/mypy/mypy/checker.py\", line 177, in check_first_pass\r\n self.accept(d)\r\n File \"/Users/jukka/src/mypy/mypy/checker.py\", line 262, in accept\r\n stmt.accept(self)\r\n File \"/Users/jukka/src/mypy/mypy/nodes.py\", line 853, in accept\r\n return visitor.visit_assignment_stmt(self)\r\n File \"/Users/jukka/src/mypy/mypy/checker.py\", line 1177, in visit_assignment_stmt\r\n self.check_assignment(s.lvalues[-1], s.rvalue, s.type is None, s.new_syntax)\r\n File \"/Users/jukka/src/mypy/mypy/checker.py\", line 1239, in check_assignment\r\n rvalue_type = self.check_simple_assignment(lvalue_type, rvalue, lvalue)\r\n File \"/Users/jukka/src/mypy/mypy/checker.py\", line 1698, in check_simple_assignment\r\n rvalue_type = self.expr_checker.accept(rvalue, lvalue_type)\r\n File \"/Users/jukka/src/mypy/mypy/checkexpr.py\", line 2056, in accept\r\n typ = node.accept(self)\r\n File \"/Users/jukka/src/mypy/mypy/nodes.py\", line 1213, in accept\r\n return visitor.visit_name_expr(self)\r\n File \"/Users/jukka/src/mypy/mypy/checkexpr.py\", line 123, in visit_name_expr\r\n return self.narrow_type_from_binder(e, result)\r\n File \"/Users/jukka/src/mypy/mypy/checkexpr.py\", line 2271, in narrow_type_from_binder\r\n ans = narrow_declared_type(known_type, restriction)\r\n File \"/Users/jukka/src/mypy/mypy/meet.py\", line 46, in narrow_declared_type\r\n return meet_types(declared, narrowed)\r\n File \"/Users/jukka/src/mypy/mypy/meet.py\", line 25, in meet_types\r\n return t.accept(TypeMeetVisitor(s))\r\n File \"/Users/jukka/src/mypy/mypy/types.py\", line 381, in accept\r\n return visitor.visit_instance(self)\r\n File \"/Users/jukka/src/mypy/mypy/meet.py\", line 198, in visit_instance\r\n args.append(self.meet(t.args[i], si.args[i]))\r\nIndexError: list index out of range\r\n/Users/jukka/src/mypy/b.py:11: note: use --pdb to drop into pdb\r\n```","author":{"url":"https://github.com/JukkaL","@type":"Person","name":"JukkaL"},"datePublished":"2017-04-28T16:06:23Z","url":"https://github.com/python/mypy/issues/3279"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:08cddb1c-1fa2-a6c3-a334-dde6be5521e5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B9A6:302FC:725146:987A7C:6B0038B2 |
| html-safe-nonce | caf40a085465ea3c423c29bc898e80c5b1e67d70f0f9937226aeae8327521334 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUE2OjMwMkZDOjcyNTE0Njo5ODdBN0M6NkIwMDM4QjIiLCJ2aXNpdG9yX2lkIjoiMjY0NDIyMTE2MzMxNTY3MzI2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | d896538eab62eecdf9d85ad79bfde7cd68695326e8383656c01915395a65edcc |
| hovercard-subject-tag | issue:225125650 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/3279/issue_layout |
| twitter:image | https://opengraph.githubassets.com/18e1b8aee7def7c0ddaaf4a4982c851af97874e6b5b71490d4504d7f912f4d40/python/mypy/issues/3279 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/18e1b8aee7def7c0ddaaf4a4982c851af97874e6b5b71490d4504d7f912f4d40/python/mypy/issues/3279 |
| og:image:alt | a.py: import b def f() -> b.C: pass Original b.py: import a class C: pass Updated b.py: from typing import TypeVar, Generic import a T = TypeVar('T') class C(Generic[T]): pass reveal_type(a.f) c: C... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JukkaL |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f3f3a43ca095cdea3abbb394112e971f9fdb94fa |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width