René's URL Explorer Experiment


Title: Replace builtins.function with types.FunctionType · Issue #3171 · python/mypy · GitHub

Open Graph Title: Replace builtins.function with types.FunctionType · Issue #3171 · python/mypy

X Title: Replace builtins.function with types.FunctionType · Issue #3171 · python/mypy

Description: Copied from #3107 It seems that with this change, every test needs types.FunctionType in the test stubs (probably because builtins.function was used as a fallback). And that means builtins.pyi (and every custom bultins fixture) would hav...

Open Graph Description: Copied from #3107 It seems that with this change, every test needs types.FunctionType in the test stubs (probably because builtins.function was used as a fallback). And that means builtins.pyi (and...

X Description: Copied from #3107 It seems that with this change, every test needs types.FunctionType in the test stubs (probably because builtins.function was used as a fallback). And that means builtins.pyi (and...

Opengraph URL: https://github.com/python/mypy/issues/3171

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Replace builtins.function with types.FunctionType","articleBody":"Copied from #3107 \r\n\r\nIt seems that with this change, every test needs types.FunctionType in the test stubs (probably because builtins.function was used as a fallback). And that means builtins.pyi (and every custom bultins fixture) would have to import types. (On top of that, we'll also need to define list everywhere since types.pyi uses it.)\r\n\r\nDo we want to do some workaround, like manually inject types.FunctionType into the test environment, without importing types? Not that types.pyi is huge, but it does have a generic in it.\r\n\r\n@ilevkivskyi \r\n> You could just try adding import types, and see what is the performance impact for tests, if it is few percent, then it is OK, but a manual injection would be needed if there will be a significant slow-down in tests.\r\n\r\nThere's an issue with importing `types` module everywhere; it breaks a lot of tests due to the presence of `TypeVar` in it, and therefore the requirement to bring in `typing` as well. In particular, it breaks incremental tests, tests that use `[file builtins.py]` (even after I added `import types` to all fixtures). Also fixing `ThirdPass.builtin_type` to make it work for `types.FunctionType` would be quite hacky.\r\n\r\nI am now thinking that maybe we should not replace all `builtins.function` after all. If we want the user to be able to use `types.FunctionType`, that's ok, but perhaps internally it's not worth changing?","author":{"url":"https://github.com/pkch","@type":"Person","name":"pkch"},"datePublished":"2017-04-14T04:07:22Z","url":"https://github.com/python/mypy/issues/3171"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:526a211f-a910-1506-b5ce-028dd6256cf7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9DEE:17415E:120F73:19064B:6B0063F9
html-safe-nonce97a0a6c5c7ed7fd15c0875e67146285d1ba2190802576d66023d2a7d527d163b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REVFOjE3NDE1RToxMjBGNzM6MTkwNjRCOjZCMDA2M0Y5IiwidmlzaXRvcl9pZCI6IjMzNzE0NzA4MjE0NDc5ODQxMjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4b097b4c4820fa106bea4b410331489cb7699ca281ebc1cf36a1355af5398f4a
hovercard-subject-tagissue:221737461
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/3171/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4c918f57adbf2283bd28418ae86872d28e2ad1489561c93d98b6b70a6dbdbc54/python/mypy/issues/3171
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c918f57adbf2283bd28418ae86872d28e2ad1489561c93d98b6b70a6dbdbc54/python/mypy/issues/3171
og:image:altCopied from #3107 It seems that with this change, every test needs types.FunctionType in the test stubs (probably because builtins.function was used as a fallback). And that means builtins.pyi (and...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkch
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/3171#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3171
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3171
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/3171
Reloadhttps://github.com/python/mypy/issues/3171
Reloadhttps://github.com/python/mypy/issues/3171
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests543 (543)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3171
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3171
Replace builtins.function with types.FunctionTypehttps://github.com/python/mypy/issues/3171#top
affects-typeshedAnything that blocks a typeshed changehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22affects-typeshed%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-usabilityhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-usability%22
https://github.com/pkch
pkchhttps://github.com/pkch
on Apr 14, 2017https://github.com/python/mypy/issues/3171#issue-221737461
#3107https://github.com/python/mypy/pull/3107
@ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Apr 15, 2017https://github.com/python/mypy/issues/3171#issuecomment-294258613
ilevkivskyihttps://github.com/ilevkivskyi
topic-usabilityhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-usability%22
on May 19, 2017https://github.com/python/mypy/issues/3171#event-1090186614
ilevkivskyihttps://github.com/ilevkivskyi
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on May 19, 2019https://github.com/python/mypy/issues/3171#event-2351584340
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on May 20, 2019https://github.com/python/mypy/issues/3171#issuecomment-493929947
#5958https://github.com/python/mypy/issues/5958
AlexWaygoodhttps://github.com/AlexWaygood
affects-typeshedAnything that blocks a typeshed changehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22affects-typeshed%22
on Mar 31, 2022https://github.com/python/mypy/issues/3171#event-6345937504
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Mar 31, 2022https://github.com/python/mypy/issues/3171#issuecomment-1084912064
#3171https://github.com/python/mypy/issues/3171
AlexWaygoodhttps://github.com/AlexWaygood
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 31, 2022https://github.com/python/mypy/issues/3171#event-6345950834
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
on Mar 31, 2022https://github.com/python/mypy/issues/3171#issuecomment-1084914650
@AlexWaygoodhttps://github.com/AlexWaygood
#3171https://github.com/python/mypy/issues/3171
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Mar 31, 2022https://github.com/python/mypy/issues/3171#issuecomment-1084916646
#8240https://github.com/python/mypy/issues/8240
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/3171
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/3171
affects-typeshedAnything that blocks a typeshed changehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22affects-typeshed%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-usabilityhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-usability%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.