René's URL Explorer Experiment


Title: Tests behave differently without builtins fixtures · Issue #3111 · python/mypy · GitHub

Open Graph Title: Tests behave differently without builtins fixtures · Issue #3111 · python/mypy

X Title: Tests behave differently without builtins fixtures · Issue #3111 · python/mypy

Description: I was somewhat concerned that test builtins fixtures might not perfectly represent the production version of mypy, so I ran the tests without the fixtures. The good news is that, as expected, fixtures make tests at least twice faster (py...

Open Graph Description: I was somewhat concerned that test builtins fixtures might not perfectly represent the production version of mypy, so I ran the tests without the fixtures. The good news is that, as expected, fixtu...

X Description: I was somewhat concerned that test builtins fixtures might not perfectly represent the production version of mypy, so I ran the tests without the fixtures. The good news is that, as expected, fixtu...

Opengraph URL: https://github.com/python/mypy/issues/3111

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Tests behave differently without builtins fixtures ","articleBody":"I was somewhat concerned that test builtins fixtures might not perfectly represent the production version of mypy, so I ran the tests without the fixtures.\r\n\r\nThe good news is that, as expected, fixtures make tests at least twice faster (pytest alone takes 212 sec without the fixtures, and 12 sec with).\r\n\r\nThe bad news is that 60 out of 2309 tests failed. Many of the failures were trivial (a slight change in the error message since the test was written, or not defining a type variables because it's already defined in the fixture). But a few were more serious.\r\n\r\nFor example this code (from check-class-namedtuple.test: testNewNamedTupleJoinTuple), instead of reporting the two revealed types, crashed mypy (under python 3.6):\r\n\r\n```\r\nclass X(NamedTuple):\r\n    x: int\r\n    y: str\r\n\r\nreveal_type([(3, 'b'), X(1, 'a')])  # E: Revealed type is 'builtins.list[Tuple[builtins.int, builtins.str]]'\r\nreveal_type([X(1, 'a'), (3, 'b')])  # E: Revealed type is 'builtins.list[Tuple[builtins.int, builtins.str]]'\r\n\r\n```\r\n\r\nThis code (from check-namedtuple.test: testNamedTupleMake) didn't report the second expected error message:\r\n\r\n```\r\nX = NamedTuple('X', [('x', int), ('y', str)])\r\nreveal_type(X._make([5, 'a']))  # E: Revealed type is 'Tuple[builtins.int, builtins.str, fallback=__main__.X]'\r\nX._make('a b')  # E: Argument 1 to X._make has incompatible type \"str\"; expected Iterable[Any]\r\n```\r\n\r\nNot sure what the best solution is. Maybe it's worth having a daily run of all tests without fixtures using some special commit.\r\n\r\nIn any case, I made a branch that allows to easily run tests without fixtures because I couldn't find a command line parameter that would do it. I'll push a PR for it, although it's probably more appropriate for testing and discussion, not for merging.","author":{"url":"https://github.com/pkch","@type":"Person","name":"pkch"},"datePublished":"2017-04-02T16:23:53Z","url":"https://github.com/python/mypy/issues/3111"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:366180d5-bfd3-a0c0-459a-6f400c91f7e9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9AAC:21E5F:9E8173:D4427C:6B0046D6
html-safe-nonce4c93ee7d2914f1da96bd4f3b18fff55901a467d5c0f1359936d1108f117b72d7
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QUFDOjIxRTVGOjlFODE3MzpENDQyN0M6NkIwMDQ2RDYiLCJ2aXNpdG9yX2lkIjoiMTYzMDIzOTUxODU2NzE4ODE4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac83ad36d2b4fa4ed3a5bb2cf97438acb03e16f92b1d5b540b7454ba61ecc09281
hovercard-subject-tagissue:218775199
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/3111/issue_layout
twitter:imagehttps://opengraph.githubassets.com/79bf299a35453a9e71629da2435723eca6fab35d1840ac5ce329ac81606a6b2a/python/mypy/issues/3111
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/79bf299a35453a9e71629da2435723eca6fab35d1840ac5ce329ac81606a6b2a/python/mypy/issues/3111
og:image:altI was somewhat concerned that test builtins fixtures might not perfectly represent the production version of mypy, so I ran the tests without the fixtures. The good news is that, as expected, fixtu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkch
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/3111#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3111
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F3111
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/3111
Reloadhttps://github.com/python/mypy/issues/3111
Reloadhttps://github.com/python/mypy/issues/3111
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests545 (545)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3111
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/3111
Tests behave differently without builtins fixtures https://github.com/python/mypy/issues/3111#top
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
https://github.com/pkch
pkchhttps://github.com/pkch
on Apr 2, 2017https://github.com/python/mypy/issues/3111#issue-218775199
https://github.com/pkch
pkchhttps://github.com/pkch
on Apr 2, 2017https://github.com/python/mypy/issues/3111#issuecomment-290997115
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Apr 3, 2017https://github.com/python/mypy/issues/3111#issuecomment-291103281
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Apr 3, 2017https://github.com/python/mypy/issues/3111#issuecomment-291110865
https://github.com/pkch
pkchhttps://github.com/pkch
on Apr 3, 2017https://github.com/python/mypy/issues/3111#issuecomment-291281435
@JukkaLhttps://github.com/JukkaL
@ilevkivskyihttps://github.com/ilevkivskyi
@ilevkivskyihttps://github.com/ilevkivskyi
https://github.com/pkch
pkchhttps://github.com/pkch
on Apr 4, 2017https://github.com/python/mypy/issues/3111#issuecomment-291371708
https://github.com/pkch
pkchhttps://github.com/pkch
on Apr 4, 2017https://github.com/python/mypy/issues/3111#issuecomment-291406533
#3112https://github.com/python/mypy/pull/3112
ilevkivskyihttps://github.com/ilevkivskyi
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
on May 18, 2018https://github.com/python/mypy/issues/3111#event-1635074764
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Oct 5, 2020https://github.com/python/mypy/issues/3111#issuecomment-703563213
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 5, 2020https://github.com/python/mypy/issues/3111#event-3839860972
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/3111
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/3111
topic-testshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-tests%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.