René's URL Explorer Experiment


Title: False positives with `--strict-optional` turned off · Issue #2999 · python/mypy · GitHub

Open Graph Title: False positives with `--strict-optional` turned off · Issue #2999 · python/mypy

X Title: False positives with `--strict-optional` turned off · Issue #2999 · python/mypy

Description: This is a low-priority issue (or maybe should even be closed), just wanted to add it for the record in case others run into it. When --strict-optional is turned off, mypy in some cases is unable to infer the correct type inside ... if No...

Open Graph Description: This is a low-priority issue (or maybe should even be closed), just wanted to add it for the record in case others run into it. When --strict-optional is turned off, mypy in some cases is unable to...

X Description: This is a low-priority issue (or maybe should even be closed), just wanted to add it for the record in case others run into it. When --strict-optional is turned off, mypy in some cases is unable to...

Opengraph URL: https://github.com/python/mypy/issues/2999

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"False positives with `--strict-optional` turned off","articleBody":"This is a low-priority issue (or maybe should even be closed), just wanted to add it for the record in case others run into it.\r\n\r\nWhen `--strict-optional` is turned off, mypy in some cases is unable to infer the correct type inside `... if None else ...` type conditionals; this doesn't happen always, only if it's preceded with `assert isinstance(x, (X, type(None)))` when `x` was known to be of type `Base`, which is the base class of `X`:\r\n\r\n```\r\nfrom typing import *\r\n\r\nclass A:\r\n    a = 1\r\n\r\nclass B(A):\r\n    b = 2\r\n\r\ndef f(x: Union[A, None]) -> None:\r\n    assert isinstance(x, (B, type(None)))\r\n    y = x.b if x is not None else x  # fails type check if --strict-optional is off, passes otherwise\r\n```\r\n\r\nThe fix would be messy (mypy correctly analyzes the `if` statement, the problem is that it ignores the `isinstance` because it thinks that the assertion always succeeds anyway due to some problem with `None` handling).","author":{"url":"https://github.com/pkch","@type":"Person","name":"pkch"},"datePublished":"2017-03-14T18:32:34Z","url":"https://github.com/python/mypy/issues/2999"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:380d921e-56e9-7d9b-5590-cf5c2f20ca60
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC52E:59847:208731:2BEC85:6B0022AC
html-safe-nonce3127dfd268990f40b6532bdcfebe06955f0e1c85f71eacc68ba8b86e4cf35222
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTJFOjU5ODQ3OjIwODczMToyQkVDODU6NkIwMDIyQUMiLCJ2aXNpdG9yX2lkIjoiOTk3NzE5OTk4NDE3ODcxNTMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0db9f69745cad5384e6ae4566bb9677963caee5f1c0f533ff9b33abd9687fcd4
hovercard-subject-tagissue:214166564
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2999/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b9598d99848acd87b405fd7446669a2132d66ec16a10301084260fbda6bb3f9b/python/mypy/issues/2999
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b9598d99848acd87b405fd7446669a2132d66ec16a10301084260fbda6bb3f9b/python/mypy/issues/2999
og:image:altThis is a low-priority issue (or maybe should even be closed), just wanted to add it for the record in case others run into it. When --strict-optional is turned off, mypy in some cases is unable to...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkch
hostnamegithub.com
expected-hostnamegithub.com
None4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release44c658b24abf00491fb7ae5f56d42c9f38cbeab2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/2999#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2999
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2999
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/2999
Reloadhttps://github.com/python/mypy/issues/2999
Reloadhttps://github.com/python/mypy/issues/2999
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2999
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2999
False positives with --strict-optional turned offhttps://github.com/python/mypy/issues/2999#top
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
https://github.com/pkch
pkchhttps://github.com/pkch
on Mar 14, 2017https://github.com/python/mypy/issues/2999#issue-214166564
gvanrossumhttps://github.com/gvanrossum
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
topic-depends-on-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-depends-on-strict-optional%22
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
on Mar 14, 2017https://github.com/python/mypy/issues/2999#event-999718193
pkchhttps://github.com/pkch
on Mar 18, 2017https://github.com/python/mypy/issues/2999#event-1005637055
Replace isinstance with cast to deal with python#2999; rename testhttps://github.com/pkch/mypy/commit/b7ad8b746e212747f412c52a3493810cb210fcb8
python#2999https://github.com/python/mypy/issues/2999
b7ad8b7https://github.com/pkch/mypy/commit/b7ad8b746e212747f412c52a3493810cb210fcb8
Replace isinstance with cast to deal with python#2999; rename testhttps://github.com/pkch/mypy/commit/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a
python#2999https://github.com/python/mypy/issues/2999
d9f261fhttps://github.com/pkch/mypy/commit/d9f261f3726a7a10f040e2ffd314ce5ef0e9ab5a
gvanrossumhttps://github.com/gvanrossum
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
topic-depends-on-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-depends-on-strict-optional%22
on Apr 24, 2019https://github.com/python/mypy/issues/2999#event-2297964165
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
on Mar 29, 2022https://github.com/python/mypy/issues/2999#issuecomment-1082305010
can't reproducehttps://mypy-play.net/?mypy=0.620&python=3.10&flags=no-strict-optional&gist=860a7c872246d674c2902dbe61103c17
AlexWaygoodhttps://github.com/AlexWaygood
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 29, 2022https://github.com/python/mypy/issues/2999#event-6329425356
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/2999
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/2999
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.