René's URL Explorer Experiment


Title: Returning T instead of UserDefinedClass[T] is not reported as an error · Issue #2905 · python/mypy · GitHub

Open Graph Title: Returning T instead of UserDefinedClass[T] is not reported as an error · Issue #2905 · python/mypy

X Title: Returning T instead of UserDefinedClass[T] is not reported as an error · Issue #2905 · python/mypy

Description: At first glance, the following code should not pass type verification because f and g return or yield T instead of Node[T]: from typing import TypeVar, Generic, Iterator T = TypeVar('T') class Node(Generic[T]): def __init__(self, value: ...

Open Graph Description: At first glance, the following code should not pass type verification because f and g return or yield T instead of Node[T]: from typing import TypeVar, Generic, Iterator T = TypeVar('T') class Node...

X Description: At first glance, the following code should not pass type verification because f and g return or yield T instead of Node[T]: from typing import TypeVar, Generic, Iterator T = TypeVar('T') cl...

Opengraph URL: https://github.com/python/mypy/issues/2905

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Returning T instead of UserDefinedClass[T] is not reported as an error","articleBody":"At first glance, the following code should not pass type verification because `f` and `g` return or yield `T` instead of `Node[T]`:\r\n\r\n```\r\nfrom typing import TypeVar, Generic, Iterator\r\n\r\nT = TypeVar('T')\r\nclass Node(Generic[T]):\r\n    def __init__(self, value: T) -> None:\r\n        self.value = value\r\n\r\ndef f(v: Node) -> Node:\r\n    return v.value\r\n\r\ndef g(v: Node) -> Iterator[Node]:\r\n    yield v.value\r\n```\r\n\r\nHowever, `mypy --strict --python-version 3.6` doesn't report any errors. It does produce a warning:\r\n\r\n> Returning `Any` from function with declared return type `node.Node[Any]` \r\n\r\nbut even the warning is only reported for `f()`, not for `g()`.\r\n\r\nTo be fair, there are ways to call these functions that doesn't violate type expectations, for example `f(Node(Node(1)))` would return `Node(1)` which fits its promised return type. But I was hoping `mypy` might notice that the only way this code would be correct is if the argument to `f()` is a `Node[Node]` rather than just arbitrary `Node`. And so I was expecting `mypy` to force me to write:\r\n\r\n```\r\ndef f(v: Node[Node]) -> Node:\r\n    return v.value\r\n\r\ndef g(v: Node[Node]) -> Node:\r\n    yield v.value\r\n```\r\n\r\nif that's what I meant of course. (Although it's much more likely that it's actually a bug, and that I meant to `return v` rather than `return v.value`; in that case, `mypy` would help me catch that bug.)\r\n\r\nFurthermore, if I add the following code at the end of the original code snippet:\r\n\r\n```\r\nv = Node(1)\r\nf(v)\r\nfor x in g(v):\r\n    pass\r\n```\r\n\r\n`mypy` should be able to see that something is definitely wrong; at this point it's completely clear that `f(v)` won't return the promised `Node`, and `g(v)` won't yield one. But adding those lines does not add any new error or warning messages.","author":{"url":"https://github.com/pkch","@type":"Person","name":"pkch"},"datePublished":"2017-02-24T19:20:34Z","url":"https://github.com/python/mypy/issues/2905"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6d08be37-9194-892b-96be-23748ffb3a14
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC36E:157BA1:4DD551:68D4A2:6B003002
html-safe-nonceea0902db508ab6c247c52e78a15dd1f4fc49d16cf95793511b64fde06942fd77
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzZFOjE1N0JBMTo0REQ1NTE6NjhENEEyOjZCMDAzMDAyIiwidmlzaXRvcl9pZCI6Ijg5MTk4MTUzNTA4NzUzMzY3MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac44f71636debb5bd078cbe746d237fef5c684f7e4627301b183950460f113802e
hovercard-subject-tagissue:210134938
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2905/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f9030c74ae01e91b0e074634793cab44580b1ebe9c527918327ed86b8efcd49b/python/mypy/issues/2905
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f9030c74ae01e91b0e074634793cab44580b1ebe9c527918327ed86b8efcd49b/python/mypy/issues/2905
og:image:altAt first glance, the following code should not pass type verification because f and g return or yield T instead of Node[T]: from typing import TypeVar, Generic, Iterator T = TypeVar('T') class Node...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkch
hostnamegithub.com
expected-hostnamegithub.com
None7d0829bbde9e48b2486cb5dd6d147896eb01d32134627091f818958a935ef3f0
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef3f3a43ca095cdea3abbb394112e971f9fdb94fa
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/2905#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2905
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2905
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/2905
Reloadhttps://github.com/python/mypy/issues/2905
Reloadhttps://github.com/python/mypy/issues/2905
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2905
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2905
Returning T instead of UserDefinedClass[T] is not reported as an errorhttps://github.com/python/mypy/issues/2905#top
https://github.com/pkch
pkchhttps://github.com/pkch
on Feb 24, 2017https://github.com/python/mypy/issues/2905#issue-210134938
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
on Feb 24, 2017https://github.com/python/mypy/issues/2905#issuecomment-282385735
https://github.com/pkch
pkchhttps://github.com/pkch
on Feb 24, 2017https://github.com/python/mypy/issues/2905#issuecomment-282387993
https://github.com/pkch
pkchhttps://github.com/pkch
on Feb 24, 2017https://github.com/python/mypy/issues/2905#issuecomment-282393598
https://github.com/miedzinski
miedzinskihttps://github.com/miedzinski
on Feb 24, 2017https://github.com/python/mypy/issues/2905#issuecomment-282396317
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on Feb 24, 2017https://github.com/python/mypy/issues/2905#issuecomment-282426684
#2901https://github.com/python/mypy/issues/2901
@miedzinskihttps://github.com/miedzinski
#2901https://github.com/python/mypy/issues/2901
ddfisherhttps://github.com/ddfisher
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 24, 2017https://github.com/python/mypy/issues/2905#event-976805738
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/2905
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/2905
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.