René's URL Explorer Experiment


Title: Optional generic not accepted with `--strict-optional` · Issue #2678 · python/mypy · GitHub

Open Graph Title: Optional generic not accepted with `--strict-optional` · Issue #2678 · python/mypy

X Title: Optional generic not accepted with `--strict-optional` · Issue #2678 · python/mypy

Description: When running with --strict-optional, mypy complains about the last statement here. However, this seems like it should work, both because it does work when --strict-optional is left out, and because the revealed type looks like it should ...

Open Graph Description: When running with --strict-optional, mypy complains about the last statement here. However, this seems like it should work, both because it does work when --strict-optional is left out, and because...

X Description: When running with --strict-optional, mypy complains about the last statement here. However, this seems like it should work, both because it does work when --strict-optional is left out, and because...

Opengraph URL: https://github.com/python/mypy/issues/2678

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Optional generic not accepted with `--strict-optional`","articleBody":"When running with `--strict-optional`, mypy complains about the last statement here. However, this seems like it should work, both because it does work when `--strict-optional` is left out, and because the revealed type looks like it should match.\r\n\r\n```python\r\nfrom typing import Optional, Type, TypeVar\r\n\r\n\r\nclass BaseThing: pass\r\nclass ChildThing(BaseThing): pass\r\n\r\n\r\nThingClass = TypeVar(\"ThingClass\", bound=BaseThing)\r\n\r\n\r\ndef get_thing(thing_class: Type[ThingClass]) -> Optional[ThingClass]:\r\n    \"\"\" Get the thing with the given class. Stub implementation. \"\"\"\r\n    return None\r\n\r\nthing = None  # type: Optional[ChildThing]\r\n\r\n# Fails, complaining about `Type argument 1 of \"get_thing\" has incompatible value \"Optional[ChildThing]\"`\r\nthing = get_thing(ChildThing)\r\n\r\n# Revealed type is `Union[scratch_1.ChildThing*, builtins.None]`, which seems like it should \r\n# match Optional[ChildThing].\r\nreveal_type(get_thing(ChildThing))\r\n```","author":{"url":"https://github.com/FuegoFro","@type":"Person","name":"FuegoFro"},"datePublished":"2017-01-11T18:03:16Z","url":"https://github.com/python/mypy/issues/2678"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6e2d1b8c-eb0d-580d-60eb-770f11801e25
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA9E4:29A20E:187E3CD:20F3B7E:6AFFF16F
html-safe-nonce28d593ab0b91580b6a1ecc21f0df10e833d309aa87aaade9c86a572b51a86662
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUU0OjI5QTIwRToxODdFM0NEOjIwRjNCN0U6NkFGRkYxNkYiLCJ2aXNpdG9yX2lkIjoiMTQzNzc1NDQzODg2ODUyOTUxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac42739007a847f728b688503a8fe1f83882aa07bb37a9230187d1102cbd961b0d
hovercard-subject-tagissue:200165537
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2678/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9b59de8078564ae7c3a941e60d24fc5535e225f50ed94ba69b96e5042496ffc9/python/mypy/issues/2678
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9b59de8078564ae7c3a941e60d24fc5535e225f50ed94ba69b96e5042496ffc9/python/mypy/issues/2678
og:image:altWhen running with --strict-optional, mypy complains about the last statement here. However, this seems like it should work, both because it does work when --strict-optional is left out, and because...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFuegoFro
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/2678#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2678
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2678
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/2678
Reloadhttps://github.com/python/mypy/issues/2678
Reloadhttps://github.com/python/mypy/issues/2678
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2678
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2678
#5699https://github.com/python/mypy/pull/5699
Optional generic not accepted with --strict-optionalhttps://github.com/python/mypy/issues/2678#top
#5699https://github.com/python/mypy/pull/5699
https://github.com/ddfisher
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-type-variableshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-variables%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
https://github.com/FuegoFro
FuegoFrohttps://github.com/FuegoFro
on Jan 11, 2017https://github.com/python/mypy/issues/2678#issue-200165537
gvanrossumhttps://github.com/gvanrossum
ddfisherhttps://github.com/ddfisher
on Jan 11, 2017https://github.com/python/mypy/issues/2678#event-919584723
gvanrossumhttps://github.com/gvanrossum
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
topic-type-variableshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-variables%22
on Jan 11, 2017https://github.com/python/mypy/issues/2678#event-919585094
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Jan 11, 2017https://github.com/python/mypy/issues/2678#issuecomment-271959194
https://github.com/ddfisher
ddfisherhttps://github.com/ddfisher
on Jan 11, 2017https://github.com/python/mypy/issues/2678#issuecomment-272022571
gvanrossumhttps://github.com/gvanrossum
topic-strict-optionalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-strict-optional%22
on Jan 11, 2017https://github.com/python/mypy/issues/2678#event-919934834
JukkaLhttps://github.com/JukkaL
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Jan 16, 2017https://github.com/python/mypy/issues/2678#event-924297249
JukkaLhttps://github.com/JukkaL
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
on May 19, 2018https://github.com/python/mypy/issues/2678#event-1635330777
ilevkivskyihttps://github.com/ilevkivskyi
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#5699https://github.com/python/mypy/pull/5699
on Oct 2, 2018https://github.com/python/mypy/issues/2678#event-1879075512
ilevkivskyihttps://github.com/ilevkivskyi
on Oct 2, 2018https://github.com/python/mypy/issues/2678#event-1879075616
Improve usage of outer context for inference (#5699)https://github.com/python/mypy/commit/626ff689e6df171e1aec438b905efdf999bdc09e
#5699https://github.com/python/mypy/pull/5699
https://docs.github.com/articles/closing-issues-via-commit-messages
626ff68https://github.com/python/mypy/commit/626ff689e6df171e1aec438b905efdf999bdc09e
TV4Funhttps://github.com/TV4Fun
on Oct 4, 2018https://github.com/python/mypy/issues/2678#event-1885770939
Improve usage of outer context for inference (python#5699)https://github.com/TV4Fun/mypy/commit/6d886e9c46e892369d71c75dd676839b9eebf9be
python#5699https://github.com/python/mypy/pull/5699
https://docs.github.com/articles/closing-issues-via-commit-messages
6d886e9https://github.com/TV4Fun/mypy/commit/6d886e9c46e892369d71c75dd676839b9eebf9be
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/2678
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/2678
ddfisherhttps://github.com/ddfisher
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-type-variableshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-variables%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.