René's URL Explorer Experiment


Title: Inner method discards type narrowing done in outer method · Issue #2608 · python/mypy · GitHub

Open Graph Title: Inner method discards type narrowing done in outer method · Issue #2608 · python/mypy

X Title: Inner method discards type narrowing done in outer method · Issue #2608 · python/mypy

Description: So everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} Now add some types: def func(arg=None): # type: (Dict[str, str]) -> Dict[s...

Open Graph Description: So everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} Now add some types: def func(arg=N...

X Description: So everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} No...

Opengraph URL: https://github.com/python/mypy/issues/2608

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inner method discards type narrowing done in outer method","articleBody":"So everybody knows not to write\r\n`def foo(arg={'bar': 'baz'}):`\r\n\r\nSo instead one usually writes something like:\r\n```\r\ndef foo(arg=None):\r\n    if arg is None:\r\n        arg = {'bar', 'baz'}\r\n```\r\n\r\nNow add some types:\r\n```\r\ndef func(arg=None):\r\n    # type: (Dict[str, str]) -> Dict[str,str]\r\n    reveal_type(arg)  # Revealed type is 'Union[builtins.dict[builtins.str, builtins.str], builtins.None]'\r\n    if arg is None:\r\n        arg = {'foo': 'bar'}\r\n    reveal_type(arg)  #  Revealed type is 'builtins.dict[builtins.str, builtins.str]'\r\n    return arg\r\n```\r\n\r\nSo all is good, unless you try to create an inner method:\r\n```\r\ndef func(arg=None):\r\n    # type: (Dict[str, str]) -> Dict[str,str]\r\n    reveal_type(arg)  # Revealed type is 'Union[builtins.dict[builtins.str, builtins.str], builtins.None]'\r\n    if arg is None:\r\n        arg = {'foo': 'bar'}\r\n    reveal_type(arg)  #  Revealed type is 'builtins.dict[builtins.str, builtins.str]'\r\n\r\n    def inner():\r\n        # type: () -> Dict[str, str]\r\n        reveal_type(arg)  # Revealed type is 'Union[builtins.dict[builtins.str, builtins.str], builtins.None]'\r\n        return arg  # Incompatible return value type (got \"Optional[Dict[str, str]]\", expected Dict[str, str])\r\n\r\n    return inner()\r\n```\r\n\r\nI guess there are lots of workarounds (assign to temporary variable, pull out the inner method, pass arguments into the inner) but they all require editing existing code which is always scary.  Hmm. I guess the easiest thing is to just add an `assert arg is not None` in the inner.  That's not too intrusive, anyway thought you might want to know.","author":{"url":"https://github.com/euresti","@type":"Person","name":"euresti"},"datePublished":"2016-12-25T21:01:50Z","url":"https://github.com/python/mypy/issues/2608"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8920f512-fbe6-b7ab-2379-9feeaaac62c6
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB422:392206:139D77F:19DD441:6B000C6A
html-safe-noncebb227490c145e24072b7f6b9d3a44579b59322792c9847b2e33edac654713ed1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDIyOjM5MjIwNjoxMzlENzdGOjE5REQ0NDE6NkIwMDBDNkEiLCJ2aXNpdG9yX2lkIjoiMzUwMDgzMDcxODA5Nzg4NjMxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7ce4986474c0b693688a394bb23b0ff1a6cbfbb4611ab667b477ad24dbd82575
hovercard-subject-tagissue:197515047
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2608/issue_layout
twitter:imagehttps://opengraph.githubassets.com/90d5e256819b7bb888b64973fbe9f748d8a419740c8bfde1e3208f7d3520a031/python/mypy/issues/2608
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90d5e256819b7bb888b64973fbe9f748d8a419740c8bfde1e3208f7d3520a031/python/mypy/issues/2608
og:image:altSo everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} Now add some types: def func(arg=N...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameeuresti
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/2608#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2608
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2608
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/2608
Reloadhttps://github.com/python/mypy/issues/2608
Reloadhttps://github.com/python/mypy/issues/2608
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2608
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2608
#15133https://github.com/python/mypy/pull/15133
Inner method discards type narrowing done in outer methodhttps://github.com/python/mypy/issues/2608#top
#15133https://github.com/python/mypy/pull/15133
https://github.com/JukkaL
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-usabilityhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-usability%22
https://github.com/euresti
eurestihttps://github.com/euresti
on Dec 25, 2016https://github.com/python/mypy/issues/2608#issue-197515047
Nexthttps://github.com/python/mypy/issues/2608?timeline_page=1
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Dec 25, 2016https://github.com/python/mypy/issues/2608#issuecomment-269137546
#2145https://github.com/python/mypy/issues/2145
gvanrossumhttps://github.com/gvanrossum
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
on Jan 14, 2017https://github.com/python/mypy/issues/2608#event-923027077
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Jan 16, 2017https://github.com/python/mypy/issues/2608#issuecomment-272859969
JukkaLhttps://github.com/JukkaL
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Jan 16, 2017https://github.com/python/mypy/issues/2608#event-924300666
ilevkivskyihttps://github.com/ilevkivskyi
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
priority-2-lowhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-2-low%22
on Dec 23, 2017https://github.com/python/mypy/issues/2608#event-1400382683
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Dec 23, 2017https://github.com/python/mypy/issues/2608#issuecomment-353723285
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Dec 23, 2017https://github.com/python/mypy/issues/2608#issuecomment-353728701
https://github.com/carljm
carljmhttps://github.com/carljm
on Dec 23, 2017https://github.com/python/mypy/issues/2608#issuecomment-353731470
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Dec 24, 2017https://github.com/python/mypy/issues/2608#issuecomment-353779555
ilevkivskyihttps://github.com/ilevkivskyi
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-usabilityhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-usability%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Oct 7, 2018https://github.com/python/mypy/issues/2608#event-1889142404
https://github.com/ilevkivskyi
ilevkivskyihttps://github.com/ilevkivskyi
on Oct 7, 2018https://github.com/python/mypy/issues/2608#issuecomment-427680134
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on May 5, 2022https://github.com/python/mypy/issues/2608#issuecomment-1118117240
https://github.com/mrolle45
mrolle45https://github.com/mrolle45
on May 5, 2022https://github.com/python/mypy/issues/2608#issuecomment-1118118968
https://github.com/mrolle45
mrolle45https://github.com/mrolle45
on May 5, 2022https://github.com/python/mypy/issues/2608#issuecomment-1119074713
https://github.com/erictraut
erictrauthttps://github.com/erictraut
on May 5, 2022https://github.com/python/mypy/issues/2608#issuecomment-1119139820
https://github.com/mrolle45
mrolle45https://github.com/mrolle45
on May 6, 2022https://github.com/python/mypy/issues/2608#issuecomment-1119195929
https://github.com/mrolle45
mrolle45https://github.com/mrolle45
on May 7, 2022https://github.com/python/mypy/issues/2608#issuecomment-1120157163
https://github.com/mrolle45
mrolle45https://github.com/mrolle45
on May 7, 2022https://github.com/python/mypy/issues/2608#issuecomment-1120164411
temp.txthttps://github.com/python/mypy/files/8644737/temp.txt
JukkaLhttps://github.com/JukkaL
on Apr 24, 2023https://github.com/python/mypy/issues/2608#event-9086144520
https://github.com/JukkaL
JukkaLhttps://github.com/JukkaL
on Apr 24, 2023https://github.com/python/mypy/issues/2608#issuecomment-1520947494
https://github.com/XuehaiPan
XuehaiPanhttps://github.com/XuehaiPan
on Apr 30, 2023https://github.com/python/mypy/issues/2608#issuecomment-1528982671
JukkaLhttps://github.com/JukkaL
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#15133https://github.com/python/mypy/pull/15133
on May 3, 2023https://github.com/python/mypy/issues/2608#event-9155071067
JukkaLhttps://github.com/JukkaL
on May 3, 2023https://github.com/python/mypy/issues/2608#event-9155071551
Propagate type narrowing to nested functions (#15133)https://github.com/python/mypy/commit/8c14cbaf344d2b464aa52eacf54e88792dee3c4a
#15133https://github.com/python/mypy/pull/15133
https://docs.github.com/articles/closing-issues-via-commit-messages
8c14cbahttps://github.com/python/mypy/commit/8c14cbaf344d2b464aa52eacf54e88792dee3c4a
https://github.com/bast1aan
bast1aanhttps://github.com/bast1aan
on Aug 23, 2023https://github.com/python/mypy/issues/2608#issuecomment-1689653609
https://github.com/karlicoss
karlicosshttps://github.com/karlicoss
on Aug 31, 2023https://github.com/python/mypy/issues/2608#issuecomment-1701877801
@bast1aanhttps://github.com/bast1aan
Finalhttps://docs.python.org/3/library/typing.html?highlight=final#typing.Final
https://github.com/OlegAlexander
OlegAlexanderhttps://github.com/OlegAlexander
on Sep 23, 2023https://github.com/python/mypy/issues/2608#issuecomment-1732393945
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/2608
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/2608
JukkaLhttps://github.com/JukkaL
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
featurehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22feature%22
priority-0-highhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-0-high%22
topic-type-narrowingConditional type narrowing / binderhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-type-narrowing%22
topic-usabilityhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-usability%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.