Title: Inner method discards type narrowing done in outer method · Issue #2608 · python/mypy · GitHub
Open Graph Title: Inner method discards type narrowing done in outer method · Issue #2608 · python/mypy
X Title: Inner method discards type narrowing done in outer method · Issue #2608 · python/mypy
Description: So everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} Now add some types: def func(arg=None): # type: (Dict[str, str]) -> Dict[s...
Open Graph Description: So everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} Now add some types: def func(arg=N...
X Description: So everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} No...
Opengraph URL: https://github.com/python/mypy/issues/2608
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inner method discards type narrowing done in outer method","articleBody":"So everybody knows not to write\r\n`def foo(arg={'bar': 'baz'}):`\r\n\r\nSo instead one usually writes something like:\r\n```\r\ndef foo(arg=None):\r\n if arg is None:\r\n arg = {'bar', 'baz'}\r\n```\r\n\r\nNow add some types:\r\n```\r\ndef func(arg=None):\r\n # type: (Dict[str, str]) -> Dict[str,str]\r\n reveal_type(arg) # Revealed type is 'Union[builtins.dict[builtins.str, builtins.str], builtins.None]'\r\n if arg is None:\r\n arg = {'foo': 'bar'}\r\n reveal_type(arg) # Revealed type is 'builtins.dict[builtins.str, builtins.str]'\r\n return arg\r\n```\r\n\r\nSo all is good, unless you try to create an inner method:\r\n```\r\ndef func(arg=None):\r\n # type: (Dict[str, str]) -> Dict[str,str]\r\n reveal_type(arg) # Revealed type is 'Union[builtins.dict[builtins.str, builtins.str], builtins.None]'\r\n if arg is None:\r\n arg = {'foo': 'bar'}\r\n reveal_type(arg) # Revealed type is 'builtins.dict[builtins.str, builtins.str]'\r\n\r\n def inner():\r\n # type: () -> Dict[str, str]\r\n reveal_type(arg) # Revealed type is 'Union[builtins.dict[builtins.str, builtins.str], builtins.None]'\r\n return arg # Incompatible return value type (got \"Optional[Dict[str, str]]\", expected Dict[str, str])\r\n\r\n return inner()\r\n```\r\n\r\nI guess there are lots of workarounds (assign to temporary variable, pull out the inner method, pass arguments into the inner) but they all require editing existing code which is always scary. Hmm. I guess the easiest thing is to just add an `assert arg is not None` in the inner. That's not too intrusive, anyway thought you might want to know.","author":{"url":"https://github.com/euresti","@type":"Person","name":"euresti"},"datePublished":"2016-12-25T21:01:50Z","url":"https://github.com/python/mypy/issues/2608"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8920f512-fbe6-b7ab-2379-9feeaaac62c6 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B422:392206:139D77F:19DD441:6B000C6A |
| html-safe-nonce | bb227490c145e24072b7f6b9d3a44579b59322792c9847b2e33edac654713ed1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDIyOjM5MjIwNjoxMzlENzdGOjE5REQ0NDE6NkIwMDBDNkEiLCJ2aXNpdG9yX2lkIjoiMzUwMDgzMDcxODA5Nzg4NjMxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7ce4986474c0b693688a394bb23b0ff1a6cbfbb4611ab667b477ad24dbd82575 |
| hovercard-subject-tag | issue:197515047 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2608/issue_layout |
| twitter:image | https://opengraph.githubassets.com/90d5e256819b7bb888b64973fbe9f748d8a419740c8bfde1e3208f7d3520a031/python/mypy/issues/2608 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/90d5e256819b7bb888b64973fbe9f748d8a419740c8bfde1e3208f7d3520a031/python/mypy/issues/2608 |
| og:image:alt | So everybody knows not to write def foo(arg={'bar': 'baz'}): So instead one usually writes something like: def foo(arg=None): if arg is None: arg = {'bar', 'baz'} Now add some types: def func(arg=N... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | euresti |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width