René's URL Explorer Experiment


Title: Type error in mypy? · Issue #2222 · python/mypy · GitHub

Open Graph Title: Type error in mypy? · Issue #2222 · python/mypy

X Title: Type error in mypy? · Issue #2222 · python/mypy

Description: During #2221 (which I have little hope to be actually accepted) I ran into this function in binder.py: def get(self, expr: Union[Expression, Var]) -> Type: return self._get(expr.literal_hash) The Var case comes from analyze_var_ref() in ...

Open Graph Description: During #2221 (which I have little hope to be actually accepted) I ran into this function in binder.py: def get(self, expr: Union[Expression, Var]) -> Type: return self._get(expr.literal_hash) The V...

X Description: During #2221 (which I have little hope to be actually accepted) I ran into this function in binder.py: def get(self, expr: Union[Expression, Var]) -> Type: return self._get(expr.literal_hash) Th...

Opengraph URL: https://github.com/python/mypy/issues/2222

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type error in mypy? ","articleBody":"During #2221 (which I have little hope to be actually accepted) I ran into [this](../../mypy/blob/master/mypy/binder.py#L108) function in binder.py:\n\n``` Python\n    def get(self, expr: Union[Expression, Var]) -> Type:\n        return self._get(expr.literal_hash)\n```\n\nThe Var case comes from [`analyze_var_ref()`](../../mypy/blob/master/mypy/checkexpr.py#L160) in checkexpr.py.\n\nWell, I couldn't find where Var.literal_hash is initialized to anything other than None, and returning None in the Var case passes all the tests. So I tried to replace it with something like the following:\n\n``` Python\n    def get(self, expr: Union[Expression, Var]) -> Type:\n        if isinstance(expr, Var):\n            new_expr = NameExpr(expr.name())\n        else:\n            new_expr = expr\n        return self._get(new_expr.literal_hash)\n```\n\nI then ran mypy on itself, but it raised many errors. So I ran the test suite, and I got many failures; however, it seems that these failures are due to a _more precise_ typechecking. For example, take testModifyLoopFor4 (simplified):\n\n``` Python\nx = None # type: Union[int, str]\nx = 1\n\nif 1:\n    x = 'a'\n```\n\nThe test does not say anything bad in this part, but mypy now complains that x is an int and therefore 'a' cannot be assigned into it. It might be too restrictive, but it is my understanding that this is the desired behavior, since \"x=1\" rebinds the variable into int (it's valid since int is part of the Union) and then it tries to rebind it to str, but now it is not possible.\n\nI am not 100% sure, since I am not 100% sure how the code works and what is the expected behavior, but it looks like a bug - and if so, there are ~40 \"type errors\" to fix in the source code (although I suspect none of them is an actual error).\n\nSo what is the expected behavior? When and how should types rebind?\n","author":{"url":"https://github.com/elazarg","@type":"Person","name":"elazarg"},"datePublished":"2016-10-06T05:32:42Z","url":"https://github.com/python/mypy/issues/2222"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:14d7630a-fb55-8b6c-fd1e-728fa139e168
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8F5E:3F9D33:2A4D2FC:3999FF3:6B005055
html-safe-noncef88a27c73048f3daf290a8e7ec6a4dba0b270b01b8a7f2d32b87301dd80018d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjVFOjNGOUQzMzoyQTREMkZDOjM5OTlGRjM6NkIwMDUwNTUiLCJ2aXNpdG9yX2lkIjoiMjYzNTYwMDk0MDYxNDMwNzkyNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbc09820c9a4ea940f6f9ba81e708f8fa84dcd542d335ef5b4b4366c7021d66ee
hovercard-subject-tagissue:181328094
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2222/issue_layout
twitter:imagehttps://opengraph.githubassets.com/da634b5c0b0fb118c7766ea0170bb839112522653c906b109f501245feeb72a1/python/mypy/issues/2222
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/da634b5c0b0fb118c7766ea0170bb839112522653c906b109f501245feeb72a1/python/mypy/issues/2222
og:image:altDuring #2221 (which I have little hope to be actually accepted) I ran into this function in binder.py: def get(self, expr: Union[Expression, Var]) -> Type: return self._get(expr.literal_hash) The V...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelazarg
hostnamegithub.com
expected-hostnamegithub.com
Nonef420f4996e6b1ff1ccd6d7683f8134f4b5f0f8a50124c210dbfe7490e5644abb
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26e00df917aba0f128135dc073ea0c5e33a70d40
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/2222#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2222
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2222
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/2222
Reloadhttps://github.com/python/mypy/issues/2222
Reloadhttps://github.com/python/mypy/issues/2222
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests546 (546)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2222
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2222
Type error in mypy? https://github.com/python/mypy/issues/2222#top
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Oct 6, 2016https://github.com/python/mypy/issues/2222#issue-181328094
#2221https://github.com/python/mypy/pull/2221
thishttps://github.com/python/mypy/blob/master/mypy/binder.py#L108
analyze_var_ref()https://github.com/python/mypy/blob/master/mypy/checkexpr.py#L160
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Oct 6, 2016https://github.com/python/mypy/issues/2222#issuecomment-251871458
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Oct 6, 2016https://github.com/python/mypy/issues/2222#issuecomment-251871817
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Oct 6, 2016https://github.com/python/mypy/issues/2222#issuecomment-251871933
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Oct 6, 2016https://github.com/python/mypy/issues/2222#issuecomment-251873849
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Oct 6, 2016https://github.com/python/mypy/issues/2222#issuecomment-251949394
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Oct 13, 2016https://github.com/python/mypy/issues/2222#issuecomment-253606797
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Oct 13, 2016https://github.com/python/mypy/issues/2222#issuecomment-253619111
#2238https://github.com/python/mypy/pull/2238
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Oct 20, 2016https://github.com/python/mypy/issues/2222#issuecomment-255242383
gvanrossumhttps://github.com/gvanrossum
on Oct 20, 2016https://github.com/python/mypy/issues/2222#event-831309303
https://github.com/rwbarton
rwbartonhttps://github.com/rwbarton
on Oct 20, 2016https://github.com/python/mypy/issues/2222#issuecomment-255243808
https://github.com/elazarg
elazarghttps://github.com/elazarg
on Oct 25, 2016https://github.com/python/mypy/issues/2222#issuecomment-256138622
gvanrossumhttps://github.com/gvanrossum
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Jan 6, 2017https://github.com/python/mypy/issues/2222#event-914705563
gvanrossumhttps://github.com/gvanrossum
on Mar 29, 2017https://github.com/python/mypy/issues/2222#event-1021273995
elazarghttps://github.com/elazarg
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 3, 2017https://github.com/python/mypy/issues/2222#event-1027251204
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/2222
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/2222
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.