Title: Proposal: Refactor extract class AssignmentStatementAnalyzer from SemanticAnalyzer · Issue #2198 · python/mypy · GitHub
Open Graph Title: Proposal: Refactor extract class AssignmentStatementAnalyzer from SemanticAnalyzer · Issue #2198 · python/mypy
X Title: Proposal: Refactor extract class AssignmentStatementAnalyzer from SemanticAnalyzer · Issue #2198 · python/mypy
Description: I want to propose a refactoring that I will volunteer to execute. Before spending time on it, I would like to see if there are any high-level objections. Implementation Proposal (1) The following tree of methods will be extracted from Se...
Open Graph Description: I want to propose a refactoring that I will volunteer to execute. Before spending time on it, I would like to see if there are any high-level objections. Implementation Proposal (1) The following t...
X Description: I want to propose a refactoring that I will volunteer to execute. Before spending time on it, I would like to see if there are any high-level objections. Implementation Proposal (1) The following t...
Opengraph URL: https://github.com/python/mypy/issues/2198
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Proposal: Refactor extract class AssignmentStatementAnalyzer from SemanticAnalyzer","articleBody":"I want to propose a refactoring that I will volunteer to execute. Before spending time on it, I would like to see if there are any high-level objections.\n### Implementation Proposal\n\n(1) The following tree of methods will be extracted from SemanticAnalyzer and moved to a new class _AssignmentStatementAnalyzer that is used internally by SemanticAnalyzer.\n\n```\n visit_assignment_stmt (public)\n analyze_simple_literal_type\n\n check_and_set_up_type_alias\n\n process_newtype_declaration\n analyze_newtype_declaration\n check_newtype_args\n build_newtype_typeinfo\n make_argument\n\n process_typevar_declaration\n check_typevar_name\n get_typevar_declaration\n analyze_types\n process_typevar_parameters\n\n process_namedtuple_definition\n check_namedtuple\n parse_namedtuple_args\n parse_namedtuple_fields_with_types\n fail_namedtuple_arg\n build_namedtuple_typeinfo\n```\n\nAll methods in the new _AssignmentStatementAnalyzer class except visit_assignment_stmt() will be prefixed with underscore to indicate that they are private to the class.\n\n(2) SemanticAnalyzer.visit_assignment_stmt() will be altered to delegate to _AssignmentStatementAnalyzer.visit_assignment_stmt().\n### Benefits\n- Total surface area of SemanticAnalyzer is reduced by:\n - 582 lines of code -- 25% of the original 2424 LOC in SemanticAnalyzer\n - 18 methods\n- Public surface area of the extracted method group is reduced to 1 method:\n - visit_assignment_stmt()\n\nI believe that this change will significantly improve the readability of SemanticAnalyzer for future readers.\n","author":{"url":"https://github.com/davidfstr","@type":"Person","name":"davidfstr"},"datePublished":"2016-09-30T05:30:26Z","url":"https://github.com/python/mypy/issues/2198"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:86fdbb9b-f359-61e2-ccd5-8e2480ae4cee |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8D58:34D7A7:2E2C59:3E8964:6B0026FF |
| html-safe-nonce | e40a8069ec3faa080ff05bd0629a384312cc62a7cbaa9b672711eacc9a2d88bb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDU4OjM0RDdBNzoyRTJDNTk6M0U4OTY0OjZCMDAyNkZGIiwidmlzaXRvcl9pZCI6Ijg5MjEzNjk1NzQ5ODU3MDUyMTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f66b1cf0ce18ec1fb97d5614e2234f95635902021e9a4f9b04340ce3f9994981 |
| hovercard-subject-tag | issue:180223077 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2198/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6085cf9046bbc5d9c1666a0ce8bb91dcb98e64584a9d4e1313ce34e5cbc6b360/python/mypy/issues/2198 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6085cf9046bbc5d9c1666a0ce8bb91dcb98e64584a9d4e1313ce34e5cbc6b360/python/mypy/issues/2198 |
| og:image:alt | I want to propose a refactoring that I will volunteer to execute. Before spending time on it, I would like to see if there are any high-level objections. Implementation Proposal (1) The following t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | davidfstr |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4eb4cba0d69f045374ac15de9666d22b0961e1d555cc3824f36b7734c00c78e0 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 44c658b24abf00491fb7ae5f56d42c9f38cbeab2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width