Title: Inconsistency with unions and overloads in when checking overlapping op methods · Issue #2129 · python/mypy · GitHub
Open Graph Title: Inconsistency with unions and overloads in when checking overlapping op methods · Issue #2129 · python/mypy
X Title: Inconsistency with unions and overloads in when checking overlapping op methods · Issue #2129 · python/mypy
Description: As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operator methods). Here is a simplified versio...
Open Graph Description: As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operat...
X Description: As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operat...
Mail addresses
notifications@github.com
Opengraph URL: https://github.com/python/mypy/issues/2129
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistency with unions and overloads in when checking overlapping op methods","articleBody":"As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the `__add__` and `__radd__` methods (or any pair of operator methods). Here is a simplified version of `decimal.Decimal`:\n\n``` python\nfrom typing import Union\n\nclass FakeDecimal1:\n def __add__(self, other: Union[int, FakeDecimal1]) -> FakeDecimal1:\n return FakeDecimal1()\n def __radd__(self, other: Union[int, FakeDecimal1]) -> FakeDecimal1:\n return FakeDecimal1()\n```\n\nWhen typechecking this, I got the following (and somewhat cryptic) error message:\n\n```\nexperiments\\test.py: note: In member \"__radd__\" of class \"FakeDecimal\":\nexperiments\\test.py:6: error: Forward operator \"__add__\" is not callable\n```\n\nIt seems mypy wanted me to do this instead:\n\n``` python\nfrom typing import Union\n\nclass FakeDecimal2:\n def __add__(self, other: Union[int, FakeDecimal2]) -> FakeDecimal2:\n return FakeDecimal2()\n def __radd__(self, other: int) -> FakeDecimal2:\n return FakeDecimal2()\n```\n\nHowever, the following code which uses overrides instead of Union does _not_ result in any errors, which feels inconsistent:\n\n``` python\nclass FakeDecimal3:\n @overload\n def __add__(self, other: int) -> FakeDecimal3:\n return FakeDecimal2()\n @overload\n def __add__(self, other: FakeDecimal3) -> FakeDecimal3:\n return FakeDecimal3()\n @overload\n def __radd__(self, other: int) -> FakeDecimal3:\n return FakeDecimal2()\n @overload\n def __radd__(self, other: FakeDecimal3) -> FakeDecimal3:\n return FakeDecimal2()\n```\n\nAfter some digging, it appeared to me that the reason for this behavior is because the [`check_overlapping_op_methods`](https://github.com/python/mypy/blob/5e822a8fe76f8ffc25f12943d9682f111209897d/mypy/checker.py#L664) within `checker.py` handles the case where `forward_type` is either a `CallableType`, `Overloaded`, or `AnyType`, but _not_ the case where it's a `UnionType`. \n\nIs this intentional, or an oversight? I _think_ this is a bug, mainly since if mypy accepts version 3, it ought to accept verison 1? Or perhaps the fact that `__radd__` should never need to accept a value of the same type as its instance means that the version 2 is more correct and versions 1 and 3 ought to be rejected?\n\n(For what it's worth, adding a new case to make `UnionType` do the same thing as the `Overloaded` case makes version 1 pass.)\n\nThis is perhaps related: https://github.com/python/mypy/issues/1442\n","author":{"url":"https://github.com/Michael0x2a","@type":"Person","name":"Michael0x2a"},"datePublished":"2016-09-14T07:19:28Z","url":"https://github.com/python/mypy/issues/2129"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8d37d601-7648-9eb0-7933-f7f6d6e4c235 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D466:30DBED:2A336A3:3715E99:6B0007C2 |
| html-safe-nonce | e032117831ff052c8b418610c56ca38d92d0c8e4cde97f2a25e7cb6495936254 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDY2OjMwREJFRDoyQTMzNkEzOjM3MTVFOTk6NkIwMDA3QzIiLCJ2aXNpdG9yX2lkIjoiMjI5NzE5MjkxMTQ5MTU4MzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bcc18eb656e496c75fbeae65c427428c8a5adb69765d854577f304a97288367f |
| hovercard-subject-tag | issue:176833190 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2129/issue_layout |
| twitter:image | https://opengraph.githubassets.com/430481b8cc4fdc1f6812cb3952b2cdf62a2e07d011eb3620e2e70d7a49ec8323/python/mypy/issues/2129 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/430481b8cc4fdc1f6812cb3952b2cdf62a2e07d011eb3620e2e70d7a49ec8323/python/mypy/issues/2129 |
| og:image:alt | As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Michael0x2a |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/mypy git https://github.com/python/mypy.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 7053637 |
| octolytics-dimension-repository_nwo | python/mypy |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 7053637 |
| octolytics-dimension-repository_network_root_nwo | python/mypy |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 16a11879678aaf97e2a42c33ee70830aa084fa37 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width