René's URL Explorer Experiment


Title: Inconsistency with unions and overloads in when checking overlapping op methods · Issue #2129 · python/mypy · GitHub

Open Graph Title: Inconsistency with unions and overloads in when checking overlapping op methods · Issue #2129 · python/mypy

X Title: Inconsistency with unions and overloads in when checking overlapping op methods · Issue #2129 · python/mypy

Description: As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operator methods). Here is a simplified versio...

Open Graph Description: As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operat...

X Description: As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operat...

Mail addresses
notifications@github.com

Opengraph URL: https://github.com/python/mypy/issues/2129

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Inconsistency with unions and overloads in when checking overlapping op methods","articleBody":"As a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the `__add__` and `__radd__` methods (or any pair of operator methods). Here is a simplified version of `decimal.Decimal`:\n\n``` python\nfrom typing import Union\n\nclass FakeDecimal1:\n    def __add__(self, other: Union[int, FakeDecimal1]) -> FakeDecimal1:\n        return FakeDecimal1()\n    def __radd__(self, other: Union[int, FakeDecimal1]) -> FakeDecimal1:\n        return FakeDecimal1()\n```\n\nWhen typechecking this, I got the following (and somewhat cryptic) error message:\n\n```\nexperiments\\test.py: note: In member \"__radd__\" of class \"FakeDecimal\":\nexperiments\\test.py:6: error: Forward operator \"__add__\" is not callable\n```\n\nIt seems mypy wanted me to do this instead:\n\n``` python\nfrom typing import Union\n\nclass FakeDecimal2:\n    def __add__(self, other: Union[int, FakeDecimal2]) -> FakeDecimal2:\n        return FakeDecimal2()\n    def __radd__(self, other: int) -> FakeDecimal2:\n        return FakeDecimal2()\n```\n\nHowever, the following code which uses overrides instead of Union does _not_ result in any errors, which feels inconsistent:\n\n``` python\nclass FakeDecimal3:\n    @overload\n    def __add__(self, other: int) -> FakeDecimal3:\n        return FakeDecimal2()\n    @overload\n    def __add__(self, other: FakeDecimal3) -> FakeDecimal3:\n        return FakeDecimal3()\n    @overload\n    def __radd__(self, other: int) -> FakeDecimal3:\n        return FakeDecimal2()\n    @overload\n    def __radd__(self, other: FakeDecimal3) -> FakeDecimal3:\n        return FakeDecimal2()\n```\n\nAfter some digging, it appeared to me that the reason for this behavior is because the [`check_overlapping_op_methods`](https://github.com/python/mypy/blob/5e822a8fe76f8ffc25f12943d9682f111209897d/mypy/checker.py#L664) within `checker.py` handles the case where `forward_type` is either a `CallableType`, `Overloaded`, or `AnyType`, but _not_ the case where it's a `UnionType`. \n\nIs this intentional, or an oversight? I _think_ this is a bug, mainly since if mypy accepts version 3, it ought to accept verison 1? Or perhaps the fact that `__radd__` should never need to accept a value of the same type as its instance means that the version 2 is more correct and versions 1 and 3 ought to be rejected?\n\n(For what it's worth, adding a new case to make `UnionType` do the same thing as the `Overloaded` case makes version 1 pass.)\n\nThis is perhaps related: https://github.com/python/mypy/issues/1442\n","author":{"url":"https://github.com/Michael0x2a","@type":"Person","name":"Michael0x2a"},"datePublished":"2016-09-14T07:19:28Z","url":"https://github.com/python/mypy/issues/2129"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8d37d601-7648-9eb0-7933-f7f6d6e4c235
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD466:30DBED:2A336A3:3715E99:6B0007C2
html-safe-noncee032117831ff052c8b418610c56ca38d92d0c8e4cde97f2a25e7cb6495936254
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDY2OjMwREJFRDoyQTMzNkEzOjM3MTVFOTk6NkIwMDA3QzIiLCJ2aXNpdG9yX2lkIjoiMjI5NzE5MjkxMTQ5MTU4MzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbcc18eb656e496c75fbeae65c427428c8a5adb69765d854577f304a97288367f
hovercard-subject-tagissue:176833190
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/python/mypy/2129/issue_layout
twitter:imagehttps://opengraph.githubassets.com/430481b8cc4fdc1f6812cb3952b2cdf62a2e07d011eb3620e2e70d7a49ec8323/python/mypy/issues/2129
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/430481b8cc4fdc1f6812cb3952b2cdf62a2e07d011eb3620e2e70d7a49ec8323/python/mypy/issues/2129
og:image:altAs a part of my adventures in attempting to add semi-usable stubs for the fractions and statistics modules, I ran into an edge case involving the __add__ and __radd__ methods (or any pair of operat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameMichael0x2a
hostnamegithub.com
expected-hostnamegithub.com
None0a0d8686a27478df474dd7415776a7a080cde8838b3cd92ea7601187572e5729
turbo-cache-controlno-preview
go-importgithub.com/python/mypy git https://github.com/python/mypy.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id7053637
octolytics-dimension-repository_nwopython/mypy
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id7053637
octolytics-dimension-repository_network_root_nwopython/mypy
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release16a11879678aaf97e2a42c33ee70830aa084fa37
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/python/mypy/issues/2129#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2129
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fmypy%2Fissues%2F2129
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=python%2Fmypy
Reloadhttps://github.com/python/mypy/issues/2129
Reloadhttps://github.com/python/mypy/issues/2129
Reloadhttps://github.com/python/mypy/issues/2129
pythonhttps://github.com/python
mypyhttps://github.com/python/mypy
Codehttps://github.com/python/mypy
Issues2.7k (2.7k)https://github.com/python/mypy/issues
Pull requests547 (547)https://github.com/python/mypy/pulls
Actionshttps://github.com/python/mypy/actions
Projectshttps://github.com/python/mypy/projects
Wikihttps://github.com/python/mypy/wiki
Security and qualityhttps://github.com/python/mypy/security
Insightshttps://github.com/python/mypy/insights
https://github.com/python/mypy
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2129
New issuehttps://github.com/login?return_to=https://github.com/python/mypy/issues/2129
Inconsistency with unions and overloads in when checking overlapping op methodshttps://github.com/python/mypy/issues/2129#top
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Sep 14, 2016https://github.com/python/mypy/issues/2129#issue-176833190
check_overlapping_op_methodshttps://github.com/python/mypy/blob/5e822a8fe76f8ffc25f12943d9682f111209897d/mypy/checker.py#L664
#1442https://github.com/python/mypy/issues/1442
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
on Sep 14, 2016https://github.com/python/mypy/issues/2129#issuecomment-247060239
#1264https://github.com/python/mypy/issues/1264
#1987https://github.com/python/mypy/issues/1987
@overloadhttps://github.com/overload
@overloadhttps://github.com/overload
@overloadhttps://github.com/overload
@overloadhttps://github.com/overload
mypy/mypy/checker.pyhttps://github.com/python/mypy/blob/5e822a8fe76f8ffc25f12943d9682f111209897d/mypy/checker.py#L664
5e822a8https://github.com/python/mypy/commit/5e822a8fe76f8ffc25f12943d9682f111209897d
#1442https://github.com/python/mypy/issues/1442
#1442https://github.com/python/mypy/issues/1442
#2129https://github.com/python/mypy/issues/2129
https://github.com/notifications/unsubscribe-auth/ACwrMssgEMm2l0edVgW7YOrdC83uC-7Cks5qp6ACgaJpZM4J8eCwhttps://github.com/notifications/unsubscribe-auth/ACwrMssgEMm2l0edVgW7YOrdC83uC-7Cks5qp6ACgaJpZM4J8eCw
mkurekhttps://github.com/mkurek
on Dec 21, 2016https://github.com/python/mypy/issues/2129#event-901311840
Use specific types in dateutil.relativedelta stubshttps://github.com/mkurek/typeshed/commit/ebd582317ccc81531bbd738c5a720e32cdde5dca
ebd5823https://github.com/mkurek/typeshed/commit/ebd582317ccc81531bbd738c5a720e32cdde5dca
ambvhttps://github.com/ambv
on Dec 28, 2016https://github.com/python/mypy/issues/2129#event-906790979
Use specific types in dateutil.relativedelta stubshttps://github.com/python/typeshed/commit/43f18bc830b75a270dc77f78a2039c82c62315a7
43f18bchttps://github.com/python/typeshed/commit/43f18bc830b75a270dc77f78a2039c82c62315a7
JukkaLhttps://github.com/JukkaL
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
on Jan 18, 2017https://github.com/python/mypy/issues/2129#event-927908812
JukkaLhttps://github.com/JukkaL
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
on May 18, 2018https://github.com/python/mypy/issues/2129#event-1635326979
ilevkivskyihttps://github.com/ilevkivskyi
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
on May 20, 2018https://github.com/python/mypy/issues/2129#event-1635800156
https://github.com/Michael0x2a
Michael0x2ahttps://github.com/Michael0x2a
on Jun 15, 2018https://github.com/python/mypy/issues/2129#issuecomment-397518107
#3086https://github.com/python/mypy/pull/3086
Michael0x2ahttps://github.com/Michael0x2a
completedhttps://github.com/python/mypy/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 15, 2018https://github.com/python/mypy/issues/2129#event-1682659227
Sign up for freehttps://github.com/signup?return_to=https://github.com/python/mypy/issues/2129
Sign in to commenthttps://github.com/login?return_to=https://github.com/python/mypy/issues/2129
bugmypy got something wronghttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22bug%22
false-positivemypy gave an error on correct codehttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22false-positive%22
priority-1-normalhttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22priority-1-normal%22
topic-overloadshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-overloads%22
topic-union-typeshttps://github.com/python/mypy/issues?q=state%3Aopen%20label%3A%22topic-union-types%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.